From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 720BFC54FAA for ; Wed, 28 Aug 2024 13:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=69SKT+PKbsqR/IWoM1lSbvTSHLKO5Vqf0QLF3x2EfAc=; b=BF8Nk4OiO90n5sj9lC7Jt3lHqO 2qj8u2WGQEBGwyiCtJrAKSAFFJe+SAqW9mLt6NgOVJQap7jN0VB7/YKsfRAh5B8gj+NFT+FVJUG7f wV1/ZpKpVdpu0Xc94nikfujy94/O9rmMfNW/GHXqSBKO5Dp8RngGznvQ6hsCQj0JHUKudbAhyyb8p kEsgjYRU/ASqe61jh7NiYqxHyjFCCEXcdsi24hSnRSLBZTk6yubWJvduS3HES/ckaWmpxMZYBEt+B N6wLJGJsBM5RUCd8va4MJWG0rbktitWmtQbjMKQPtxB4qZEiSV+lBNNl4fST+I1bdg+ctR1x3BLqS YOLeXeQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjIMZ-0000000FSVy-1u5o; Wed, 28 Aug 2024 13:05:27 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjIJ8-0000000FRg4-48hO; Wed, 28 Aug 2024 13:01:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=69SKT+PKbsqR/IWoM1lSbvTSHLKO5Vqf0QLF3x2EfAc=; b=Cp5ECIh8zK9jXYUjfefTv96G+L q2cQWq0FYGLEkkAxx1g8xXSQQrysmkdfkRLqD2EeLWRWjXJHrrnwAN2P5yZtg1yojhEcvxqis5XIu JvUCwCPYPkZW83LBOV713DwvQJhtz36GGXRmlzeDf8/qQJE+9YiHlQVPP7UWvi/Mdif3Jm0iu5ni7 WZCGZyATECOocrQ5DoA6d2cDg0DLiBxkLsf3Y2rF1T47vMnimK/H+TgubWjDVemX1Ga+VxPGGonyp NpQdFoRCDFj4HCNeeIrchUWrX+/5hvL2tuJePLoGUnVRwMF5RSrOhcQTJd/uXo04/MuUFAy36yf7B VhqG0s8g==; Received: from i5e8616cd.versanet.de ([94.134.22.205] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sjIJ3-0005Q5-M3; Wed, 28 Aug 2024 15:01:49 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Jonathan Liu , "Rob Herring (Arm)" Cc: Conor Dooley , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, FUKAUMI Naoki , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] arm64: dts: rockchip: Enable RK809 audio codec for Radxa ROCK 4C+ Date: Wed, 28 Aug 2024 15:03:01 +0200 Message-ID: <3044642.0vhOF50zNu@diego> In-Reply-To: <172484936512.3462690.18423493121475512611.robh@kernel.org> References: <20240828074755.1320692-1-net147@gmail.com> <172484936512.3462690.18423493121475512611.robh@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240828_060155_061375_7C3E567E X-CRM114-Status: GOOD ( 21.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 28. August 2024, 14:51:12 CEST schrieb Rob Herring (Arm): > > On Wed, 28 Aug 2024 17:47:53 +1000, Jonathan Liu wrote: > > This adds the necessary device tree changes to enable analog audio > > output for the 3.5 mm TRS headphone jack on the Radxa ROCK 4C+ with > > its RK809 audio codec. > > > > Signed-off-by: Jonathan Liu > > --- > > .../boot/dts/rockchip/rk3399-rock-4c-plus.dts | 46 ++++++++++++++++++- > > 1 file changed, 45 insertions(+), 1 deletion(-) > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y rockchip/rk3399-rock-4c-plus.dtb' for 20240828074755.1320692-1-net147@gmail.com: > > arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dtb: pmic: vsel1-gpio: {'rockchip,pins': [[1, 17, 0, 194]], 'phandle': 138} is not of type 'array' > from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml# > arch/arm64/boot/dts/rockchip/rk3399-rock-4c-plus.dtb: pmic: vsel2-gpio: {'rockchip,pins': [[1, 14, 0, 194]], 'phandle': 139} is not of type 'array' > from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml# unrelated to the change in question, as that affects silergy regulators. But I just asked Jonathan to check on their board if we can just remove those seemingly unused pinctrl properties.