From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Prevent memory aliasing on non-LPAE kernels
Date: Fri, 31 May 2013 00:24:13 +0200 [thread overview]
Message-ID: <3054064.aJsgTxiNUL@wuerfel> (raw)
In-Reply-To: <1369950320-22784-1-git-send-email-stepanm@codeaurora.org>
On Thursday 30 May 2013 14:45:20 Stepan Moskovchenko wrote:
>
> void __init early_init_dt_add_memory_arch(u64 base, u64 size)
> {
> +#ifndef CONFIG_ARM_LPAE
> + if (base > ((phys_addr_t)~0)) {
> + pr_crit("Ignoring memory at 0x%08llx due to lack of LPAE support\n",
> + base);
> + return;
> + }
> +
> + if (size > ((phys_addr_t)~0))
> + size = ((phys_addr_t)~0);
> +
> + /* arm_add_memory() already checks for the case of base + size > 4GB */
> +#endif
> arm_add_memory(base, size);
> }
This looks wrong for the case where 'base' is between >0 and 4GB and 'size'
makes it spill over the 4GB boundary. You need to set
'size = (phys_addr_t)~0 - base' then.
Arnd
next prev parent reply other threads:[~2013-05-30 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 21:45 [PATCH] arm: Prevent memory aliasing on non-LPAE kernels Stepan Moskovchenko
2013-05-30 22:10 ` Jason Gunthorpe
2013-05-30 22:24 ` Arnd Bergmann [this message]
2013-06-01 1:30 ` Stepan Moskovchenko
2013-06-10 5:24 ` Magnus Damm
2013-08-29 7:08 ` takashi.yoshii.zj at renesas.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3054064.aJsgTxiNUL@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox