From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver
Date: Tue, 17 Jun 2014 18:50:01 +0200 [thread overview]
Message-ID: <3066194.ZkIxk6z9u6@amdc1032> (raw)
In-Reply-To: <419989CC-5106-4AF7-8911-617B51FD7395@codeaurora.org>
On Tuesday, June 17, 2014 10:42:36 AM Kumar Gala wrote:
>
> On Jun 17, 2014, at 7:25 AM, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote:
[...]
> >> +static struct platform_driver qcom_ahci_driver = {
> >> + .probe = qcom_ahci_probe,
> >> + .remove = ata_platform_remove_one,
> >> + .driver = {
> >> + .name = "qcom_ahci_qcom",
> >> + .owner = THIS_MODULE,
> >> + .of_match_table = qcom_ahci_of_match,
> >> + },
> >
> > This driver lacks PM suspend/resume support. I assume that
> > the IPQ806x platform also doesn't support suspend/resume yet
> > (if so a comment in the driver code about this would be useful),
> > otherwise the driver should be fixed.
>
> Correct, do you want the comment in the commit message or the driver itself?
I would prefer the comment in the driver itself.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2014-06-17 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 16:16 [PATCH v2 2/3] ata: Add Qualcomm ARM SoC AHCI SATA host controller driver Kumar Gala
2014-06-17 12:25 ` Bartlomiej Zolnierkiewicz
2014-06-17 15:42 ` Kumar Gala
2014-06-17 16:50 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3066194.ZkIxk6z9u6@amdc1032 \
--to=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox