From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D363C67861 for ; Mon, 8 Apr 2024 15:05:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v+VQpsBIA5EQ2285hXt9v1qs60VjWqktPlaIxo0H9P0=; b=PAswaX34+ePa3L RkCYZEQI8e6Jtoca8LykJMws0SIqSnftDPuNNC0+cA+NmsM6rBSCIVnIjPU52tZS5m7Kv4DcQ2mAv 7GL4Coh6v1bQTu0jXK3LQxvBYaCYEj1IH6gk0Eo1tV1w5u/hpwyYwBqPj+12kcsV56ND4wbmQxa6H sAvYODg/Oh/Nx9h09IQovHV+lIpVeJoCIFc9oel4M6G2OUGTg51jTUr/HkBJR6U/iDDJF4jSOP9cf LWKtdXWX10vq+m+zbIRkgEMPDPn9ItXEk3t4OV2I1GuILVuYVdkiII37Y32AzcjqB4WJaXgLlbfqx m/Lx5ueQGl2klw0ntx0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtqYe-0000000FyGG-0Ivb; Mon, 08 Apr 2024 15:05:16 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtqYZ-0000000FyES-37Ih; Mon, 08 Apr 2024 15:05:14 +0000 Received: from i5e8616c3.versanet.de ([94.134.22.195] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rtqYK-0007Xz-Fd; Mon, 08 Apr 2024 17:04:56 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Chukun Pan , Jonas Karlman Cc: Conor Dooley , Krzysztof Kozlowski , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/1] arm64: dts: rockchip: enable onboard spi flash for rock-3a Date: Mon, 08 Apr 2024 17:04:55 +0200 Message-ID: <3066222.xgJ6IN8ObU@diego> In-Reply-To: References: <20240408124005.182565-1-amadeus@jmu.edu.cn> <421ab43b-ff92-41c6-9904-3c7681c926be@kwiboo.se> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_080511_997819_9F8DC6FE X-CRM114-Status: GOOD ( 22.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 8. April 2024, 16:56:59 CEST schrieb Jonas Karlman: > On 2024-04-08 16:44, Jonas Karlman wrote: > > On 2024-04-08 14:40, Chukun Pan wrote: > >> There is a mx25u12835f spi flash on this board, enable it. > >> > >> [ 2.525805] spi-nor spi4.0: mx25u12835f (16384 Kbytes) > >> > >> Signed-off-by: Chukun Pan > >> --- > >> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > >> index a5e974ea659e..d8738cc47c73 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts > >> @@ -757,6 +757,18 @@ &sdmmc2 { > >> status = "okay"; > >> }; > >> > >> +&sfc { > > > > This is missing: > > > > #address-cells = <1>; > > #size-cells = <0>; > > > >> + status = "okay"; > >> + > >> + flash@0 { > >> + compatible = "jedec,spi-nor"; > >> + reg = <0x0>; > >> + spi-max-frequency = <50000000>; > > > > At least in U-Boot the spi clock only support 24, 100 or 200 mhz and I > > am pretty sure the spi flash support 100mhz, so I would suggest you test > > with 100mhz, same as used on other rk356x boards. > > Sorry, looked at spi clock instead of sfc clock. > sfc clock support 24, 50, 75, 100, 125 and 150 mhz. I think in some previous discussion the agreement was that the node should specify the max frequency the flash supports and have the controller worry about its own clock ranges. Though in this case the 50MHz for the flash even matches the clock frequency supported by the sfc _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel