From: mhei@heimpold.de (Michael Heimpold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: mxs: Pass the system revision
Date: Sat, 01 Jun 2013 14:19:58 +0200 [thread overview]
Message-ID: <3068502.pO6ZTjjROM@kerker> (raw)
In-Reply-To: <1370040127-15072-2-git-send-email-festevam@gmail.com>
Hi Fabio,
Am Freitag, 31. Mai 2013, 19:42:07 schrieb Fabio Estevam:
>...
> Hardware : Freescale i.MX28 Evaluation Kit
> Revision : 28012
> ...
> + system_rev = (cputype | mxs_get_cpu_rev());
> +}
I think it would be difficult to use system_rev for this purpose as some
boards I know about are using this field to pass a board/PCB revision from
U-Boot to the kernel.
After spending a short look through documentation in kernel and U-Boot
I did not find any hint whether this was the indended usage of this field.
I would rather argue about introducing a new line
"SoC revision: ..." as this is the revision you want to pass to user-space.
The lines "Revision" and "Serial" should IMHO left
alone for usage by board vendors.
BR, Michael
next prev parent reply other threads:[~2013-06-01 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 22:42 [PATCH v2 1/2] ARM: mxs: Print silicon version on boot Fabio Estevam
2013-05-31 22:42 ` [PATCH v2 2/2] ARM: mxs: Pass the system revision Fabio Estevam
2013-06-01 12:19 ` Michael Heimpold [this message]
2013-06-01 14:58 ` Fabio Estevam
2013-06-01 22:11 ` Michael Heimpold
2013-06-03 1:51 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3068502.pO6ZTjjROM@kerker \
--to=mhei@heimpold.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox