From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3769CC433E2 for ; Wed, 22 Jul 2020 14:38:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F33AA20771 for ; Wed, 22 Jul 2020 14:38:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jcrubV19" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F33AA20771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kxzRl8XUhObR2L9gKMYVjY9eJ0d6uHLhVuOtwrFZ1Ck=; b=jcrubV19mEhpREv023S9PEZKc BLz1jhtWvUgQaBGTj8GzE5Rk9V+1+t1XyXE3QBImbbnzU6MvqePDtdfx6mCgLi7UGVjUiwk1fkZWC kiunjYSWy/GQF8Syokjzx9RpLt+yDyVHGLFCtJX4fWJTvXUAw035E8lb5acaBakAJN2sVQ1bGY2Bm f7gqfDa2l6TnNGPrWkPoVivVEN7zl/2IsiAfB3H/h4HdLcGXKavzPqBik8XtfrFAb+80GVaTc5vkX kCawhl7iK2VKaaWwjskqVa8aZiNweEGPRtdzkapWO7x0Z+zTXiO7aBK/cMwU0VchhXw9rqQMBdA3C fMMN+FiHQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyFs8-0005ne-US; Wed, 22 Jul 2020 14:37:28 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyFs5-0005ml-V2; Wed, 22 Jul 2020 14:37:26 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyFs1-0003sN-NZ; Wed, 22 Jul 2020 16:37:21 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Alex Bee Subject: Re: [PATCH] clk: rockchip: add CLK_IGNORE_UNUSED to RK3188 sclk_mac_lbtest Date: Wed, 22 Jul 2020 16:37:21 +0200 Message-ID: <3075813.JVNIx54Eim@diego> In-Reply-To: <20200722143137.863-1-knaerzche@gmail.com> References: <20200722143137.863-1-knaerzche@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_103726_036904_866A3624 X-CRM114-Status: GOOD ( 17.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Michael Turquette , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Mittwoch, 22. Juli 2020, 16:31:37 CEST schrieb Alex Bee: > Since the loopbacktest clock is not exported and is not touched in the > driver, it needs the CLK_IGNORE_UNUSED flag in order to get the emac > working. could you please add it to the rk3188_critical_clocks array instead. CLK_IGNORE_UNUSED only protects it against the clock subsystem disabling it on boot, while as critical clock it also gets protected later. Thanks Heiko > > Signed-off-by: Alex Bee > --- > drivers/clk/rockchip/clk-rk3188.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/rockchip/clk-rk3188.c b/drivers/clk/rockchip/clk-rk3188.c > index 77aebfb1d6d5..892b1edc3444 100644 > --- a/drivers/clk/rockchip/clk-rk3188.c > +++ b/drivers/clk/rockchip/clk-rk3188.c > @@ -354,7 +354,7 @@ static struct rockchip_clk_branch common_clk_branches[] __initdata = { > RK2928_CLKGATE_CON(2), 5, GFLAGS), > MUX(SCLK_MAC, "sclk_macref", mux_sclk_macref_p, CLK_SET_RATE_PARENT, > RK2928_CLKSEL_CON(21), 4, 1, MFLAGS), > - GATE(0, "sclk_mac_lbtest", "sclk_macref", 0, > + GATE(0, "sclk_mac_lbtest", "sclk_macref", CLK_IGNORE_UNUSED, > RK2928_CLKGATE_CON(2), 12, GFLAGS), > > COMPOSITE(0, "hsadc_src", mux_pll_src_gpll_cpll_p, 0, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel