From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03415C43381 for ; Tue, 12 Mar 2019 12:27:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C55B820657 for ; Tue, 12 Mar 2019 12:27:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ILORIJ/j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C55B820657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qIPRcAuBmgbWD3d+GdIhnRSYinA8yoRUojV8ikC92Q8=; b=ILORIJ/jg3mh1F JOjZX1Tl3pJMcay2XSA3sdxeJvaUwwtos2mJ9Uwe0ZQqCCdoAE5H0jtEnHbhrdKmeL/KHCuyjeGIj 22ddvQGIMD6tEriUBwm4GzCo+kRwq3XWvj+FHtFO1VGmrp+m/A7POg1UzOLKSpZNKfvELRiFDAlRj a/cUPnylHPJO+ZVNpo+2aZQ2GxAeFnIHftKMn4w9HxsJ+gx9O00m3zf/rhsgf9fZsA10v0aPDvbkQ F8dMQbf3pt078+NisQAjxj20jgvwzdyyBwS6gJr1vIEjkomgQ/G6O82qJN4JNFTaib6jM5WbeQHtb geRiUpmzwgR8OBVozdIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3gVV-00051W-6X; Tue, 12 Mar 2019 12:27:45 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3gVR-00050j-Av; Tue, 12 Mar 2019 12:27:43 +0000 Received: from we0652.dip.tu-dresden.de ([141.76.178.140] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h3gVE-0001a0-Fk; Tue, 12 Mar 2019 13:27:28 +0100 From: Heiko Stuebner To: Andrew Lunn , david.wu@rock-chips.com, zonque@gmail.com Subject: Re: [PATCH net-next] net: phy: improve handling link_change_notify callback Date: Tue, 12 Mar 2019 13:27:27 +0100 Message-ID: <3079158.ITs3Wk0qno@phil> In-Reply-To: <20190304200630.GJ26378@lunn.ch> References: <411b1c33-a245-0706-8afd-c4bea1b90f68@gmail.com> <20190304.113025.1437399524067140375.davem@davemloft.net> <20190304200630.GJ26378@lunn.ch> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_052741_518830_5E9730DD X-CRM114-Status: GOOD ( 19.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, David Miller , linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, Heiner, Am Montag, 4. M=E4rz 2019, 21:06:30 CET schrieb Andrew Lunn: > On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote: > > From: Heiner Kallweit > > Date: Sun, 3 Mar 2019 19:58:57 +0100 > > = > > > Currently the Phy driver's link_change_notify callback is called > > > whenever the state machine is run (every second if polling), no matter > > > whether the state changed or not. This isn't needed and may confuse > > > users considering the name of the callback. Therefore let's change > > > the behavior and call this callback only in case of an actual > > > state change. > > > = > > > This requires changes to the at803x and rockchip drivers. > > > at803x can be simplified so that it reacts on a state change to > > > PHY_NOLINK only. > > > The rockchip driver can also be much simplified. We simply re-init > > > the AFE/DSP registers whenever we change to PHY_RUNNING and speed > > > is 100Mbps. This causes very small overhead because we do this even > > > if the speed was 100Mbps already. But this is neglectable and > > > I think justified by the much simpler code. > > > = > > > Changes are compile-tested only. > > > = > > > Signed-off-by: Heiner Kallweit > > = > > Someone please review this. > = > Hi David > = > We should probably wait for a Tested-by: from Daniel Mack > and David Wu , or > equivalent. We should probably add them to the list of recipients if we want tests from them, which I've done now. @David: patch in question that changes the Rockchip eth-phy is https://patchwork.kernel.org/patch/10837217/ Sadly I don't have matching hardware to test this myself. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel