Re: [PATCH v4 00/15] Move HEVC stateless controls out of staging

Benjamin Gaignard
2022-03-31T06:55:00Z

Le 30/03/2022 à 20:52, Adam Ford a écrit :
> On Wed, Mar 30, 2022 at 2:53 AM Benjamin Gaignard
> <benjamin.gaignard@collabora.com> wrote:
>>
>> Le 28/02/2022 à 15:08, Benjamin Gaignard a écrit :
>>> This series aims to make HEVC uapi stable and usable for hardware
>>> decoder. HEVC uapi is used by 2 mainlined drivers (Cedrus and Hantro)
>>> and 2 out of the tree drivers (rkvdec and RPI).
>>>
>>> After the remarks done on version 2, I have completely reworked to patches
>>> split so changelogs are meaningless. I have also drop "RFC" from the
>>> titles.
>>>
>>> Version 4:
>>> - Add num_entry_point_offsets field in struct v4l2_ctrl_hevc_slice_params
>>> - Fix V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS name
>>> - Initialize control V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS
>>> - Fix space/tab issue in kernel-doc
>>> - Add patch to change data_bit_offset definition
>>> - Fix hantro-media SPDX license
>>> - put controls under stateless section in v4l2-ctrls-defs.c
>>>
>>> At the end fluster tests results on IMX8MQ is 77/147 for HEVC codec.
>> Dear reviewers,
>>
>> This series is waiting for your feedback,
> I tried several times with the suggested repos for both the kernel and
> g-streamer without success getting Fluster to pass any tests on the
> imx8mq. I can try again but I likely won't get to it until this
> weekend. If I can get it working, I'll test both the 8mq and 8mm.

Thanks a lot for that.

Benjamin

>
> adam
>> Thanks,
>> Benjamin
>>
>>> Benjamin
>>>
>>>
>>> Benjamin Gaignard (12):
>>> media: uapi: HEVC: Add missing fields in HEVC controls
>>> media: uapi: HEVC: Rename HEVC stateless controls with STATELESS
>>> prefix
>>> media: uapi: HEVC: Add document uAPI structure
>>> media: uapi: HEVC: Define V4L2_CID_STATELESS_HEVC_SLICE_PARAMS as a
>>> dynamic array
>>> media: uapi: Move parsed HEVC pixel format out of staging
>>> media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS control
>>> media: uapi: Move the HEVC stateless control type out of staging
>>> media: controls: Log HEVC stateless control in .std_log
>>> media: uapi: Create a dedicated header for Hantro control
>>> media: uapi: HEVC: fix padding in v4l2 control structures
>>> media: uapi: Change data_bit_offset definition
>>> media: uapi: move HEVC stateless controls out of staging
>>>
>>> Hans Verkuil (3):
>>> videodev2.h: add V4L2_CTRL_FLAG_DYNAMIC_ARRAY
>>> v4l2-ctrls: add support for dynamically allocated arrays.
>>> vivid: add dynamic array test control
>>>
>>> .../userspace-api/media/drivers/hantro.rst | 5 -
>>> .../media/v4l/ext-ctrls-codec-stateless.rst | 833 ++++++++++++++++++
>>> .../media/v4l/ext-ctrls-codec.rst | 780 ----------------
>>> .../media/v4l/pixfmt-compressed.rst | 7 +-
>>> .../media/v4l/vidioc-g-ext-ctrls.rst | 20 +
>>> .../media/v4l/vidioc-queryctrl.rst | 8 +
>>> .../media/videodev2.h.rst.exceptions | 5 +
>>> .../media/test-drivers/vivid/vivid-ctrls.c | 15 +
>>> drivers/media/v4l2-core/v4l2-ctrls-api.c | 103 ++-
>>> drivers/media/v4l2-core/v4l2-ctrls-core.c | 198 ++++-
>>> drivers/media/v4l2-core/v4l2-ctrls-defs.c | 37 +-
>>> drivers/media/v4l2-core/v4l2-ctrls-priv.h | 3 +-
>>> drivers/media/v4l2-core/v4l2-ctrls-request.c | 13 +-
>>> drivers/staging/media/hantro/hantro_drv.c | 27 +-
>>> drivers/staging/media/hantro/hantro_hevc.c | 8 +-
>>> drivers/staging/media/sunxi/cedrus/cedrus.c | 24 +-
>>> .../staging/media/sunxi/cedrus/cedrus_dec.c | 10 +-
>>> .../staging/media/sunxi/cedrus/cedrus_h265.c | 2 +-
>>> include/media/hevc-ctrls.h | 250 ------
>>> include/media/v4l2-ctrls.h | 48 +-
>>> include/uapi/linux/hantro-media.h | 19 +
>>> include/uapi/linux/v4l2-controls.h | 439 +++++++++
>>> include/uapi/linux/videodev2.h | 13 +
>>> 23 files changed, 1697 insertions(+), 1170 deletions(-)
>>> delete mode 100644 include/media/hevc-ctrls.h
>>> create mode 100644 include/uapi/linux/hantro-media.h
>>>