* [PATCH 0/2] Add R8A7794 GPIO DT support
@ 2015-02-21 22:10 Sergei Shtylyov
2015-02-21 22:11 ` [PATCH 1/2] ARM: shmobile: r8a7794: add GPIO clocks Sergei Shtylyov
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Sergei Shtylyov @ 2015-02-21 22:10 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20150220-v3.19' tag. Here we add the GPIO device tree support
for the R8A7794 SoC. It depends on the R8A7794 PFC/MMCIF device tree patches
posted recently in order to apply.
[1/2] ARM: shmobile: r8a7794: add GPIO clocks
[2/2] ARM: shmobile: r8a7794: add GPIO DT support
WBR, Sergei
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 1/2] ARM: shmobile: r8a7794: add GPIO clocks 2015-02-21 22:10 [PATCH 0/2] Add R8A7794 GPIO DT support Sergei Shtylyov @ 2015-02-21 22:11 ` Sergei Shtylyov 2015-02-23 11:08 ` Geert Uytterhoeven 2015-02-25 9:57 ` Laurent Pinchart 2015-02-21 22:12 ` [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support Sergei Shtylyov 2015-02-23 22:00 ` [PATCH 0/2] Add R8A7794 " Simon Horman 2 siblings, 2 replies; 15+ messages in thread From: Sergei Shtylyov @ 2015-02-21 22:11 UTC (permalink / raw) To: linux-arm-kernel Describe the GPIO clocks in the R8A7794 device tree. Based on the original patch by Koji Matsuoka <koji.matsuoka.xm@renesas.com>. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- arch/arm/boot/dts/r8a7794.dtsi | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) Index: renesas/arch/arm/boot/dts/r8a7794.dtsi =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi +++ renesas/arch/arm/boot/dts/r8a7794.dtsi @@ -651,16 +651,22 @@ mstp9_clks: mstp9_clks at e6150994 { compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; reg = <0 0xe6150994 0 4>, <0 0xe61509a4 0 4>; - clocks = <&cpg_clocks R8A7794_CLK_QSPI>, <&hp_clk>, <&hp_clk>, - <&hp_clk>, <&hp_clk>, <&hp_clk>, <&hp_clk>; + clocks = <&cp_clk>, <&cp_clk>, <&cp_clk>, <&cp_clk>, + <&cp_clk>, <&cp_clk>, <&cp_clk>, + <&cpg_clocks R8A7794_CLK_QSPI>, <&hp_clk>, <&hp_clk>, + <&hp_clk>, <&hp_clk>, <&hp_clk>, <&hp_clk>; #clock-cells = <1>; - clock-indices = < - R8A7794_CLK_QSPI_MOD R8A7794_CLK_I2C5 R8A7794_CLK_I2C4 - R8A7794_CLK_I2C3 R8A7794_CLK_I2C2 R8A7794_CLK_I2C1 - R8A7794_CLK_I2C0 - >; + clock-indices = <R8A7794_CLK_GPIO6 R8A7794_CLK_GPIO5 + R8A7794_CLK_GPIO4 R8A7794_CLK_GPIO3 + R8A7794_CLK_GPIO2 R8A7794_CLK_GPIO1 + R8A7794_CLK_GPIO0 R8A7794_CLK_QSPI_MOD + R8A7794_CLK_I2C5 R8A7794_CLK_I2C4 + R8A7794_CLK_I2C3 R8A7794_CLK_I2C2 + R8A7794_CLK_I2C1 R8A7794_CLK_I2C0>; clock-output-names = - "qspi_mod", "i2c5", "i2c4", "i2c3", "i2c2", "i2c1", "i2c0"; + "gpio6", "gpio5", "gpio4", "gpio3", "gpio2", + "gpio1", "gpio0", "qspi_mod", + "i2c5", "i2c4", "i2c3", "i2c2", "i2c1", "i2c0"; }; mstp11_clks: mstp11_clks at e615099c { compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/2] ARM: shmobile: r8a7794: add GPIO clocks 2015-02-21 22:11 ` [PATCH 1/2] ARM: shmobile: r8a7794: add GPIO clocks Sergei Shtylyov @ 2015-02-23 11:08 ` Geert Uytterhoeven 2015-02-25 9:57 ` Laurent Pinchart 1 sibling, 0 replies; 15+ messages in thread From: Geert Uytterhoeven @ 2015-02-23 11:08 UTC (permalink / raw) To: linux-arm-kernel On Sat, Feb 21, 2015 at 11:11 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Describe the GPIO clocks in the R8A7794 device tree. > > Based on the original patch by Koji Matsuoka <koji.matsuoka.xm@renesas.com>. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/2] ARM: shmobile: r8a7794: add GPIO clocks 2015-02-21 22:11 ` [PATCH 1/2] ARM: shmobile: r8a7794: add GPIO clocks Sergei Shtylyov 2015-02-23 11:08 ` Geert Uytterhoeven @ 2015-02-25 9:57 ` Laurent Pinchart 1 sibling, 0 replies; 15+ messages in thread From: Laurent Pinchart @ 2015-02-25 9:57 UTC (permalink / raw) To: linux-arm-kernel Hi Sergei, Thank you for the patch. On Sunday 22 February 2015 01:11:25 Sergei Shtylyov wrote: > Describe the GPIO clocks in the R8A7794 device tree. > > Based on the original patch by Koji Matsuoka <koji.matsuoka.xm@renesas.com>. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > arch/arm/boot/dts/r8a7794.dtsi | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > Index: renesas/arch/arm/boot/dts/r8a7794.dtsi > =================================================================== > --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi > +++ renesas/arch/arm/boot/dts/r8a7794.dtsi > @@ -651,16 +651,22 @@ > mstp9_clks: mstp9_clks at e6150994 { > compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp- clocks"; > reg = <0 0xe6150994 0 4>, <0 0xe61509a4 0 4>; > - clocks = <&cpg_clocks R8A7794_CLK_QSPI>, <&hp_clk>, <&hp_clk>, > - <&hp_clk>, <&hp_clk>, <&hp_clk>, <&hp_clk>; > + clocks = <&cp_clk>, <&cp_clk>, <&cp_clk>, <&cp_clk>, > + <&cp_clk>, <&cp_clk>, <&cp_clk>, > + <&cpg_clocks R8A7794_CLK_QSPI>, <&hp_clk>, <&hp_clk>, > + <&hp_clk>, <&hp_clk>, <&hp_clk>, <&hp_clk>; > #clock-cells = <1>; > - clock-indices = < > - R8A7794_CLK_QSPI_MOD R8A7794_CLK_I2C5 R8A7794_CLK_I2C4 > - R8A7794_CLK_I2C3 R8A7794_CLK_I2C2 R8A7794_CLK_I2C1 > - R8A7794_CLK_I2C0 > - >; > + clock-indices = <R8A7794_CLK_GPIO6 R8A7794_CLK_GPIO5 > + R8A7794_CLK_GPIO4 R8A7794_CLK_GPIO3 > + R8A7794_CLK_GPIO2 R8A7794_CLK_GPIO1 > + R8A7794_CLK_GPIO0 R8A7794_CLK_QSPI_MOD > + R8A7794_CLK_I2C5 R8A7794_CLK_I2C4 > + R8A7794_CLK_I2C3 R8A7794_CLK_I2C2 > + R8A7794_CLK_I2C1 R8A7794_CLK_I2C0>; > clock-output-names = > - "qspi_mod", "i2c5", "i2c4", "i2c3", "i2c2", "i2c1", "i2c0"; > + "gpio6", "gpio5", "gpio4", "gpio3", "gpio2", > + "gpio1", "gpio0", "qspi_mod", > + "i2c5", "i2c4", "i2c3", "i2c2", "i2c1", "i2c0"; > }; > mstp11_clks: mstp11_clks at e615099c { > compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp- clocks"; -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support 2015-02-21 22:10 [PATCH 0/2] Add R8A7794 GPIO DT support Sergei Shtylyov 2015-02-21 22:11 ` [PATCH 1/2] ARM: shmobile: r8a7794: add GPIO clocks Sergei Shtylyov @ 2015-02-21 22:12 ` Sergei Shtylyov 2015-02-23 11:11 ` Geert Uytterhoeven 2015-02-25 10:11 ` Laurent Pinchart 2015-02-23 22:00 ` [PATCH 0/2] Add R8A7794 " Simon Horman 2 siblings, 2 replies; 15+ messages in thread From: Sergei Shtylyov @ 2015-02-21 22:12 UTC (permalink / raw) To: linux-arm-kernel Describe GPIO[0-6] controllers in the R8A7794 device tree. Based on original patch by Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- arch/arm/boot/dts/r8a7794.dtsi | 84 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 84 insertions(+) Index: renesas/arch/arm/boot/dts/r8a7794.dtsi =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi +++ renesas/arch/arm/boot/dts/r8a7794.dtsi @@ -50,6 +50,90 @@ interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>; }; + gpio0: gpio at e6050000 { + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; + reg = <0 0xe6050000 0 0x50>; + interrupts = <0 4 IRQ_TYPE_LEVEL_HIGH>; + #gpio-cells = <2>; + gpio-controller; + gpio-ranges = <&pfc 0 0 32>; + #interrupt-cells = <2>; + interrupt-controller; + clocks = <&mstp9_clks R8A7794_CLK_GPIO0>; + }; + + gpio1: gpio at e6051000 { + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; + reg = <0 0xe6051000 0 0x50>; + interrupts = <0 5 IRQ_TYPE_LEVEL_HIGH>; + #gpio-cells = <2>; + gpio-controller; + gpio-ranges = <&pfc 0 32 32>; + #interrupt-cells = <2>; + interrupt-controller; + clocks = <&mstp9_clks R8A7794_CLK_GPIO1>; + }; + + gpio2: gpio at e6052000 { + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; + reg = <0 0xe6052000 0 0x50>; + interrupts = <0 6 IRQ_TYPE_LEVEL_HIGH>; + #gpio-cells = <2>; + gpio-controller; + gpio-ranges = <&pfc 0 64 32>; + #interrupt-cells = <2>; + interrupt-controller; + clocks = <&mstp9_clks R8A7794_CLK_GPIO2>; + }; + + gpio3: gpio at e6053000 { + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; + reg = <0 0xe6053000 0 0x50>; + interrupts = <0 7 IRQ_TYPE_LEVEL_HIGH>; + #gpio-cells = <2>; + gpio-controller; + gpio-ranges = <&pfc 0 96 32>; + #interrupt-cells = <2>; + interrupt-controller; + clocks = <&mstp9_clks R8A7794_CLK_GPIO3>; + }; + + gpio4: gpio at e6054000 { + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; + reg = <0 0xe6054000 0 0x50>; + interrupts = <0 8 IRQ_TYPE_LEVEL_HIGH>; + #gpio-cells = <2>; + gpio-controller; + gpio-ranges = <&pfc 0 128 32>; + #interrupt-cells = <2>; + interrupt-controller; + clocks = <&mstp9_clks R8A7794_CLK_GPIO4>; + }; + + gpio5: gpio at e6055000 { + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; + reg = <0 0xe6055000 0 0x50>; + interrupts = <0 9 IRQ_TYPE_LEVEL_HIGH>; + #gpio-cells = <2>; + gpio-controller; + gpio-ranges = <&pfc 0 160 32>; + #interrupt-cells = <2>; + interrupt-controller; + clocks = <&mstp9_clks R8A7794_CLK_GPIO5>; + }; + + gpio6: gpio at e6055400 { + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; + reg = <0 0xe6055400 0 0x50>; + interrupts = <0 10 IRQ_TYPE_LEVEL_HIGH>; + #gpio-cells = <2>; + gpio-controller; + gpio-ranges = <&pfc 0 192 32>; + #interrupt-cells = <2>; + interrupt-controller; + clocks = <&mstp9_clks R8A7794_CLK_GPIO6>; + }; + cmt0: timer at ffca0000 { compatible = "renesas,cmt-48-gen2"; reg = <0 0xffca0000 0 0x1004>; ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support 2015-02-21 22:12 ` [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support Sergei Shtylyov @ 2015-02-23 11:11 ` Geert Uytterhoeven 2015-02-25 10:11 ` Laurent Pinchart 1 sibling, 0 replies; 15+ messages in thread From: Geert Uytterhoeven @ 2015-02-23 11:11 UTC (permalink / raw) To: linux-arm-kernel On Sat, Feb 21, 2015 at 11:12 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Describe GPIO[0-6] controllers in the R8A7794 device tree. > > Based on original patch by Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Acked-?by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support 2015-02-21 22:12 ` [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support Sergei Shtylyov 2015-02-23 11:11 ` Geert Uytterhoeven @ 2015-02-25 10:11 ` Laurent Pinchart 2015-02-25 10:27 ` Geert Uytterhoeven 2015-02-25 14:04 ` Sergei Shtylyov 1 sibling, 2 replies; 15+ messages in thread From: Laurent Pinchart @ 2015-02-25 10:11 UTC (permalink / raw) To: linux-arm-kernel Hi Sergei, Thank you for the patch. On Sunday 22 February 2015 01:12:31 Sergei Shtylyov wrote: > Describe GPIO[0-6] controllers in the R8A7794 device tree. > > Based on original patch by Hisashi Nakamura > <hisashi.nakamura.ak@renesas.com>. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > arch/arm/boot/dts/r8a7794.dtsi | 84 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 84 insertions(+) > > Index: renesas/arch/arm/boot/dts/r8a7794.dtsi > =================================================================== > --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi > +++ renesas/arch/arm/boot/dts/r8a7794.dtsi > @@ -50,6 +50,90 @@ > interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>; > }; > > + gpio0: gpio at e6050000 { > + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > + reg = <0 0xe6050000 0 0x50>; > + interrupts = <0 4 IRQ_TYPE_LEVEL_HIGH>; > + #gpio-cells = <2>; > + gpio-controller; > + gpio-ranges = <&pfc 0 0 32>; > + #interrupt-cells = <2>; > + interrupt-controller; > + clocks = <&mstp9_clks R8A7794_CLK_GPIO0>; > + }; > + > + gpio1: gpio at e6051000 { > + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > + reg = <0 0xe6051000 0 0x50>; > + interrupts = <0 5 IRQ_TYPE_LEVEL_HIGH>; > + #gpio-cells = <2>; > + gpio-controller; > + gpio-ranges = <&pfc 0 32 32>; This GPIO block has 26 GPIOs only. > + #interrupt-cells = <2>; > + interrupt-controller; > + clocks = <&mstp9_clks R8A7794_CLK_GPIO1>; > + }; > + > + gpio2: gpio at e6052000 { > + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > + reg = <0 0xe6052000 0 0x50>; > + interrupts = <0 6 IRQ_TYPE_LEVEL_HIGH>; > + #gpio-cells = <2>; > + gpio-controller; > + gpio-ranges = <&pfc 0 64 32>; > + #interrupt-cells = <2>; > + interrupt-controller; > + clocks = <&mstp9_clks R8A7794_CLK_GPIO2>; > + }; > + > + gpio3: gpio at e6053000 { > + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > + reg = <0 0xe6053000 0 0x50>; > + interrupts = <0 7 IRQ_TYPE_LEVEL_HIGH>; > + #gpio-cells = <2>; > + gpio-controller; > + gpio-ranges = <&pfc 0 96 32>; > + #interrupt-cells = <2>; > + interrupt-controller; > + clocks = <&mstp9_clks R8A7794_CLK_GPIO3>; > + }; > + > + gpio4: gpio at e6054000 { > + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > + reg = <0 0xe6054000 0 0x50>; > + interrupts = <0 8 IRQ_TYPE_LEVEL_HIGH>; > + #gpio-cells = <2>; > + gpio-controller; > + gpio-ranges = <&pfc 0 128 32>; > + #interrupt-cells = <2>; > + interrupt-controller; > + clocks = <&mstp9_clks R8A7794_CLK_GPIO4>; > + }; > + > + gpio5: gpio at e6055000 { > + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > + reg = <0 0xe6055000 0 0x50>; > + interrupts = <0 9 IRQ_TYPE_LEVEL_HIGH>; > + #gpio-cells = <2>; > + gpio-controller; > + gpio-ranges = <&pfc 0 160 32>; This GPIO block has 28 GPIOs only. > + #interrupt-cells = <2>; > + interrupt-controller; > + clocks = <&mstp9_clks R8A7794_CLK_GPIO5>; > + }; > + > + gpio6: gpio at e6055400 { > + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > + reg = <0 0xe6055400 0 0x50>; > + interrupts = <0 10 IRQ_TYPE_LEVEL_HIGH>; > + #gpio-cells = <2>; > + gpio-controller; > + gpio-ranges = <&pfc 0 192 32>; This GPIO block has 26 GPIOs only. > + #interrupt-cells = <2>; > + interrupt-controller; > + clocks = <&mstp9_clks R8A7794_CLK_GPIO6>; > + }; > + > cmt0: timer at ffca0000 { > compatible = "renesas,cmt-48-gen2"; > reg = <0 0xffca0000 0 0x1004>; -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support 2015-02-25 10:11 ` Laurent Pinchart @ 2015-02-25 10:27 ` Geert Uytterhoeven 2015-02-25 22:10 ` Laurent Pinchart 2015-02-25 14:04 ` Sergei Shtylyov 1 sibling, 1 reply; 15+ messages in thread From: Geert Uytterhoeven @ 2015-02-25 10:27 UTC (permalink / raw) To: linux-arm-kernel Hi Laurent, On Wed, Feb 25, 2015 at 11:11 AM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: >> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi >> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi >> @@ -50,6 +50,90 @@ >> + gpio1: gpio at e6051000 { >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; >> + reg = <0 0xe6051000 0 0x50>; >> + interrupts = <0 5 IRQ_TYPE_LEVEL_HIGH>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + gpio-ranges = <&pfc 0 32 32>; > > This GPIO block has 26 GPIOs only. >> + gpio5: gpio at e6055000 { >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; >> + reg = <0 0xe6055000 0 0x50>; >> + interrupts = <0 9 IRQ_TYPE_LEVEL_HIGH>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + gpio-ranges = <&pfc 0 160 32>; > > This GPIO block has 28 GPIOs only. >> + gpio6: gpio at e6055400 { >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; >> + reg = <0 0xe6055400 0 0x50>; >> + interrupts = <0 10 IRQ_TYPE_LEVEL_HIGH>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + gpio-ranges = <&pfc 0 192 32>; > > This GPIO block has 26 GPIOs only. I guess you hear me coming... r8a779[01].dtsi need to be fixed, too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support 2015-02-25 10:27 ` Geert Uytterhoeven @ 2015-02-25 22:10 ` Laurent Pinchart 0 siblings, 0 replies; 15+ messages in thread From: Laurent Pinchart @ 2015-02-25 22:10 UTC (permalink / raw) To: linux-arm-kernel Hi Geert, On Wednesday 25 February 2015 11:27:37 Geert Uytterhoeven wrote: > On Wed, Feb 25, 2015 at 11:11 AM, Laurent Pinchart wrote: > >> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi > >> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi > >> @@ -50,6 +50,90 @@ > >> > >> + gpio1: gpio at e6051000 { > >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > >> + reg = <0 0xe6051000 0 0x50>; > >> + interrupts = <0 5 IRQ_TYPE_LEVEL_HIGH>; > >> + #gpio-cells = <2>; > >> + gpio-controller; > >> + gpio-ranges = <&pfc 0 32 32>; > > > > This GPIO block has 26 GPIOs only. > > > >> + gpio5: gpio at e6055000 { > >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > >> + reg = <0 0xe6055000 0 0x50>; > >> + interrupts = <0 9 IRQ_TYPE_LEVEL_HIGH>; > >> + #gpio-cells = <2>; > >> + gpio-controller; > >> + gpio-ranges = <&pfc 0 160 32>; > > > > This GPIO block has 28 GPIOs only. > > > >> + gpio6: gpio at e6055400 { > >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > >> + reg = <0 0xe6055400 0 0x50>; > >> + interrupts = <0 10 IRQ_TYPE_LEVEL_HIGH>; > >> + #gpio-cells = <2>; > >> + gpio-controller; > >> + gpio-ranges = <&pfc 0 192 32>; > > > > This GPIO block has 26 GPIOs only. > > I guess you hear me coming... r8a779[01].dtsi need to be fixed, too. Yes. We're first investigating issues in the pfc driver and/or pinctrl core due to holes in GPIO banks pins though. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support 2015-02-25 10:11 ` Laurent Pinchart 2015-02-25 10:27 ` Geert Uytterhoeven @ 2015-02-25 14:04 ` Sergei Shtylyov 2015-02-25 14:08 ` Laurent Pinchart 1 sibling, 1 reply; 15+ messages in thread From: Sergei Shtylyov @ 2015-02-25 14:04 UTC (permalink / raw) To: linux-arm-kernel Hello. On 2/25/2015 1:11 PM, Laurent Pinchart wrote: >> Describe GPIO[0-6] controllers in the R8A7794 device tree. >> Based on original patch by Hisashi Nakamura >> <hisashi.nakamura.ak@renesas.com>. >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> --- >> arch/arm/boot/dts/r8a7794.dtsi | 84 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 84 insertions(+) >> >> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi >> =================================================================== >> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi >> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi >> @@ -50,6 +50,90 @@ [...] >> + gpio1: gpio at e6051000 { >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; >> + reg = <0 0xe6051000 0 0x50>; >> + interrupts = <0 5 IRQ_TYPE_LEVEL_HIGH>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + gpio-ranges = <&pfc 0 32 32>; > This GPIO block has 26 GPIOs only. [...] >> + gpio5: gpio at e6055000 { >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; >> + reg = <0 0xe6055000 0 0x50>; >> + interrupts = <0 9 IRQ_TYPE_LEVEL_HIGH>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + gpio-ranges = <&pfc 0 160 32>; > This GPIO block has 28 GPIOs only. >> + #interrupt-cells = <2>; >> + interrupt-controller; >> + clocks = <&mstp9_clks R8A7794_CLK_GPIO5>; >> + }; >> + >> + gpio6: gpio at e6055400 { >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; >> + reg = <0 0xe6055400 0 0x50>; >> + interrupts = <0 10 IRQ_TYPE_LEVEL_HIGH>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + gpio-ranges = <&pfc 0 192 32>; > This GPIO block has 26 GPIOs only. Yes, I know; I just wasn't sure what to do with the "gpio-ranges" prop of the following GPIO node. Should I keep the base GPIO # or update it as well? WBR, Sergei ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support 2015-02-25 14:04 ` Sergei Shtylyov @ 2015-02-25 14:08 ` Laurent Pinchart 0 siblings, 0 replies; 15+ messages in thread From: Laurent Pinchart @ 2015-02-25 14:08 UTC (permalink / raw) To: linux-arm-kernel Hi Sergei, On Wednesday 25 February 2015 17:04:53 Sergei Shtylyov wrote: > On 2/25/2015 1:11 PM, Laurent Pinchart wrote: > >> Describe GPIO[0-6] controllers in the R8A7794 device tree. > >> > >> Based on original patch by Hisashi Nakamura > >> <hisashi.nakamura.ak@renesas.com>. > >> > >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> > >> --- > >> > >> arch/arm/boot/dts/r8a7794.dtsi | 84 +++++++++++++++++++++++++++++++++ > >> 1 file changed, 84 insertions(+) > >> > >> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi > >> =================================================================== > >> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi > >> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi > >> @@ -50,6 +50,90 @@ > > [...] > > >> + gpio1: gpio at e6051000 { > >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > >> + reg = <0 0xe6051000 0 0x50>; > >> + interrupts = <0 5 IRQ_TYPE_LEVEL_HIGH>; > >> + #gpio-cells = <2>; > >> + gpio-controller; > >> + gpio-ranges = <&pfc 0 32 32>; > > > > This GPIO block has 26 GPIOs only. > > [...] > > >> + gpio5: gpio at e6055000 { > >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > >> + reg = <0 0xe6055000 0 0x50>; > >> + interrupts = <0 9 IRQ_TYPE_LEVEL_HIGH>; > >> + #gpio-cells = <2>; > >> + gpio-controller; > >> + gpio-ranges = <&pfc 0 160 32>; > > > > This GPIO block has 28 GPIOs only. > > > >> + #interrupt-cells = <2>; > >> + interrupt-controller; > >> + clocks = <&mstp9_clks R8A7794_CLK_GPIO5>; > >> + }; > >> + > >> + gpio6: gpio at e6055400 { > >> + compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar"; > >> + reg = <0 0xe6055400 0 0x50>; > >> + interrupts = <0 10 IRQ_TYPE_LEVEL_HIGH>; > >> + #gpio-cells = <2>; > >> + gpio-controller; > >> + gpio-ranges = <&pfc 0 192 32>; > > > > This GPIO block has 26 GPIOs only. > > Yes, I know; I just wasn't sure what to do with the "gpio-ranges" prop of > the following GPIO node. Should I keep the base GPIO # or update it as well? I think the base number should be kept as-is, as the pfc driver indexes GPIOs using 32 * bank + offset. There are thus holes in the pfc pins array, but that shouldn't be a big deal (of course if you can find an easy way to optimize that, it would be welcome :-)). -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/2] Add R8A7794 GPIO DT support 2015-02-21 22:10 [PATCH 0/2] Add R8A7794 GPIO DT support Sergei Shtylyov 2015-02-21 22:11 ` [PATCH 1/2] ARM: shmobile: r8a7794: add GPIO clocks Sergei Shtylyov 2015-02-21 22:12 ` [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support Sergei Shtylyov @ 2015-02-23 22:00 ` Simon Horman 2015-02-23 23:19 ` Simon Horman 2 siblings, 1 reply; 15+ messages in thread From: Simon Horman @ 2015-02-23 22:00 UTC (permalink / raw) To: linux-arm-kernel On Sun, Feb 22, 2015 at 01:10:19AM +0300, Sergei Shtylyov wrote: > Hello. > > Here's the set of 2 patches against Simon Horman's 'renesas.git' repo, > 'renesas-devel-20150220-v3.19' tag. Here we add the GPIO device tree support > for the R8A7794 SoC. It depends on the R8A7794 PFC/MMCIF device tree patches > posted recently in order to apply. > > [1/2] ARM: shmobile: r8a7794: add GPIO clocks > [2/2] ARM: shmobile: r8a7794: add GPIO DT support Thanks, I have queued these up with Geert's Acks. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/2] Add R8A7794 GPIO DT support 2015-02-23 22:00 ` [PATCH 0/2] Add R8A7794 " Simon Horman @ 2015-02-23 23:19 ` Simon Horman 2015-02-24 14:43 ` Sergei Shtylyov 0 siblings, 1 reply; 15+ messages in thread From: Simon Horman @ 2015-02-23 23:19 UTC (permalink / raw) To: linux-arm-kernel On Tue, Feb 24, 2015 at 07:00:33AM +0900, Simon Horman wrote: > On Sun, Feb 22, 2015 at 01:10:19AM +0300, Sergei Shtylyov wrote: > > Hello. > > > > Here's the set of 2 patches against Simon Horman's 'renesas.git' repo, > > 'renesas-devel-20150220-v3.19' tag. Here we add the GPIO device tree support > > for the R8A7794 SoC. It depends on the R8A7794 PFC/MMCIF device tree patches > > posted recently in order to apply. > > > > [1/2] ARM: shmobile: r8a7794: add GPIO clocks > > [2/2] ARM: shmobile: r8a7794: add GPIO DT support > > Thanks, I have queued these up with Geert's Acks. Sorry, I was too hasty again. I have dropped these pending the dependencies being queued up. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/2] Add R8A7794 GPIO DT support 2015-02-23 23:19 ` Simon Horman @ 2015-02-24 14:43 ` Sergei Shtylyov 2015-02-25 8:07 ` Simon Horman 0 siblings, 1 reply; 15+ messages in thread From: Sergei Shtylyov @ 2015-02-24 14:43 UTC (permalink / raw) To: linux-arm-kernel Hello. On 02/24/2015 02:19 AM, Simon Horman wrote: >>> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo, >>> 'renesas-devel-20150220-v3.19' tag. Here we add the GPIO device tree support >>> for the R8A7794 SoC. It depends on the R8A7794 PFC/MMCIF device tree patches >>> posted recently in order to apply. >>> [1/2] ARM: shmobile: r8a7794: add GPIO clocks >>> [2/2] ARM: shmobile: r8a7794: add GPIO DT support >> Thanks, I have queued these up with Geert's Acks. > Sorry, I was too hasty again. I have dropped these pending the > dependencies being queued up. Ah, I just didn't mention that the PFC patch is necessary for the latter patch to compile (but I don't expect it to change, so IMHO you can apply the PFC patch now). The former patch still can be merged, I think. WBR, Sergei ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/2] Add R8A7794 GPIO DT support 2015-02-24 14:43 ` Sergei Shtylyov @ 2015-02-25 8:07 ` Simon Horman 0 siblings, 0 replies; 15+ messages in thread From: Simon Horman @ 2015-02-25 8:07 UTC (permalink / raw) To: linux-arm-kernel On Tue, Feb 24, 2015 at 05:43:19PM +0300, Sergei Shtylyov wrote: > Hello. > > On 02/24/2015 02:19 AM, Simon Horman wrote: > > >>> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo, > >>>'renesas-devel-20150220-v3.19' tag. Here we add the GPIO device tree support > >>>for the R8A7794 SoC. It depends on the R8A7794 PFC/MMCIF device tree patches > >>>posted recently in order to apply. > > >>>[1/2] ARM: shmobile: r8a7794: add GPIO clocks > >>>[2/2] ARM: shmobile: r8a7794: add GPIO DT support > > >>Thanks, I have queued these up with Geert's Acks. > > >Sorry, I was too hasty again. I have dropped these pending the > >dependencies being queued up. > > Ah, I just didn't mention that the PFC patch is necessary for the latter > patch to compile (but I don't expect it to change, so IMHO you can apply the > PFC patch now). The former patch still can be merged, I think. Thanks, I am coming around to your view that it is unlikely that the PFC bindings will to change at this point. It would help me greatly if you could put together all the silk/R8A7794 .dts and .dtsi patches that you think are ready to be merged into a single series for me to look over (again). Thanks in advance. ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2015-02-25 22:10 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-02-21 22:10 [PATCH 0/2] Add R8A7794 GPIO DT support Sergei Shtylyov 2015-02-21 22:11 ` [PATCH 1/2] ARM: shmobile: r8a7794: add GPIO clocks Sergei Shtylyov 2015-02-23 11:08 ` Geert Uytterhoeven 2015-02-25 9:57 ` Laurent Pinchart 2015-02-21 22:12 ` [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support Sergei Shtylyov 2015-02-23 11:11 ` Geert Uytterhoeven 2015-02-25 10:11 ` Laurent Pinchart 2015-02-25 10:27 ` Geert Uytterhoeven 2015-02-25 22:10 ` Laurent Pinchart 2015-02-25 14:04 ` Sergei Shtylyov 2015-02-25 14:08 ` Laurent Pinchart 2015-02-23 22:00 ` [PATCH 0/2] Add R8A7794 " Simon Horman 2015-02-23 23:19 ` Simon Horman 2015-02-24 14:43 ` Sergei Shtylyov 2015-02-25 8:07 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).