From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E0C3C48BF6 for ; Fri, 1 Mar 2024 03:00:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+XrI4mNHd2mfRY6gAT109nVf+oDi08E1Syh7sb4xk48=; b=RiY5PqJfjAMPWK ij6KIhRF7V0sb/ZOZ8mO6QfWzFCMGDxV0ONMUy+jGid3sTDMjjT+4m66DkDJBUVVfu1hR4h86TN1V 5C/kGwhq6xqd1mDo9VhHioFNdi4JK3+e9UoMf1INRxHqpJjnYsZyjXrnKFtuIY+vLfCyygGPg4uIA OdUgV7joudo373ISNLAn2p1PPEEanFCBx4O13Zt72pXub0ymZmBJ1ruk8XGt0B5slUH7NM1tJQGED +jcpjhUVngQCQUuXF4HFY2NZZ+crGnJYZw3I2iIobUgRDvPw4UqLIkpmyolD+CdBkIK6h3cxQ9axC zvb89Fi/oR3DDM0BqXMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rft7m-0000000G5Ju-1pOV; Fri, 01 Mar 2024 02:59:50 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rft7j-0000000G5JC-2QpG; Fri, 01 Mar 2024 02:59:48 +0000 X-UUID: bd7873c6d77711ee91d3e53c4c7db243-20240229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=4Dm+xiOAeCdHTix7lHbtaN8+wvs1/m5JpDQzKa+bWZI=; b=nX7EzTWEdrqYvELEiQGqHtIaynKBJDV3EJLHT4+y028q4qmnvQ027hsi8uo9RJWKbZqqP0B1VR+axURTxEWNWjPtZbWDip6XoGRFE7rFVfd0mzsxPQdKOrcWZIVyWkay0DSBHrz2LUQR2vOuw9f/9Y271IZmSQKi7wFIuoiWuls=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:042dfd42-db14-470e-b9ad-7a056289039a,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6f543d0,CLOUDID:80735fff-c16b-4159-a099-3b9d0558e447,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1, SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: bd7873c6d77711ee91d3e53c4c7db243-20240229 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1130017929; Thu, 29 Feb 2024 19:59:37 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 1 Mar 2024 10:48:59 +0800 Received: from SG2PR03CU006.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 1 Mar 2024 10:48:59 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K3SOUBPprqZ+RMILMpzFIuJYgOJjsaiZWHQ664Uu3L7A72wMcmb64YKxa4JBjlt2b72N6CD+IgFiHUZBdDG1IjA/jSQ416vl2gIGJDx+xOdfwuwqPQ/uErLxJxB9UlJ3M110h1FiGGqnZaqNpOS1dY8LzYpYVTtaXQdkuuwGeFI5iNHx7FQHH67odThId8j2fa9fUQIyu1vl4Ja6M83ArAQmlINy+xwzp1WNkc8bG3z/D3gMP5/a0RFpoHb7xEn08GkqFwFs3lbod0PFmyBgI9m8eo+1FTBWNcINca4/HJUw0hFYp0BoRSIwlXNpoBuIHMUNgn40rtsd4YD/akb8mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Dm+xiOAeCdHTix7lHbtaN8+wvs1/m5JpDQzKa+bWZI=; b=Jn0pxoNZuDalSsYNpJ6Z8WUnQurxZxeS0OzUMCTDu6GQBQDG0JQ42xrfWorBuL30zZhe8xCBqXKCu2Gim8OvOIFnm1dFY5iG5Qofr2Sg1qeeDXs0V/da89ZFsfp33Sia+Uy/qfreDLGY9qffwla6IHATAt0QXPmuxrWw66So/0T57mzhM/A5YBXrPg4YgXUFGU+vvtXGJOBZmBJVRfv39F+HXTr8XvhPXEuT1cjJ+KJCgM5u7UlyS+G355VGBRk+il+tsTvOSwWMLHBjhjAjJva1rbC3v2Nl22Sz+O6lOXuhA2FGRu94eFLXqtlyOwHQAzKpzZnS9vwv3i6TGOVoBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Dm+xiOAeCdHTix7lHbtaN8+wvs1/m5JpDQzKa+bWZI=; b=LW/KJgQ7TidYugMKUXe2abrT60RMWgV6meNPA39+DTH5IuXkUoX5IjYIeehZLXw3yvlY52fHZZH1BugzRULn1ovSeytDdqJMQ70feV09Js3ID1qeu6GtODFrEHNeLl3KJVIJ1bVFQ17+d4gEnqgk87rTpgLSCM+vrmf+qTjYnkE= Received: from PSAPR03MB5365.apcprd03.prod.outlook.com (2603:1096:301:17::5) by SEZPR03MB7246.apcprd03.prod.outlook.com (2603:1096:101:a9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.41; Fri, 1 Mar 2024 02:48:56 +0000 Received: from PSAPR03MB5365.apcprd03.prod.outlook.com ([fe80::22dd:6695:c2ad:c4bf]) by PSAPR03MB5365.apcprd03.prod.outlook.com ([fe80::22dd:6695:c2ad:c4bf%7]) with mapi id 15.20.7339.031; Fri, 1 Mar 2024 02:48:56 +0000 From: =?utf-8?B?Smlhbmp1biBXYW5nICjnjovlu7rlhpsp?= To: "linux-pci@vger.kernel.org" , "angelogioacchino.delregno@collabora.com" CC: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "wenst@chromium.org" , "kernel@collabora.com" , "p.zabel@pengutronix.de" , "robh@kernel.org" , "kw@linux.com" , "linux-arm-kernel@lists.infradead.org" , "bhelgaas@google.com" , "matthias.bgg@gmail.com" , "lpieralisi@kernel.org" , Ryder Lee , "nfraprado@collabora.com" Subject: Re: [PATCH v2] PCI: mediatek-gen3: Assert MAC reset only if PHY reset also present Thread-Topic: [PATCH v2] PCI: mediatek-gen3: Assert MAC reset only if PHY reset also present Thread-Index: AQHaavEyOFiHWdSs9EW2P5MBW1O/vrEiMBwA Date: Fri, 1 Mar 2024 02:48:55 +0000 Message-ID: <30824df32636dec25b9a5972b1ee8de76b295feb.camel@mediatek.com> References: <20240229092449.580971-1-angelogioacchino.delregno@collabora.com> In-Reply-To: <20240229092449.580971-1-angelogioacchino.delregno@collabora.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PSAPR03MB5365:EE_|SEZPR03MB7246:EE_ x-ms-office365-filtering-correlation-id: 3443112a-bb28-49f5-924f-08dc399a234b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SLuASAmHltcG/g6USJMPb7Hc9FNF0QeT3k9LAWlG3mXC5UDd7DBb4SdZnTkDDIihBrT20bF8dLOuIfHpwtmDlVzZ7vf0KLhLfRFrQSCDwsZeiMXYy/2rZVna9nIrz9KuoEZbtzChpwoIAg8EIz3GPkCO3owiGv6Gywj0yY4GPh75YiKDVVROkndO7U46mIRSb7E+9NbKNBOVMFv9uBZjdNslFglkYTWWvv3kGjgMAuT907V5vnnQE4oaAhIq1h6cC5EdXgpykIKAof0ZVEkVPxCynFSZcMgV9FwhKv+fQUZ1wP7xXq8gJoGY4zcHHwBSFpTE/+QO9fZNCs3zzCP3G0//3JX/95W7VYtxSLuTSvQ5flPjNw7oaXJK5ENSG7oZ7OCeHXVT+q3ED8l9WeOTnJftW/DbNH0VXop72uhxBqqfF1Sskox9drFPdkIKipEJ21k3QEPQspd9rDsm/AQNOQc+CwsqwxsU2PHvY9qj8uYMfJdD8ayut/616L9XeU3xXJO30V9gR6Jbbj6EBIgH9KCAaJF+qJXg9q0Y/ZiPkxBqdrBEbSJlcyMqZWMkWNRWNZKSEEP5FumVairK4Y1SxsCQTr3JZq96sLWgiu48ElsDuPbKXFE3K975ts+M0OwassKWF5LemA1QZfInxNpVqz1vsgn5pASmJFpdHAXNBCaislldzx5LfH4a1LZVI4QAASbDKFKo+Xqw32O/Tn3Hz0VVd9URgdz83b8cwz0YM3I= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PSAPR03MB5365.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?M1o2Q2ZYdW9rYnpqZG9MeDJTNjdtMmg0SVNsRFFTTitPdHJ4SDhXY2tvYjZj?= =?utf-8?B?bnlFS293ampIZEpNbSsvMmorSXhyQUxkRFNGeDdIb0lTSC90bG02RmZ1ZW5I?= =?utf-8?B?d01EbkFON1gyayttb2Nzd0tJRjI4bk5zOGJBOVVRRUg0aWEvTHB4bmpVYkpZ?= =?utf-8?B?OU1HUHpEd2daM2JyUzV5aDdpcG9KSE40NUhHTUViTDRFYlRMUnkrRk9ndWxE?= =?utf-8?B?N0Y0MCtvdEF0K1dyT3RSWFlEeVJNalVLQm5MT1N6dlA1T0M5RHFPcGZGcG03?= =?utf-8?B?a1BHSUdsZ0Y0cDFqRFR5NzZpTWd4T2MxVG9iS3JVa3pQN1lJRk1aZFFDeEJW?= =?utf-8?B?UndmdnVpRzZTMmZXZWpPTHE4d3B0RVhLQ1dtSDlXWWVJbytRVFFsY2JSMDJk?= =?utf-8?B?dExMaFFKSk16RVhyQ29SU2NSRU1hOVJIejE1S0JLRjdoVkFrTW0xZjBBZWFO?= =?utf-8?B?UHhCdkhjQ2h0UEI3RjFQc2orOXlXUWJVL1F3SHF6NFlCYTR4TkU2OWN4SERV?= =?utf-8?B?V3JRVWMvUW1BcU0zRi80by9EQWE4Q1BUNUtMZnROcHlublZ1WU5MRWFBV24x?= =?utf-8?B?RjE3UWlCR0IrVmR2dGZTU3JzcEM2YlRRVEdzMWUyOTdFRWJZMzhqYnFwcWxO?= =?utf-8?B?b1pqSitLWlA5YWw4SUw0Q2ZtQTRnV0Q5bzhQQU9xeldMV0VRUUhVTEpGdlNB?= =?utf-8?B?OVhnVnlkYzJNOCtCbm1LZUJYdWZRcGFpVzZoZGZ1K0E0MUVLOEIxU3pJZ256?= =?utf-8?B?YmhoOTBPT1FmazhSRTRjY1JqemhVa09oYW0zSHhWQ2hlU0pHd0hFajFPUUR4?= =?utf-8?B?NVlMWDh4WkVmY2hxQUJMbUdhcjBEYmVLc0xlcnJweFN1SzNUbkd1aGNQS0dj?= =?utf-8?B?NTlQTUhsdDRhc1VNVXI2TzBJMzZFc1J1a05oZitSUmpLcDk5MTlneU5EZktF?= =?utf-8?B?OVFCOWdTM0tTWTVaNWZhWnNGUVIwclIvdjY0S2RaclVMbzZtcFRlZk9CVjhW?= =?utf-8?B?ME9xOXFKRTB0djlsdm5mOTZudXVROXljUVBTNXZlc3ZpdlRLTDRDaWJMdjNN?= =?utf-8?B?dXFzNEJFTjNrbkcvMXZ3QjNxbkwzeW5UWjd6cXV6MTJUT3dMZlNmSTZDM1Bm?= =?utf-8?B?QXdXcUVnNldDOVl6Y0ZJSTJCQUN1MFhhRWprRGkxOVZXVExJUmphWE5xU3hu?= =?utf-8?B?bU16bHRrQWs0ZjhBdy9WZzlJOVdERlN2SThtQitHY2JvWHQ3YVRZQWd5dGl4?= =?utf-8?B?VUR4NUNqenRNWURSQkVnWXY4U0ZnbzB1NlNtSEJYcWpNR3dDNW1ZTXhocVdN?= =?utf-8?B?YlJkYmhYeTRHcThEL2FqQmZSOUQ2d3M5dEYzQXZEUXE4ZXlocFlmNncrOEIv?= =?utf-8?B?dExEUDZ3dmxxcWUzWUgrNVJPcFNBTmFXTFBEMkl6YkxhcTJSQWpvRFdZa24x?= =?utf-8?B?NW82STFqd2ZGOS95elArVHVIWGtZMDRqSzVRak1SSU4rS0phU2czMDNGNnJK?= =?utf-8?B?REVMcjlldzZRQUxTSjZMaXBiUGZIcC9pYnhMSWp4TGlUV0pYQTkxMkhRMURY?= =?utf-8?B?OGlBUlIxTGI1MUtDcEowRHAwcklTTVRBUi9wZXJmZG9FY3dGQjFHVW5QMllk?= =?utf-8?B?TmtJRTNXWG5VRExONVdBR3R1SE0zRzF3TWVib2llcUJ4bVVId3NrVDg5S1hu?= =?utf-8?B?SklIQ2x3TWdmbmtMM2tWaGp5aCtTYjBrbjNlWjJLRWVodzFwS2ZiWVRpKzBV?= =?utf-8?B?QXZkRUF5WEtsakxoR3dYZTNPUmcvMDkyNlpZSnJGNzRQaXBJOWZxejQ1SitM?= =?utf-8?B?K1creWQ5K2h5WlRXbnB2K3QwSEJsWWhDUHBSbEI2dTV0UTVDWXpHekQyM203?= =?utf-8?B?THBMbGt3ZlZWK0UzQ1ozUnBDdWM5Wk1VU0Z2MmVwSWd3ZW1KUCtYNFhvWG5u?= =?utf-8?B?RDZuMDh5RHc3WENuQWdjclF0YUxERnl3MkdZT3M1TFh2RVBWUk5wN2xlc0Jo?= =?utf-8?B?S1hSRmRSd00yWW02Vlp1MGNtMmNqVjcyWkF3QWZpMVhqaFdBZ1RDblMyaFdp?= =?utf-8?B?NlZQVXNwVHpyNjFtdnRvcWRrbHoxUWJPV0pPUUlYS2lRV3F6ZHlscWJvOEtD?= =?utf-8?B?emNHNDhFM3RXaE5rMDkzQmRINUZMNmVnQlNaa3F3akduSW1UY2tRUlRMcEFT?= =?utf-8?B?UlE9PQ==?= Content-ID: <548AD5B922BC4C4D9B6DF1B18227382B@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PSAPR03MB5365.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3443112a-bb28-49f5-924f-08dc399a234b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2024 02:48:55.9075 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S/AJbHOGkPJ3w/hYh+r7AsQr7T8pB85fG6X4JCCBB8dYwUisRdf7wvwDqKTmDHptAubj1gC8EuHp0Y9WgTpA/9+8zpLqzs+L2cOQSEdL3qo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR03MB7246 X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--23.560800-8.000000 X-TMASE-MatchedRID: UWn79NfEZzbUL3YCMmnG4uYAh37ZsBDCQV6BZJ9WeFayrCkM9r1bWskU hKWc+gwPWASbhXBhlp5EWfNw6xpshwu0oQDyuFNTJhFEQZiq2ZRo3Yq5PCwLAvt592eq2xoTcZR z3r8mb5RbFSjXHvY/oEr+cHw2Pi9QrPvkNFf532SM29hkek7XdwRryDXHx6oXdf6tui+/W0yQxX DSJnj4A1yIuBLp7rU4l/nE+SiO7IYdj9vNGYhpkeKXavbHY/C1edRmpFvdpuZ3aEDyEjSZIaDz5 hsiacLfyJbKe4z4Q29ICsMQxCDS2Lsl8Gv1eXkKQpxiLlDD9FW2LJAlsBf47r2Bebs5vP5MwOWn bwsz43LeRumvl8rHn5GTpe1iiCJq0u+wqOGzSV1WdFebWIc3VsRB0bsfrpPIFUFJm2B6H9E= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--23.560800-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: 5703A05AB2CC6B9C44C07E297670AF1207EBBBD9F0865BADAE1C5AD052A8800F2000:8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240229_185947_645262_22131DED X-CRM114-Status: GOOD ( 23.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Angelo, Thanks for your patch. On Thu, 2024-02-29 at 10:24 +0100, AngeloGioacchino Del Regno wrote: > Some SoCs have two PCI-Express controllers: in the case of MT8195, > one of them is using a dedicated PHY, but the other uses a combo PHY > that is shared with USB and in that case the PHY cannot be reset > from the PCIe driver, or USB functionality will be unable to resume. > > Resetting the PCIe MAC without also resetting the PHY will result in > a full system lockup at PCIe resume time and the only option to > resume operation is to hard reboot the system (with a PMIC cut-off). > > To resolve this issue, check if we've got both a PHY and a MAC reset > and, if not, never assert resets at PM suspend time: in that case, > the link is still getting powered down as both the clocks and the > power domains will go down anyway. > > Fixes: d537dc125f07 ("PCI: mediatek-gen3: Add system PM support") > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > > Changes in v2: > - Rebased over next-20240229 > > drivers/pci/controller/pcie-mediatek-gen3.c | 25 ++++++++++++++----- > -- > 1 file changed, 17 insertions(+), 8 deletions(-) > > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c > b/drivers/pci/controller/pcie-mediatek-gen3.c > index 975b3024fb08..99b5d7a49be1 100644 > --- a/drivers/pci/controller/pcie-mediatek-gen3.c > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c > @@ -874,17 +874,26 @@ static int mtk_pcie_power_up(struct > mtk_gen3_pcie *pcie) > return err; > } > > -static void mtk_pcie_power_down(struct mtk_gen3_pcie *pcie) > +static void mtk_pcie_power_down(struct mtk_gen3_pcie *pcie, bool > is_suspend) > { > + bool suspend_reset_supported = pcie->mac_reset && pcie- > >phy_reset; > + > clk_bulk_disable_unprepare(pcie->num_clks, pcie->clks); > > pm_runtime_put_sync(pcie->dev); > pm_runtime_disable(pcie->dev); > - reset_control_assert(pcie->mac_reset); > + > + /* > + * Assert MAC reset only if we also got a PHY reset, otherwise > + * the system will lockup at PM resume time. > + */ > + if (is_suspend && suspend_reset_supported) > + reset_control_assert(pcie->mac_reset); > > phy_power_off(pcie->phy); > phy_exit(pcie->phy); > - reset_control_assert(pcie->phy_reset); > + if (is_suspend && suspend_reset_supported) > + reset_control_assert(pcie->phy_reset); > } > > static int mtk_pcie_setup(struct mtk_gen3_pcie *pcie) > @@ -920,7 +929,7 @@ static int mtk_pcie_setup(struct mtk_gen3_pcie > *pcie) > return 0; > > err_setup: > - mtk_pcie_power_down(pcie); > + mtk_pcie_power_down(pcie, false); > > return err; > } > @@ -951,7 +960,7 @@ static int mtk_pcie_probe(struct platform_device > *pdev) > err = pci_host_probe(host); > if (err) { > mtk_pcie_irq_teardown(pcie); > - mtk_pcie_power_down(pcie); > + mtk_pcie_power_down(pcie, false); > return err; > } > > @@ -969,7 +978,7 @@ static void mtk_pcie_remove(struct > platform_device *pdev) > pci_unlock_rescan_remove(); > > mtk_pcie_irq_teardown(pcie); > - mtk_pcie_power_down(pcie); > + mtk_pcie_power_down(pcie, false); Is there any reason not to reset the MAC and PHY when probe fails and driver removing? Some SoCs may not have MTCMOS to cut off their power, we need to assert the reset signal to save power in that case. Thanks. > } > > static void mtk_pcie_irq_save(struct mtk_gen3_pcie *pcie) > @@ -1044,7 +1053,7 @@ static int mtk_pcie_suspend_noirq(struct device > *dev) > dev_dbg(pcie->dev, "entered L2 states successfully"); > > mtk_pcie_irq_save(pcie); > - mtk_pcie_power_down(pcie); > + mtk_pcie_power_down(pcie, true); > > return 0; > } > @@ -1060,7 +1069,7 @@ static int mtk_pcie_resume_noirq(struct device > *dev) > > err = mtk_pcie_startup_port(pcie); > if (err) { > - mtk_pcie_power_down(pcie); > + mtk_pcie_power_down(pcie, false); > return err; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel