From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 192C9C3F2C6 for ; Sun, 1 Mar 2020 00:02:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E40D62468E for ; Sun, 1 Mar 2020 00:02:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oiu98EDZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E40D62468E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+2Ap6yU9MNznv8dneCcNNrsA9Uy3DPkdya9dz9LfufE=; b=oiu98EDZMbfzjy Wi54V6knefYerDvJL4SyXhpxS+XXRga3rG+X835/r/G1jZTKJGU6r2U4GMaFyryVYIuZ2YK10fYYL Zw4wb6xqyLA4I/w8yvFNj/2fUrwdhJN60dHr+Es+kOwhKhyp8bfulCjoixoK3zU+zpQWasxdOEhnR h4VcXWQAqG5xULAsdH49QKVQXiOJ2ZN2tBZo5IFmgtHRRfSTNpfFrgjfK3UoNM9sr/Lu54lxQXh+8 LZw2ua4C8ZMrw4VpVd8oTbDXRvA6zkPw08IhEzPOAIfFK+N/9Zw9K9IQlwf1wfvQF1ACrmwWnBNQR ZTFFdUo/XHkuYUJqeexQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8C3g-0004lF-Qn; Sun, 01 Mar 2020 00:02:12 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j8C3e-0004ko-7U; Sun, 01 Mar 2020 00:02:11 +0000 Received: from p508fcd9d.dip0.t-ipconnect.de ([80.143.205.157] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1j8C3a-0004tG-JZ; Sun, 01 Mar 2020 01:02:06 +0100 From: Heiko Stuebner To: Johan Jonker , dianders@chromium.org Subject: Re: [PATCH 3/4] dt-bindings: arm: fix Rockchip rk3399-evb bindings Date: Sun, 01 Mar 2020 01:02:06 +0100 Message-ID: <3089122.gegXmbq47i@phil> In-Reply-To: <229c3511-d99d-8bac-6241-0088c5fc13ef@gmail.com> References: <20200228061436.13506-1-jbx6244@gmail.com> <78b8b53f-2e2a-3804-41fb-bb2610947ca2@arm.com> <229c3511-d99d-8bac-6241-0088c5fc13ef@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200229_160210_420637_EEFDCE3A X-CRM114-Status: GOOD ( 16.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, Robin Murphy , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Johan, Am Freitag, 28. Februar 2020, 14:28:36 CET schrieb Johan Jonker: > Hi Robin, > > When I look at the review process of rk3399-evb.dts > it is mentioned here: > > https://lore.kernel.org/patchwork/patch/672327/ > > >> + model = "Rockchip RK3399 Evaluation Board"; > >> + compatible = "rockchip,rk3399-evb", "rockchip,rk3399", > >> + "google,rk3399evb-rev2", google,rk3399evb-rev1", > >> + "google,rk3399evb-rev0" ; > > > > can you check against which compatibles that coreboot really matches? > > > > As we said that the evb changed between rev1 and rev2, I would expect the > > compatible to be something like > > > > compatible = "rockchip,rk3399-evb", "google,rk3399evb-rev2", > > "rockchip,rk3399"; > > > > leaving out the rev1 and rev0 > > The consensus in version 4 ends in what is shown in the dts file, so I > changed it in rockchip.yaml. Things from the past maybe can better be > explained by Heiko. Please advise if this patch needs to change and in > what file. Just get rid of the "google,rk3399evb-rev2" from the .dts please :-) . (1) "rockchip,rk3399-evb", "rockchip,rk3399", "google,rk3399evb-rev2"; is just wrong for the reasons Robin explained, I guess that slipped through review at the time. (2) "google,rk3399evb-rev2" was a specific variant for Google I'm pretty sure they'll have scraped all these boards directly after they had the first actual rk3399-gru development devices So I'm pretty sure the only rk3399-evbs in existence are the general ones. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel