From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <maxime@cerno.tech>,
Maxime Ripard <maxime@cerno.tech>
Cc: Taras Galchenko <tpgalchenko@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
dri-devel@lists.freedesktop.org,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] drm/sun4i: frontend: Rework a bit the phase data
Date: Wed, 21 Oct 2020 19:16:17 +0200 [thread overview]
Message-ID: <3090261.6p6c3PZEHK@kista> (raw)
In-Reply-To: <20201015093642.261440-1-maxime@cerno.tech>
Hi!
Dne četrtek, 15. oktober 2020 ob 11:36:40 CEST je Maxime Ripard napisal(a):
> The scaler filter phase setup in the allwinner kernel has two different
> cases for setting up the scaler filter, the first one using different phase
> parameters for the two channels, and the second one reusing the first
> channel parameters on the second channel.
>
> The allwinner kernel has a third option where the horizontal phase of the
> second channel will be set to a different value than the vertical one (and
> seems like it's the same value than one used on the first channel).
> However, that code path seems to never be taken, so we can ignore it for
> now, and it's essentially what we're doing so far as well.
>
> Since we will have always the same values across each components of the
> filter setup for a given channel, we can simplify a bit our frontend
> structure by only storing the phase value we want to apply to a given
> channel.
>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-10-21 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 9:36 [PATCH 1/3] drm/sun4i: frontend: Rework a bit the phase data Maxime Ripard
2020-10-15 9:36 ` [PATCH 2/3] drm/sun4i: frontend: Reuse the ch0 phase for RGB formats Maxime Ripard
2020-10-21 17:18 ` Jernej Škrabec
2020-10-15 9:36 ` [PATCH 3/3] drm/sun4i: frontend: Fix the scaler phase on A33 Maxime Ripard
2020-10-21 17:16 ` Jernej Škrabec
2020-10-26 10:22 ` Maxime Ripard
2020-10-21 17:16 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3090261.6p6c3PZEHK@kista \
--to=jernej.skrabec@siol.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=paul.kocialkowski@bootlin.com \
--cc=tpgalchenko@gmail.com \
--cc=tzimmermann@suse.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).