From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: tiny.windzz@gmail.com, rafael@kernel.org,
viresh.kumar@linaro.org, wens@csie.org, samuel@sholland.org,
mripard@kernel.org, Xiaobing Luo <luoxiaobing0926@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Xiaobing Luo <luoxiaobing0926@gmail.com>
Subject: Re: [PATCH v3] cpufreq: fix memory leak in sun50i_cpufreq_nvmem_probe
Date: Mon, 25 Apr 2022 17:39:39 +0200 [thread overview]
Message-ID: <3099618.5fSG56mABF@kista> (raw)
In-Reply-To: <20220425113009.2182485-1-luoxiaobing0926@gmail.com>
Dne ponedeljek, 25. april 2022 ob 13:30:09 CEST je Xiaobing Luo napisal(a):
> --------------------------------------------
> unreferenced object 0xffff000010742a00 (size 128):
> comm "swapper/0", pid 1, jiffies 4294902015 (age 1187.652s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<00000000b4dfebaa>] __kmalloc+0x338/0x474
> [<00000000d6e716db>] sun50i_cpufreq_nvmem_probe+0xc4/0x36c
> [<000000007d6082a0>] platform_probe+0x98/0x11c
> [<00000000c990f549>] really_probe+0x234/0x5a0
> [<000000002d9fecc6>] __driver_probe_device+0x194/0x224
> [<00000000cf0b94fa>] driver_probe_device+0x64/0x13c
> [<00000000f238e4cf>] __device_attach_driver+0xf8/0x180
> [<000000006720e418>] bus_for_each_drv+0xf8/0x160
> [<00000000df4f14f6>] __device_attach+0x174/0x29c
> [<00000000782002fb>] device_initial_probe+0x20/0x30
> [<00000000c2681b06>] bus_probe_device+0xfc/0x110
> [<00000000964cf3bd>] device_add+0x5f0/0xcd0
> [<000000004b9264e3>] platform_device_add+0x198/0x390
> [<00000000fa82a9d0>] platform_device_register_full+0x178/0x210
> [<000000009a5daf13>] sun50i_cpufreq_init+0xf8/0x168
> [<000000000377cc7c>] do_one_initcall+0xe4/0x570
> --------------------------------------------
>
> if sun50i_cpufreq_get_efuse failed, then opp_tables leak.
>
> Fixes: f328584f7bff ("cpufreq: Add sun50i nvmem based CPU scaling driver")
> Signed-off-by: Xiaobing Luo <luoxiaobing0926@gmail.com>
This patch was already applied (v2).
Best regards,
Jernej
> ---
> drivers/cpufreq/sun50i-cpufreq-nvmem.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-
cpufreq-nvmem.c
> index 2deed8d8773f..75e1bf3a08f7 100644
> --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> @@ -98,8 +98,10 @@ static int sun50i_cpufreq_nvmem_probe(struct
platform_device *pdev)
> return -ENOMEM;
>
> ret = sun50i_cpufreq_get_efuse(&speed);
> - if (ret)
> + if (ret) {
> + kfree(opp_tables);
> return ret;
> + }
>
> snprintf(name, MAX_NAME_LEN, "speed%d", speed);
>
> --
> 2.36.0
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-04-25 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 11:30 [PATCH v3] cpufreq: fix memory leak in sun50i_cpufreq_nvmem_probe Xiaobing Luo
2022-04-25 15:39 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3099618.5fSG56mABF@kista \
--to=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=luoxiaobing0926@gmail.com \
--cc=mripard@kernel.org \
--cc=rafael@kernel.org \
--cc=samuel@sholland.org \
--cc=tiny.windzz@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).