From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F020DC52D7C for ; Mon, 19 Aug 2024 23:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IJwN9HIH0vQVHBIRMEBIuEGGn+Wdu5CYS0Yntep1Emo=; b=k295e27PPjJC/3fyP4sLyzMOp8 vC4/mzN9hxA1AlTtNHBdrr1kd49mDBXWVzSvLiFF9kB0ke9jYgX/AjaLOlJkIDR+0OaqSRIzxj718 pmeqetFctepHy1B7btJ72fcDB51aigp6biX3n9lJ5PRgVlxdR3C3R1ayXPjpmiJl2eDHNnMsYke0S YrHv0nQ1YGClCFr6gjE88iCpIbUX80e+dQKeSX1SE6B29S1RXNNTKf7ZLalHm69Ft8/iPZf6HTeJr +TCQKpVBjaIzOOMQUA41qecxbBlnQ5JUsRmjJq9/ZpiTXV5D4nXJCHNl42UMHsQoIyNeFXR4vjCzT hzPYq1Rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgBUg-00000003CW8-1her; Mon, 19 Aug 2024 23:08:58 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgBTy-00000003CIO-1pJF for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2024 23:08:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9B9FB60C63; Mon, 19 Aug 2024 23:08:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60F7FC32782; Mon, 19 Aug 2024 23:08:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724108893; bh=Q3A4bDKDw+D/pxKm8nl51yuFDsQ4UfiO0ix22SGurDs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=u7vWsR6X8LCJGKE6vvNyQ/UvHu5m6zsjyTsOIh9to5BfzbYc/I0MaAsMFV7hSN+Nn 9fB0EVV2wjeP8MzUhM+YOKv9ruNO+EOGdi0eaOtsbyjWlF2XhTDdv3TRDDIA6EhcMh usLnkZjl/xpmbQl/1rVjQcDh19GnZ1dgWroPD8IHWJmKPtbkhPDpI4o7k+77RMAuR9 bqugKGWNcelKU50jglkOkN45fzO5dRZN5nBWzk6dR8hKINyYhFg9XsXF1d26VkA42h f4O6F+fDZh9SYKGFgBniIKDcdYp9asip9zNsgBAul/CZHFT+8xUg9mGflttaNeXDDX XuLm9GzIAl4qQ== Message-ID: <309d9abd-e60b-4e8b-8def-7c4430635422@kernel.org> Date: Tue, 20 Aug 2024 08:08:07 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/9] PCI: Make pcim_iounmap_region() a public function To: Philipp Stanner , onathan Corbet , Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Richard Cochran , Mark Brown , David Lechner , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , Hannes Reinecke , Chaitanya Kulkarni , "Martin K. Petersen" Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev References: <20240819165148.58201-2-pstanner@redhat.com> <20240819165148.58201-4-pstanner@redhat.com> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20240819165148.58201-4-pstanner@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_160814_573997_17220D40 X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/20/24 01:51, Philipp Stanner wrote: > The function pcim_iounmap_regions() is problematic because it uses a > bitmask mechanism to release / iounmap multiple BARs at once. It, thus, > prevents getting rid of the problematic iomap table mechanism which was > deprecated in commit e354bb84a4c1 ("PCI: Deprecate pcim_iomap_table(), > pcim_iomap_regions_request_all()"). > > Make pcim_iounmap_region() public as the successor of > pcim_iounmap_regions(). > > Signed-off-by: Philipp Stanner Looks fine, but as commented on patch 1, I think this would look better squashed with patch 1. Anyway: Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research