From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "CK Hu (胡俊光)" <ck.hu@mediatek.com>,
"Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"wenst@chromium.org" <wenst@chromium.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"airlied@gmail.com" <airlied@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 04/11] drm/mediatek: Add OVL compatible name for MT8195
Date: Mon, 18 Sep 2023 11:21:44 +0200 [thread overview]
Message-ID: <30cc93a5-b3de-d23f-fd4d-e695551a71e3@collabora.com> (raw)
In-Reply-To: <ffcf35cb8ca1ff0fe0a0f0176e3199b9c944b3b9.camel@mediatek.com>
Il 18/09/23 11:09, CK Hu (胡俊光) ha scritto:
> On Mon, 2023-09-18 at 16:42 +0800, Hsiao Chien Sung wrote:
>> Add OVL compatible name for MT8195.
>
> Reviewed-by: CK Hu <ck.hu@mediatek.com>
>
> but it's weird to put this patch into IGT series. Without this patch,
> mt8195 drm driver does not work not only IGT.
>
The driver does work because the devicetree node declares two compatibles,
"mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl" where the second
compatible is matched in mtk_drm_drv, and the first is matched in mtk_disp_ovl
as both are platform_driver.
This commit is not necessary, even... :-)
Regards,
Angelo
> Regards,
> CK
>
>>
>> Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
>> ---
>> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> index 93552d76b6e7..7759a06e5c0e 100644
>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> @@ -715,6 +715,8 @@ static const struct of_device_id
>> mtk_ddp_comp_dt_ids[] = {
>> .data = (void *)MTK_DISP_OVL },
>> { .compatible = "mediatek,mt8192-disp-ovl",
>> .data = (void *)MTK_DISP_OVL },
>> + { .compatible = "mediatek,mt8195-disp-ovl",
>> + .data = (void *)MTK_DISP_OVL },
>> { .compatible = "mediatek,mt8183-disp-ovl-2l",
>> .data = (void *)MTK_DISP_OVL_2L },
>> { .compatible = "mediatek,mt8192-disp-ovl-2l",
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-18 9:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:41 [PATCH v2 00/11] Support IGT in display driver Hsiao Chien Sung
2023-09-18 8:41 ` [PATCH v2 01/11] soc: mediatek: Add register definitions for GCE Hsiao Chien Sung
2023-09-18 9:06 ` AngeloGioacchino Del Regno
2023-09-18 8:41 ` [PATCH v2 02/11] soc: mediatek: Support GCE jump to absolute Hsiao Chien Sung
2023-09-18 8:51 ` CK Hu (胡俊光)
2023-09-18 8:41 ` [PATCH v2 03/11] soc: mediatek: Disable 9-bit alpha in ETHDR Hsiao Chien Sung
2023-09-18 9:06 ` AngeloGioacchino Del Regno
2023-09-18 8:42 ` [PATCH v2 04/11] drm/mediatek: Add OVL compatible name for MT8195 Hsiao Chien Sung
2023-09-18 9:09 ` CK Hu (胡俊光)
2023-09-18 9:21 ` AngeloGioacchino Del Regno [this message]
2023-09-18 9:27 ` CK Hu (胡俊光)
2023-10-11 9:38 ` Shawn Sung (宋孝謙)
2023-10-11 11:51 ` AngeloGioacchino Del Regno
2023-10-12 2:18 ` Shawn Sung (宋孝謙)
2023-09-18 8:42 ` [PATCH v2 05/11] drm/mediatek: Adjust DRM mode configs for IGT Hsiao Chien Sung
2023-09-18 9:05 ` CK Hu (胡俊光)
2023-09-18 8:42 ` [PATCH v2 06/11] drm/mediatek: Support alpha blending in display driver Hsiao Chien Sung
2023-09-18 9:25 ` CK Hu (胡俊光)
2023-09-18 8:42 ` [PATCH v2 07/11] drm/mediatek: Support alpha blending in VDOSYS0 Hsiao Chien Sung
2023-09-18 8:42 ` [PATCH v2 08/11] drm/mediatek: Support alpha blending in VDOSYS1 Hsiao Chien Sung
2023-09-18 8:42 ` [PATCH v2 09/11] drm/mediatek: Support CRC in display driver Hsiao Chien Sung
2023-09-18 8:42 ` [PATCH v2 10/11] drm/mediatek: Support CRC in VDOSYS0 Hsiao Chien Sung
2023-09-18 8:42 ` [PATCH v2 11/11] drm/mediatek: Support CRC in VDOSYS1 Hsiao Chien Sung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30cc93a5-b3de-d23f-fd4d-e695551a71e3@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Shawn.Sung@mediatek.com \
--cc=airlied@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).