From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9724FCD98F2 for ; Mon, 22 Jun 2026 13:12:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cNdjL00WBqqYfozOsasxypzA3JammtyHrJgX4pryvkQ=; b=1qx4KJfNN48q9zZXAt4vkOlyTP i7sgzOzpZmi0jw2meqG0WoiVSgyfl6sueaISdwme2GIpJ67fYc7yXg8bUvh15W+qmx3t7YEwRhZbe K8oJaZQeVLZY2OfNNjSxDwtjBAPoggGIIaAKsuriLCma8LTp3u+6okySRxncD+BDdKXt1lsYXSXgc oWDpVErL7sXZ0ykO5RZp+5Ub212YD/vk1TUQJj4IgODlUJZHck5rP5z3b3ahS0TtjbJu13OfLuZ59 Rtf9JV31oxPf9ymqfAr7xASzNn0Cz62aWqGFO3Z4mD/NzszwSki5n6QMD7KK0iD4nnZyG2GNXEyDB a3bFvXAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbeS5-000000050PC-1EKU; Mon, 22 Jun 2026 13:12:37 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbeS0-000000050OK-1IdR for linux-arm-kernel@lists.infradead.org; Mon, 22 Jun 2026 13:12:32 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id B162C601F3; Mon, 22 Jun 2026 13:12:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C5F41F000E9; Mon, 22 Jun 2026 13:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782133951; bh=cNdjL00WBqqYfozOsasxypzA3JammtyHrJgX4pryvkQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=TE1Xg9xv0dMhSVDV5EGq5eKodXJMYui/TMChcbqljfUPdkceLsZtHN6K+Uy5lz6oN XV0PADg1y3LvGChpVWDNFSTtWWzamFznR92drIVfrEgXfi3MpEmCf9xv20yM5NizZ1 g4U4MQ9YSV+Wrz17Li4BGRcxeeHtVK2H8lOnrzlhniSq/luzXn2VRMLRS/OMnP/ZkR 0J6YjaNvUS4tRewTPiHJZ7kRDgkHEYrimS6S/FAZAczQIxAa3ExY8khWQ0tdX3Wxkg hDa43bZZJccGs/ETsTtxqBKm5VLK+NqpD4VqdSRQ3keP+s0CVVpNWm6fUIQoxxLltR rIPwzvfusfodw== Message-ID: <30e02780-52c7-4a71-9d4f-4b7a20494161@kernel.org> Date: Mon, 22 Jun 2026 15:12:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] dt-bindings: nvmem: imx-ocotp: Add support for secure-enclave To: Frieder Schrempf , Frieder Schrempf Cc: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Shawn Guo , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260616-upstreaming-next-20260609-imx-ocotp-ele-v1-0-cb7f3698c3e6@kontron.de> <20260616-upstreaming-next-20260609-imx-ocotp-ele-v1-1-cb7f3698c3e6@kontron.de> <20260617-prodigious-private-inchworm-beae1e@quoll> <085262ba-32e5-4011-8df3-5a677575b2db@kontron.de> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <085262ba-32e5-4011-8df3-5a677575b2db@kontron.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/06/2026 13:36, Frieder Schrempf wrote: > On 17.06.26 12:49, Krzysztof Kozlowski wrote: >> On Tue, Jun 16, 2026 at 01:52:16PM +0200, Frieder Schrempf wrote: >>> From: Frieder Schrempf >>> >>> Some SoCs like the i.MX9 family allow full access to the fuses only >>> through the secure enclave firmware API. Add a property to reference >>> the secure enclave node and let the driver use the API. >>> >>> Signed-off-by: Frieder Schrempf >>> --- >>> Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml b/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml >>> index a8076d0e2737..14a6429f4a4c 100644 >>> --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml >>> +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml >>> @@ -53,6 +53,10 @@ properties: >>> reg: >>> maxItems: 1 >>> >>> + secure-enclave: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: A phandle to the secure enclave node >> >> Two things here: >> 1. Here you describe what for is that phandle, how it is used by the >> hardware. Currently the description repeats the property name and type, >> so not much useful. > > Ok, agree. > >> >> 2. If you access OTP via firmware, then this is completely different >> interface than MMIO, thus: >> A. reg is not appropriate >> B. Device is very different thus it has different compatible and I even >> claim should be in different binding. Devices having completely >> different SW interface should not be in the same binding, at least >> usually. >> >> If any of above is not accurate, then your commit msg should answer why >> and give some background. > > Thanks for the feedback! > > The driver currently uses the limited MMIO (FSB) interface to access the > OTPs. The intention is to support the firmware interface alongside the > MMIO interface so the driver can pick the interface that is available > (firmware might not be loaded) and fallback to MMIO. > > Following your argument would mean a driver deciding by itself which > interface to use at runtime is not something we want to have in general, > right? No, the property fits DT, but above information should be in commit msg. If this SoC has indeed both interfaces - MMIO and firmware calls - then everything is in general fine. I assumed that is not the case and MMIO is not really working. What was confusing is that it feels like you are changing existing interface, but why wasn't all this documented in the beginning? There is imx9 in this binding already, so was it working? Was it not working at all? Commit msg must clarify that. > > In turn this would mean we need two drivers, or at least two > compatibles/bindings for something that is effectively the same hardware. Driver design is orthogonal choice here. It can reside in separate binding, if MMIO is still valid, but till everything is not yet too complex can be also this binding file. If it stays in this binding, then you need to restrict properties per variant, so add if:then: block which will disallow the phandle for other variants. Best regards, Krzysztof