[PATCH v2 06/23] ARM: Kirkwood: ioremap the cpu_config register before using it.

Ezequiel Garcia
2014-02-16T02:17:19Z

Hi Andrew,

On Sat, Feb 15, 2014 at 11:20:04AM +0100, Andrew Lunn wrote:
[..]
>
> +/*
> + * Disable propagation of mbus errors to the CPU local bus, as this
> + * causes mbus errors (which can occur for example for PCI aborts) to
> + * throw CPU aborts, which we're not set up to deal with.
> + */
> +void kirkwood_disable_mbus_error_propagation(void)
> +{
> + void __iomem *cpu_config;
> +
> + cpu_config = ioremap(CPU_CONFIG_PHYS, 4);
> + writel(readl(cpu_config) & ~CPU_CONFIG_ERROR_PROP, cpu_config);
> +}
> +

Any reason why this function above is not static __init?

And then: any reason why you're not unmapping the region?

(Sorry if this was already discussed)
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering