From: "Rafał Miłecki" <zajec5@gmail.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: "AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Eddie Huang" <eddie.huang@mediatek.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Ran Bi" <ran.bi@mediatek.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] dt-bindings: rtc: convert MT2717 RTC to the json-schema
Date: Mon, 22 Jan 2024 18:40:45 +0100 [thread overview]
Message-ID: <311fa703-7dbc-41d2-bfde-85dd7cb20657@gmail.com> (raw)
In-Reply-To: <1c4e14f7-ca34-4433-96cb-0ba6d6c6906d@gmail.com>
On 22.01.2024 14:19, Matthias Brugger wrote:
> On 22/01/2024 13:49, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> This helps validating DTS files. Introduced changes:
>> 1. Reworded title
>> 2. Dropper redundant properties descriptions
>> 3. Added required #include and adjusted "reg" in example
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>> .../bindings/rtc/mediatek,mt2712-rtc.yaml | 39 +++++++++++++++++++
>> .../devicetree/bindings/rtc/rtc-mt2712.txt | 14 -------
>> 2 files changed, 39 insertions(+), 14 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/rtc/mediatek,mt2712-rtc.yaml
>> delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-mt2712.txt
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/mediatek,mt2712-rtc.yaml b/Documentation/devicetree/bindings/rtc/mediatek,mt2712-rtc.yaml
>
> In this schema can easily fit "mediatek,mt7622-rtc", so how about renaming it and add reference for that RTC as well?
I see your point but by looking at existing Linux drivers:
drivers/rtc/rtc-mt2712.c
drivers/rtc/rtc-mt7622.c
it seems like quite different hardware blocks.
Different registers, different programming, clk in MT7622.
Should they really share a YAML binding just because they use similar
properties?
--
Rafał Miłecki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-22 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 12:49 [PATCH] dt-bindings: rtc: convert MT2717 RTC to the json-schema Rafał Miłecki
2024-01-22 13:19 ` Matthias Brugger
2024-01-22 17:40 ` Rafał Miłecki [this message]
2024-01-23 8:57 ` Krzysztof Kozlowski
2024-01-23 10:40 ` AngeloGioacchino Del Regno
2024-01-24 16:10 ` Matthias Brugger
2024-01-30 19:23 ` Rob Herring
2024-02-29 21:21 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=311fa703-7dbc-41d2-bfde-85dd7cb20657@gmail.com \
--to=zajec5@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rafal@milecki.pl \
--cc=ran.bi@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).