From: "Heiko Stübner" <heiko@sntech.de>
To: David Summers <beagleboard@davidjohnsummers.uk>
Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org,
linux-mmc@vger.kernel.org, jh80.chung@samsung.com,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
frowand.list@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection
Date: Wed, 13 Mar 2019 11:40:45 +0100 [thread overview]
Message-ID: <3123627.puci4abFsC@diego> (raw)
In-Reply-To: <20190309153923.22806-1-beagleboard@davidjohnsummers.uk>
Am Samstag, 9. März 2019, 16:39:21 CET schrieb David Summers:
> The Problem:
>
> On ASUS Tinker Board S, when booting from the eMMC, and there is card
> in the sd slot, there are constant errors.
>
> Also when warm reboot, uboot can not access the sd slot
>
> Cause:
>
> Identified by Robin Murphy @ ARM. The Card Detect on rk3288
> devices is pulled up by vccio-sd; so when the regulator powers this
> off, card detect gives spurious errors. A second problem, is during
> power down, vccio-sd apprears to be powered down. This causes a
> problem when warm rebooting from the sd card. This was identified by
> Jonas Karlman.
>
> History:
>
> A common fault on these rk3288 board, which impliment the reference
> design.
>
> When this arose before:
>
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/281153.htm
> l
>
> And Ulf and Jaehoon clearly said this was a broken card detect design,
> which should be solved via polling
>
> Solution:
>
> Hence broken-cd is set as a property. This cures the errors. The
> powering down of vccio-sd during reboot is cured by adding
> regulator-boot-on.
>
> This solutions has been fairly widely reviewed and tested.
>
> Signed-off-by: David Summers <beagleboard@davidjohnsummers.uk>
> Reviewed by: Robin Murphy <robin.murphy@arm.com>
> Reviewed by: Jonas Karlman <jonas@kwiboo.se>
> Test by: TheSaint @ ArchLinux Arm
applied as fix for 5.1 with the following modifications:
- new subject: "ARM: dts: rockchip: Fix SD card detection on rk3288-tinker"
to match the subsystem
- adapted Reviewed and Tested tags as collected from involved parties
- added Fixes and Cc-stable tags (pointing to the dtsi-split only to ease
load of stable maintainers, as hopefully most people will use somewhat
recent kernels on sbcs]
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-03-13 10:41 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 12:15 [PATCH 0/3] ARM: dts: rk3288 Tinker Board (S) updates David Summers
2019-02-17 12:15 ` [PATCH 1/3] ARM: dts: rk3288 Tinker Board (S) sdcard changes David Summers
2019-02-17 14:00 ` Robin Murphy
2019-02-17 15:19 ` David Summers
2019-02-18 11:54 ` Robin Murphy
2019-02-19 20:13 ` David Summers
2019-02-17 20:29 ` Stefan Wahren
2019-02-18 20:08 ` David Summers
2019-02-17 12:15 ` [PATCH 2/3] ARM: dts: rk3288 Tinker Board (S) add wi-fi David Summers
2019-02-17 14:32 ` Tony McKahan
2019-02-17 15:55 ` David Summers
2019-02-17 17:32 ` Tony McKahan
2019-02-17 21:19 ` Stefan Wahren
2019-02-17 19:03 ` David Summers
2019-02-17 20:43 ` Stefan Wahren
2019-02-18 12:30 ` Robin Murphy
2019-02-18 20:26 ` David Summers
2019-02-18 21:48 ` Stefan Wahren
2019-03-03 19:40 ` David Summers
2019-03-03 22:12 ` Tony McKahan
2019-02-17 12:15 ` [PATCH 3/3] ARM: dts: rk3288 Tinker Board (S) add bluetooth David Summers
2019-02-17 13:31 ` Tony McKahan
2019-02-17 21:05 ` Stefan Wahren
2019-02-18 20:47 ` David Summers
2019-02-18 21:40 ` Stefan Wahren
2019-03-03 20:15 ` David Summers
2019-02-23 19:42 ` [PATCH 0/3] ARM: dts: rk3288 Tinker Board (S) updates David Summers
2019-03-09 15:36 ` [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection David Summers
2019-03-09 15:39 ` David Summers
2019-03-09 15:39 ` [PATCH v3 2/3] arm: dts: rk3288-tinker.dtsi: Enable WiFi David Summers
2019-03-11 22:18 ` Robin Murphy
2019-03-12 20:41 ` David Summers
2019-03-12 20:55 ` Heiko Stübner
2019-03-12 14:18 ` Heiko Stuebner
2019-03-12 14:21 ` Stefan Wahren
2019-03-13 10:50 ` Heiko Stübner
2019-03-09 15:39 ` [PATCH v3 3/3] arm: dts: rk3288-tinker.dtsi: Add outline Bluetooth support David Summers
2019-03-11 16:41 ` Marcel Holtmann
2019-03-11 20:48 ` David Summers
2019-03-13 10:56 ` Heiko Stübner
2019-03-13 20:02 ` David Summers
2019-03-12 14:08 ` [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection Heiko Stuebner
2019-03-12 14:17 ` Robin Murphy
2019-03-12 14:22 ` Heiko Stuebner
2019-03-12 20:34 ` David Summers
2019-03-12 20:52 ` Heiko Stübner
2019-03-12 21:04 ` Jonas Karlman
2019-03-13 10:40 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3123627.puci4abFsC@diego \
--to=heiko@sntech.de \
--cc=beagleboard@davidjohnsummers.uk \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).