From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DFAC43381 for ; Wed, 13 Mar 2019 10:41:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 164142171F for ; Wed, 13 Mar 2019 10:41:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u+YFyO5Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 164142171F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vt2TRyiCG4+oBEDEe2ThRoZ52kOCK+g3Bz7kwaRBGfQ=; b=u+YFyO5ZYFQ5pi xGB1kHNH6qQ7PoDR7xIvuw/XF24fae16AS/NmlLPI9lwYrZhHBR8lHL6YGHkt5Z0Szlizk1NuMBV9 1P+f3gvW7TjBFo2uy7pFWn99OywK5KvmA8s13bJT2sM/b1H3juZJzq1400xKnvmApmeFkSuP/mWQw lXjIPLcv+xNy9ReC4SIapxRSvzMkpDGIaNVbZWkrlz60LY+PYFp4/4SDvYdVHda+UEBmKyhomdLfa w2+Goult+bSNFAGBKKrfmq9VXccbf9txpgqomeWoSM9b+jnpufvKqracaG9c6+DqttWmkCTyFFatY k13HyjWQwa8Dm+EBL47A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h41Jn-00061F-8A; Wed, 13 Mar 2019 10:41:03 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h41Jh-0005sA-GE; Wed, 13 Mar 2019 10:41:00 +0000 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1h41JV-0007uy-So; Wed, 13 Mar 2019 11:40:45 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: David Summers Subject: Re: [PATCH v3 1/3] arm: dts: rk3288-tinker.dtsi: Fix SD card detection Date: Wed, 13 Mar 2019 11:40:45 +0100 Message-ID: <3123627.puci4abFsC@diego> In-Reply-To: <20190309153923.22806-1-beagleboard@davidjohnsummers.uk> References: <20190217121513.22965-1-beagleboard@davidjohnsummers.uk> <20190309153923.22806-1-beagleboard@davidjohnsummers.uk> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_034057_711878_331412D7 X-CRM114-Status: GOOD ( 12.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, jh80.chung@samsung.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, frowand.list@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Samstag, 9. M=E4rz 2019, 16:39:21 CET schrieb David Summers: > The Problem: > = > On ASUS Tinker Board S, when booting from the eMMC, and there is card > in the sd slot, there are constant errors. > = > Also when warm reboot, uboot can not access the sd slot > = > Cause: > = > Identified by Robin Murphy @ ARM. The Card Detect on rk3288 > devices is pulled up by vccio-sd; so when the regulator powers this > off, card detect gives spurious errors. A second problem, is during > power down, vccio-sd apprears to be powered down. This causes a > problem when warm rebooting from the sd card. This was identified by > Jonas Karlman. > = > History: > = > A common fault on these rk3288 board, which impliment the reference > design. > = > When this arose before: > = > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-August/281153.= htm > l > = > And Ulf and Jaehoon clearly said this was a broken card detect design, > which should be solved via polling > = > Solution: > = > Hence broken-cd is set as a property. This cures the errors. The > powering down of vccio-sd during reboot is cured by adding > regulator-boot-on. > = > This solutions has been fairly widely reviewed and tested. > = > Signed-off-by: David Summers > Reviewed by: Robin Murphy > Reviewed by: Jonas Karlman > Test by: TheSaint @ ArchLinux Arm applied as fix for 5.1 with the following modifications: - new subject: "ARM: dts: rockchip: Fix SD card detection on rk3288-tinker" to match the subsystem - adapted Reviewed and Tested tags as collected from involved parties - added Fixes and Cc-stable tags (pointing to the dtsi-split only to ease load of stable maintainers, as hopefully most people will use somewhat recent kernels on sbcs] Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel