linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL 3/3] 2nd Round Samsung mach-exynos for v3.12
Date: Mon, 26 Aug 2013 12:06:48 +0200	[thread overview]
Message-ID: <3145165.ZB7l3vNJ7a@amdc1032> (raw)
In-Reply-To: <1f7701cea1f1$431f2d30$c95d8790$%kim@samsung.com>


Hi,

On Monday, August 26, 2013 09:14:42 AM Kukjin Kim wrote:
> The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092:
> 
>   Linux 3.11-rc1 (2013-07-14 15:18:27 -0700)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
> tags/samsung-mach-exynos
> 
> for you to fetch changes up to f52616f4233d71d0fb00f06f86d046d18d2b7f3b:
> 
>   ARM: EXYNOS: always enable PM domains support for EXYNOS4X12 (2013-08-19
> 05:05:16 +0900)
> 
> ----------------------------------------------------------------
> update mach-exynos
> - enable ARCH_HAS_BANDGAP for exynos SoCs
> - skip C1 cpuidle for exynos5440 because non-supporting
> - always enable PM domains for exynos4x12
> 
> ----------------------------------------------------------------
> Amit Daniel Kachhap (2):
>       ARM: EXYNOS: enable ARCH_HAS_BANDGAP
>       ARM: EXYNOS: Skip C1 cpuidle state for exynos5440

The patch "ARM: EXYNOS: Skip C1 cpuidle state for exynos5440":

--- a/arch/arm/mach-exynos/cpuidle.c
+++ b/arch/arm/mach-exynos/cpuidle.c
@@ -210,7 +210,7 @@ static int __init exynos4_init_cpuidle(void)
                device->cpu = cpu_id;
 
                /* Support IDLE only */
-               if (cpu_id != 0)
+               if (soc_is_exynos5440() || cpu_id != 0)
                        device->state_count = 1;
 
                ret = cpuidle_register_device(device);

is incorrect as noted a month ago in:

http://lists.infradead.org/pipermail/linux-arm-kernel/2013-July/186355.html

[ Because of the deficiency in the core cpuidle core (device->state_count
  not being used by governors' code) only sysfs entries for C1 state will be
  disabled and EXYNOS cpuidle driver will still attempt to use C1 state.

also non-working device->state_count is planned to be removed by:

http://permalink.gmane.org/gmane.linux.power-management.general/37390


To disable C1 state on EXYNOS5440 something like:

	static int __init exynos4_init_cpuidle(void)
	{
	...
		if (soc_is_exynos5440())
			exynos4_idle_driver.state_count = 1;
	...
	}

should be done instead.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

  reply	other threads:[~2013-08-26 10:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26  0:14 [GIT PULL 3/3] 2nd Round Samsung mach-exynos for v3.12 Kukjin Kim
2013-08-26 10:06 ` Bartlomiej Zolnierkiewicz [this message]
2013-08-26 11:03   ` amit daniel kachhap
2013-08-26 11:19     ` Bartlomiej Zolnierkiewicz
2013-08-26 11:52       ` Kukjin Kim
2013-08-26 13:51         ` Bartlomiej Zolnierkiewicz
2013-08-26 12:16       ` [PATCH V2] ARM: EXYNOS: cpuidle: Skip C1 cpuidle state for exynos5440 Amit Daniel Kachhap
2013-08-26 14:23         ` Bartlomiej Zolnierkiewicz
2013-08-26 12:18       ` [GIT PULL 3/3] 2nd Round Samsung mach-exynos for v3.12 amit daniel kachhap
2013-08-27  4:08         ` Kevin Hilman
2013-08-27 15:57           ` Kukjin Kim
2013-08-27 18:57             ` Olof Johansson
2013-08-27 23:33               ` Kukjin Kim
2013-08-27 23:34           ` [GIT PULL V2 3/3] 2nd Round Samsung mach-exynos-v2 " Kukjin Kim
2013-08-29 20:29             ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3145165.ZB7l3vNJ7a@amdc1032 \
    --to=b.zolnierkie@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).