From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM/PCI: move align_resource function pointer into pci_host_bridge structure
Date: Wed, 25 Nov 2015 20:55:49 +0100 [thread overview]
Message-ID: <3151909.Tqkjp0h634@wuerfel> (raw)
In-Reply-To: <20151125193201.GE8869@localhost>
On Wednesday 25 November 2015 13:32:01 Bjorn Helgaas wrote:
> On Wed, Nov 11, 2015 at 09:12:25AM +0800, Gabriele Paoloni wrote:
> > From: gabpao01 <gabriele.paoloni@huawei.com>
> >
> > commit b3a72384fe29 ("ARM/PCI: Replace
> > pci_sys_data->align_resource with global function pointer") has
> > introduced a global function pointer that makes the ARM specific
> > code not portable and broken in case any platform have a two
> > different HW IPs for the PCIe host bridge controller.
> > This patch moves align_resource function pointer into
> > pci_host_bridge structure so that the code is now suitable to be
> > reworked as we want to get rid of hw_pci structure (the host bridge
> > drivers can just set the align function pointer in the
> > pci_host_bridge structure) and there is no more broken code for a
> > SoC with two HW IPs.
> >
> > Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com>
>
> This looks good to me. I merged b3a72384fe29 so maybe it would make
> sense for me to merge this follow-up as well. I put it on my
> for-linus branch for v4.4.
>
> If you'd rather merge it via an ARM tree, here's my ack:
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> If you want me to merge it, an ARM ack would be nice. If you want to
> merge it, let me know and I'll drop it from my tree.
>
> > + /* Resource alignement requirements */
>
> s/alignement/alignment/
>
> > + resource_size_t (*align_resource)(struct pci_dev *dev,
> > ...
>
I was the one who asked for this change, so you can definitely have my
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
If Russell wants to take it through his tree, Gabriele can submit it
to http://www.arm.linux.org.uk/developer/patches/, otherwise I'd
suggest we merge it through your tree, as that was also the source
of the patch we are trying to fix up.
Arnd
prev parent reply other threads:[~2015-11-25 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 1:12 [PATCH] ARM/PCI: move align_resource function pointer into pci_host_bridge structure Gabriele Paoloni
2015-11-11 8:47 ` Arnd Bergmann
2015-11-11 10:09 ` Gabriele Paoloni
2015-11-25 19:32 ` Bjorn Helgaas
2015-11-25 19:55 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3151909.Tqkjp0h634@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox