From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B7C0C74A5B for ; Sun, 26 Mar 2023 18:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wdx6CGIBy3x5F5CgNpWpzX7AVk76uoP1z37C0kMX+sM=; b=tGGbb5T/eH7Jcc 65nT0w9/aR4jmy8p9b0Dwfl9+zAZQOHVFaXbr3lHYbBC3KPPGthPzRJJoPbaRP3EZ7Tbvay4BafBU d08+Kjife0HmP4gcWiQHxqkIoVAXFKQO8FsStoVh2IfcfJBpGKsE6LpKjbSThyKPhCWjgX9IE+O4Y 4DCkl/7Y04gXj8FOotDGQ/cVE3gOFlgXUL62NhmLgHrYaT3pv6f9C+Gf18qZygxv7m3Z518ma7eUW HMmvaIiCwC4JjtxFedFiW32ixDvtdl0GXCPP2P7FbK9KalKiOgQ/RLG8+OUuWuo+HXmHZEv7Ksh3F 9gsFKD5Ck4SrVANVy68Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgUwV-008yAJ-2H; Sun, 26 Mar 2023 18:18:11 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgUwS-008y9C-16 for linux-arm-kernel@lists.infradead.org; Sun, 26 Mar 2023 18:18:09 +0000 Received: by mail-ed1-x52d.google.com with SMTP id x3so26999224edb.10 for ; Sun, 26 Mar 2023 11:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679854687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F0z4RFfHMU2/2ypHnwqYv9UkrMQizv56zWHHQEZYoBs=; b=PBRl+QMRtnW+66ZegD3hEojjApkC581cvyTRGma0sYDQfntinWgs1WFyi3BoMyZznl AC1PqgI4mDH+MCe9RPzRUYKCJ6EyPiexunfThXwEa8Q37xTQhJIR1ydxBXtoEdRYx+3y rsg8fkZ31shhrtsniXcAzwv72wcqU2m3MfWTK+KumrEwNeyNIegPQ47dar1vtnRjitHP Dw0tbsgMflubVd1Fu03PP3bwte918kDg2UIrsmXNVGYd2PVjMlWaGZKcSejUT/M5ynfn GRfz9yw2e+ra97uVR5XofdOO5njFSSkdLsU1vu9RiYF/yJZDTt38XUeuBZUsEyFortyT AEqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679854687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F0z4RFfHMU2/2ypHnwqYv9UkrMQizv56zWHHQEZYoBs=; b=AyinrzBndzXEivKGDx17jOJmF77yQruevnGwSQmM/wXVwsdn8YO8MM5DkO85Yq44d5 m+Q0ozoVgNBYYTyRUvRyUK/cMVgcywDsTpyhat3n7dyWrsnoPlZN6s/ppgPQuXA00mvC Wqd9pWDA4LuWvSb8PdeBQD4kFaG0vtURD+LdhYVwx5NyVCw9rQCS2Jey17r2SyQPyp3S DfyaRQLSWEMIF8HYE07KqhasseWYFMEhKotquVWgfabzpf2OoDd252V+gdx+/Hoq6cuZ QnVV2cDrIPDqRVumzXg+Ul8hZ0VP91x7y74bWBBvbA+mUQP2biFasFiGUTZdy0a8SP8h aQoA== X-Gm-Message-State: AAQBX9d29focQe0UvJceSZ2wzyGMriR3Y8oi7gEdllq3TpTfg9FymG1m AApD9+Uub/cjaGB1q8/7ZPNr9Fvu9Cw= X-Google-Smtp-Source: AKy350bM+W0iHPGBqU64BeruoxvXdP0Tu5+EEI5wHVp4ul8K5rTA+zXmxhljNjruKkvq0osXCSY+dw== X-Received: by 2002:a17:907:3e09:b0:93e:82d1:9ae0 with SMTP id hp9-20020a1709073e0900b0093e82d19ae0mr9841254ejc.49.1679854686887; Sun, 26 Mar 2023 11:18:06 -0700 (PDT) Received: from kista.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id z1-20020a1709064e0100b00931baabe36csm13128167eju.63.2023.03.26.11.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Mar 2023 11:18:06 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Mauro Carvalho Chehab , Chen-Yu Tsai , Samuel Holland , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 083/117] media: sun8i_rotate: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 20:18:05 +0200 Message-ID: <3153045.5fSG56mABF@kista> In-Reply-To: <20230326143224.572654-86-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> <20230326143224.572654-86-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_111808_382330_6853AC3A X-CRM114-Status: GOOD ( 11.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 26. marec 2023 ob 16:31:50 CEST je Uwe Kleine-K=F6nig napisal(= a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel