From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5810CFC287 for ; Tue, 15 Oct 2024 11:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nwcOcLZwb7WFzyCEWIauRx9iuG6IhrcNwT+iRaz3qA4=; b=k3HVwA16r8gkVpBht+WE7CnPoN QU4x1qQnFOqrLxsOVcWzTy1uUYVmjJTTokDfqaGBJts37N8dQb0R7oo6DJR7XQfkD6Wf/lNXKEABx RFbfzcW7iRG6JC+SbTrYgEj15zstoDjO5fjyrvnsKnUwDcOu/OMogRFr0195WagogZaoa98eW93/W 7lxpwmkLzgkyfbiWAC0VruijTZpjB0TOCMnt+V/dV+G/mUMjj/PMtWREcDkgqZPkdihZI5xNazNxm tfGESuOdqortgRajqJSpte6d1ra5A79zAVLQ4aFyF3wwuOobqRzwkMAnlg+QBZIJkO8iRi3riehO1 hY5jfgaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0fKk-00000007wuF-300a; Tue, 15 Oct 2024 11:03:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0fDA-00000007vFA-420o for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2024 10:55:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E91261007; Tue, 15 Oct 2024 03:56:01 -0700 (PDT) Received: from [10.57.86.207] (unknown [10.57.86.207]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D9CC3F51B; Tue, 15 Oct 2024 03:55:28 -0700 (PDT) Message-ID: <315d4258-ea96-4008-8781-9205f41cec6c@arm.com> Date: Tue, 15 Oct 2024 11:55:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 03/57] mm/memcontrol: Fix seq_buf size to save memory when PAGE_SIZE is large Content-Language: en-GB To: Shakeel Butt Cc: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Greg Marsden , Ivan Ivanov , Johannes Weiner , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Michal Hocko , Miroslav Benes , Roman Gushchin , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-3-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241015_035533_085806_6C1A25FB X-CRM114-Status: GOOD ( 12.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/10/2024 20:59, Shakeel Butt wrote: > On Mon, Oct 14, 2024 at 11:58:10AM GMT, Ryan Roberts wrote: >> Previously the seq_buf used for accumulating the memory.stat output was >> sized at PAGE_SIZE. But the amount of output is invariant to PAGE_SIZE; >> If 4K is enough on a 4K page system, then it should also be enough on a >> 64K page system, so we can save 60K om the static buffer used in >> mem_cgroup_print_oom_meminfo(). Let's make it so. >> >> This also has the beneficial side effect of removing a place in the code >> that assumed PAGE_SIZE is a compile-time constant. So this helps our >> quest towards supporting boot-time page size selection. >> >> Signed-off-by: Ryan Roberts > > Acked-by: Shakeel Butt Thanks Shakeel and Johannes, for the acks. Given this patch is totally independent, I'll plan to resubmit it on its own and hopefully we can get it in independently of the rest of the series. Thanks, Ryan