From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D018FC4332F for ; Mon, 7 Nov 2022 21:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bU3vAMHSA7UiSX9EiOv/iCQYYL7IMCCkOPIwLCWQOHU=; b=gBEWLzMXGTgn6X fs5S4w/+jN9LMXnnXWpwZEFzxz7CNYHGtA5CB2LHMSVXGEMivuBh8USdDEumpJi1JKRskQEWXgLUD fNV7amCg4vWWKtZpcaNkAC462dtVO8bEWCoQvwYdzA7Lh0SHa4KZt3vpBFE4FrfrZel47nTbsv2+Z nT7OZVWpz3O1C4fAbK0D53GmtpwQZAxfdtccVrXi4ywv6k28VQWDG/idO7l0Pgbt5QLtrq++ULeZq VGLaguapGXYQw/Vtho41q2i9wpdqjFahgeblCvZ6XDE2yF9q2RRNSLU30Sgg5QdSWx/9lrkCEMy9O w5gcLxArmzz3BxK8dyWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1os9qY-000gEH-Uc; Mon, 07 Nov 2022 21:39:59 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1os9qW-000gCh-Ds for linux-arm-kernel@lists.infradead.org; Mon, 07 Nov 2022 21:39:57 +0000 Received: by mail-ej1-x62b.google.com with SMTP id t25so33687416ejb.8 for ; Mon, 07 Nov 2022 13:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gWppGLhyRbk0twcMAe1fFy3XdHnUGasdqpAlH5c197I=; b=BY8RcMc9oenknF5UieWwhxCKspnvAyK4KI638WUeKiYt+pUT1gsmRNZHw3ahjNFKPu SIFxyprUdLaoluN5Amon3TdTLLfVDr8QNivMgNSq1kNKM08nba9X194a24McafGI6XQ4 GdrjjoaPyr6+3W9V2fulejJCfmaenZTTmBOYcRsgoYa3dslyiK9YvGFRAjQCPD0BoGJS ZA3r14KVlBAOkDmOo+yM915L6g4rZjLGT2LvWUXQbmSsBbVsO7/J4YViDNh6WTcEVEBy uCDsOG+v+IKLHze7qN0q8PTQOSzgNGJGCR016ia3sZyrRkOTITnRCSYbYCLoD0gYtLws z8Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gWppGLhyRbk0twcMAe1fFy3XdHnUGasdqpAlH5c197I=; b=dQHzhnDzSWYFekNm02OWnyErEBcXJmwStfPwhI4CzlML9qaO9d/vx5cypG23m1xDMk zv8YW61zG84L5oy6ccrzpxcNK8QjQJxt6ADV5eqWrS+WcuLxi2PdLxmPffgPJUEjW8J2 Un/9tRozSF97PB3awPNYuVMeIxa6wwvgDVPyEdUnbQ5wXqilofzZVFSnQrIv39MXQGgZ c2W3jKx5tI0oKM1gn9fP8ad/xBWt3cCTZYJGnX7VhUzGG7+L48dor5Ve0dkfH0l5/Iv4 Aw4scEZZ3n6HEa5TPp6r7Zgq+xsNmp6DLhNNOwRyfjo0HPS5LpMTE/faX9EF02VZN00N kfmA== X-Gm-Message-State: ACrzQf0uZb52AdD1fxLVsQYS9laIAQfXudO59IXHYFY0uYH8Zu9o9LeK fSc0AF0uv0K0WSn7Uem6kpQ= X-Google-Smtp-Source: AMsMyM4Kv6wnMGpf32QajhqCSVNKnlD7xXpfKe/1VaxQW5a3xhNU78Ryn3zVFVJbmdzmzD/0FnxyWg== X-Received: by 2002:a17:907:3e01:b0:730:a690:a211 with SMTP id hp1-20020a1709073e0100b00730a690a211mr49594056ejc.596.1667857191997; Mon, 07 Nov 2022 13:39:51 -0800 (PST) Received: from kista.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id 1-20020a170906310100b00773c60c2129sm3954556ejx.141.2022.11.07.13.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 13:39:51 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Krzysztof Kozlowski , Renze Nicolai Cc: linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland Subject: Re: [PATCH v2] arm64: allwinner: a64: add device tree for SoPine with clusterboard Date: Mon, 07 Nov 2022 22:39:50 +0100 Message-ID: <3166097.AJdgDx1Vlc@kista> In-Reply-To: References: <334c5f69-2f25-aeb1-b87f-500cf2a6c205@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221107_133956_502202_9C3FC6EE X-CRM114-Status: GOOD ( 23.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 07. november 2022 ob 21:55:04 CET je Renze Nicolai napisal(a): > Hello Krzysztof, > > Thank you for your feedback! I've fixed the indentation and I've added > the compatible and model elements. You didn't document compatible in bindings as instructed by Krzysztof. That should be in a patch preceding this one. Comments like this, which are not part of commit message, should be either in cover letter or right below --- line, so they are ignored when patch is applied. While above comment can be considered as changelog of sort, it's preferred to write it as list, point by point, in area which is ignored when applying patch. I guess you don't use "git send-email" to send your patches? New versions should not be send in reply to old ones. > > Greetings, > Renze Nicolai > > > The Pine64 clusterboard needs a to have the tx delay changed to > 500ps for ethernet to work. This solution was described by multiple > people on the Pine64 forum years ago and nobody has submitted it. When you're adding new board, commit message should describe new board either by stating features or telling which board is similar and what are the differences. Something like that clusterboard is almost the same as baseboard except ethernet TX delay, which is 500 ps. Omit second part of second statement, it's not relevant. Best regards, Jernej > > Add a device tree for SoPine with the clusterboard. > > Signed-off-by: Renze Nicolai > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../allwinner/sun50i-a64-sopine-clusterboard.dts | 16 ++++++++++++++++ > 2 files changed, 17 insertions(+) > create mode 100644 > arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile > b/arch/arm64/boot/dts/allwinner/Makefile > index 6a96494a2e0a..15b011d1aaea 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -15,6 +15,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += > sun50i-a64-pinephone-1.2.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-pinetab-early-adopter.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-baseboard.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-sopine-clusterboard.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a64-teres-i.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-a100-allwinner-perf1.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h5-bananapi-m2-plus.dtb > diff --git > a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > new file mode 100644 > index 000000000000..f75325d43d76 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-clusterboard.dts > @@ -0,0 +1,16 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +// Copyright (c) 2022 Renze Nicolai > + > +/dts-v1/; > + > +#include "sun50i-a64-sopine-baseboard.dts" > + > +/ { > + model = "SoPine with clusterboard"; > + compatible = "pine64,sopine-clusterboard", "pine64,sopine", > + "allwinner,sun50i-a64"; > +}; > + > +&emac { > + allwinner,tx-delay-ps = <500>; > +}; > -- > 2.38.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel