From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1430AC433F5 for ; Sat, 9 Apr 2022 12:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5t3mltRNXIU/SHtH7n1XjqU9npeXTiORDLjWJ0PAsx8=; b=lLNObOv2SfhAxZ ujzS9TF+NJAHf5vEOcBF7/fGC0Jk/5N1zH0HFyvULxcB53mRKnEelxo+Bo8nmq7GMttwHsZcvJbd6 SlRvrfnUl47Bz9wVqTfJVqYDARFjuWZNRyInGq+S8I2ApkbdbLxu+FK1kzzOK8xL3ANnVC4Wm9NCU 1AnRsolQv4A7NzYxQwYiMfB8NWoN8wEuZNAQjAg689ZneNSgYM65mZzijARavhYbpftA9ZErzULkw H8wrWF1bhsny5syrRalLWd3G29iMDquYXrkeYwhgCHoZ5I5save8QkHxFvXh9MEUYnfqWKN3afQoI k1fw/uzjjqHvmpsfZplw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd9qJ-0030ud-3z; Sat, 09 Apr 2022 12:05:27 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd9qE-0030uG-JX for linux-arm-kernel@lists.infradead.org; Sat, 09 Apr 2022 12:05:24 +0000 Received: by mail-lj1-x22f.google.com with SMTP id b43so14498899ljr.10 for ; Sat, 09 Apr 2022 05:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W2x7AyNcYhIEBG1UmKMUkshHpXP5duVaX+ckIB7Pknc=; b=oDcgINnk2jyD0U8CLm/0OcaSGakbkbHo3g29WGv6P1ySWrKCbtf8Mzgu8cO35C3o9o gZzqbS+dsrzNeJX15IW1wv7InCZJ9k3YlbtJ5099e5YWG+HFTndI6wH6VGPuZy74MXQA 5GiSgf0pvG5G+R9m2UQxTUv211wOqNQ+keaBCUTT6od7WrxCrBt3YVpQTsYwc39y1Zfv +tn+pegxfSD4CfFkQsYZAdLUwH+vQ5QqnwanscqJkM0O7AIB5p/wmOac7u77ZokDBUAY rglO5DHkHapZrvUv/N5UxsSQOzHfPQx5N97phApaxvRGkdWgkPz9phl9Uv5IjZ/TiTmg Wzvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W2x7AyNcYhIEBG1UmKMUkshHpXP5duVaX+ckIB7Pknc=; b=yCyr3007kQ3Y6W+sIcfrPQL0/QKpOv5aYApHIc/+vJasQxaZf0cSvq+/TiY7N4l8iu 3DxdtqCfk6LzeXb8TG+zLwunbErwiQBRyOBu19CF4fEpT7JUcCm07qjXN7NNdZViF/kX stlkcDdoLOHN38TzP15ugocJgASCvv067qT0Kf8x4NXtimjnhjqAaeErWjtPwmgYHj6N YXA5q3gCv8p5/gQXaavGqYEjxEO9L8AHaF8+26qcU9sE26WzseX3tHin8A9usmqVmY5B 4bxPfmhZLKIYXrp7m5v/mYY5lUKnmx6aq9M2YuPzzq+b1EAGZRtGc+GhEUyeyA4lpVa+ eGRQ== X-Gm-Message-State: AOAM532hzTK0vyZL/wsqAXVJrz6maKO5TlWpyMG9DtmnO4otPJ0CUXYY 6j6k+BOlIzGjvxusZBW2VUU= X-Google-Smtp-Source: ABdhPJwohCyBIQ9FKP91KhNxmfu9p2W8y5D+PvVDKtklKR4QQK7p5gqLSq3fQOcrhmL2ZDGEZEXUDQ== X-Received: by 2002:a2e:86c4:0:b0:24b:54a2:cde with SMTP id n4-20020a2e86c4000000b0024b54a20cdemr3051850ljj.190.1649505919985; Sat, 09 Apr 2022 05:05:19 -0700 (PDT) Received: from dell.intranet (93-181-165-181.internetia.net.pl. [93.181.165.181]) by smtp.gmail.com with ESMTPSA id p24-20020a056512329800b0046b86c6dd49sm427829lfe.130.2022.04.09.05.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Apr 2022 05:05:19 -0700 (PDT) From: Janusz Krzysztofik To: Arnd Bergmann Cc: Tony Lindgren , Aaro Koskinen , Linux ARM , linux-omap , Janusz Krzysztofik Subject: Re: [PATCH v3] ARM: OMAP1: Prepare for conversion of OMAP1 clocks to CCF Date: Sat, 09 Apr 2022 14:05:17 +0200 Message-ID: <3167483.44csPzL39Z@dell> In-Reply-To: References: <20220402195155.141364-1-jmkrzyszt@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220409_050522_713896_9CF5D534 X-CRM114-Status: GOOD ( 26.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday, 5 April 2022 11:39:05 CEST Arnd Bergmann wrote: > On Sat, Apr 2, 2022 at 9:51 PM Janusz Krzysztofik wrote: > > > > In preparation for conversion of OMAP1 clocks to common clock framework, > > identify arch/arm/mach-omap1 local users of those clocks and update them > > to call clk_prepare_enable/clk_disable_unprepare() instead of just > > clk_enable/disable(), as required by CCF implementation of clock API. > > > > Users which reside under /drivers will be updated via separate patches, > > split out from v2 and already submitted. > > > > Signed-off-by: Janusz Krzysztofik > > --- > > arch/arm/mach-omap1/mcbsp.c | 8 ++++---- > > arch/arm/mach-omap1/ocpi.c | 4 ++-- > > arch/arm/mach-omap1/serial.c | 6 +++--- > > arch/arm/mach-omap1/timer32k.c | 2 +- > > 4 files changed, 10 insertions(+), 10 deletions(-) > > This all looks good to me. I have now rebased my omap1 multiplatform series > on the latest kernel and integrated some of your new work, see [1]. > > I have also finished up the multiplatform conversion for all other ARMv4T > and ARMv5 platforms and sent them out, hopefully we are getting into the > endgame with this. > > Are you able to test your CCF patches in combination with my series? > It would be great if we could get this all working in time for 5.19. > > Arnd > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=omap1-multiplatform-5.18 Your branch with my CCF patches on top of it works for me on my OMAP1510 based Amstrad Delta with the below fix: diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c index 8cafe7819e13..292fcb0a24fc 100644 --- a/drivers/video/fbdev/omap/omapfb_main.c +++ b/drivers/video/fbdev/omap/omapfb_main.c @@ -1623,7 +1623,7 @@ static int omapfb_do_probe(struct platform_device *pdev, init_state = 0; - if (pdev->num_resources != 1) { + if (pdev->num_resources != 2) { dev_err(&pdev->dev, "probed for an unknown device\n"); r = -ENODEV; goto cleanup; Amstrad Delta uses internal LCD controller, then the second IRQ (for sossi) is not needed, but your patch "fbdev: omap: pass irqs as resource" adds both to the array of omapfb resources and sets pdev->num_resources = 2. Thanks, Janusz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel