From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C016C433EF for ; Mon, 11 Apr 2022 15:39:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4zGfSwFu3RFMtWx9lL2/VERWz2UrFs+TYO/XhkYBFmY=; b=bQn00+VOEK0qQW bkNu2Dnmzlh6dGjgf8zJWqceWk5+1p4a7OWTMuPvkE8+LriIO/jCXqU/jBeBkNo/+4aAMoAc+xeti TQTlhdOoohyKfS/XcizDw3T4UJJo/PgwZ4/qcywOZ2A3lmHV8IHCn0lyFtX53E51J1SePZnwY9Xp0 ynEIDzZV/WXNe4Y1ctA9TSrbLpqaJntLEzkZclaXmo9Y8TRp9o/HqnU41sJtqIH6HjfpHQzmwZp4m +hyuSXzKPEzu4CHgEEMfPZJmL4Q4gSlh0+9Ry3L3f7BsyIxWhL3ewWFJylCGDJOJaH4XPSnZlCU2y kc+N3Bam6QxQyMe7duew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndw72-009chf-Om; Mon, 11 Apr 2022 15:37:56 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndw6z-009cgI-3k for linux-arm-kernel@lists.infradead.org; Mon, 11 Apr 2022 15:37:54 +0000 Received: by mail-wm1-x32e.google.com with SMTP id l62-20020a1c2541000000b0038e4570af2fso10306335wml.5 for ; Mon, 11 Apr 2022 08:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZEd2NUfggsD7hgjY8ZW9Vk2tNqqVUG6JADb5kDnjH9Y=; b=ZOQvmS/wEUkvWeynt1+EWEaVA+W9eMPHyQEiaRq21gFbWomCufcS8tUyh7ZQPu5LwP eUJ1WFpwyr9Yaqft68B8Nm/C+PGGHXUuTmGoF51iyzkF3siGBMH+JbPuJgnjBYZUQ0rk Rcab+BNrqtIDRdL1aduuV/rJWLG6C3gqZxMSNqkBpLnMkCujJoCI1LqQFlAqfyYnWPkC bvWQ6Pmc5eLqexEdzFrdr3CkHrDmtXhkSU7mjU3BvZHz1uqWYGghCI2eTSdTnMfEAzTC H/xVAOBg32rRcMvl5vxvcfb3LXbU80yq1DS9PzCV7iURoVOOuLaKzCbcU5eq/IECPn71 8chg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZEd2NUfggsD7hgjY8ZW9Vk2tNqqVUG6JADb5kDnjH9Y=; b=GeV7EQJa+Z8iP0xTxoIPaWFzUKc7IMFUjDadUpQRqmXrPtuUFfY0550eCN8HULkBLW QdWHqPoDClp533ttte2hGK3UAiWOY8amYvrjSbG9dsn2j2/d/0W+6YKv43LQ4Nrpn3OM mwXx0FugfBk/ijjuk8hGtHcSlh1KWNtMCbfhic7FJa/Nv2vtl8aAvt+TDUsyQr1CcmOC i7R+EwjgLICRrSlOB1zp/Vk+nxq10oCO2E2oyib2kqFAoz7ptWjbB/Rh38yB1buo1jjn juJV312++lmMhfdS9GHJj63lXIjP+vN9VwJ7amcICQ5+kUO62LdZd2cVHWMGIFntqrEZ fR8g== X-Gm-Message-State: AOAM531F7rbI2SfXuYQp+9rx7arHepWAIjxNBUnZg5LDtqWiE+6h17pU ze6Yb8QtiqCh2Yukj71KvRg= X-Google-Smtp-Source: ABdhPJy/BzuwObXpGrBkuPP/B+nIiUKgXHozXUMEVJpsQ9JEfJdCGxcjcG2VRWPpqzSHJ8PxH0l9YA== X-Received: by 2002:a7b:c7c3:0:b0:389:cbf1:fadf with SMTP id z3-20020a7bc7c3000000b00389cbf1fadfmr30248265wmk.147.1649691471387; Mon, 11 Apr 2022 08:37:51 -0700 (PDT) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id u23-20020a7bcb17000000b0037bdfa1665asm22528252wmj.18.2022.04.11.08.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 08:37:51 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Maxime Ripard , Samuel Holland Cc: Samuel Holland , Daniel Vetter , David Airlie , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 03/10] drm/sun4i: Remove obsolete references to PHYS_OFFSET Date: Mon, 11 Apr 2022 17:37:49 +0200 Message-ID: <3167527.44csPzL39Z@kista> In-Reply-To: <20220411043423.37333-4-samuel@sholland.org> References: <20220411043423.37333-1-samuel@sholland.org> <20220411043423.37333-4-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_083753_209050_7D71791E X-CRM114-Status: GOOD ( 21.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 11. april 2022 ob 06:34:15 CEST je Samuel Holland napisal(a): > commit b4bdc4fbf8d0 ("soc: sunxi: Deal with the MBUS DMA offsets in a > central place") added a platform device notifier that sets the DMA > offset for all of the display engine frontend and backend devices. > > The code applying the offset to DMA buffer physical addresses was then > removed from the backend driver in commit 756668ba682e ("drm/sun4i: > backend: Remove the MBUS quirks"), but the code subtracting PHYS_OFFSET > was left in the frontend driver. > > As a result, the offset was applied twice in the frontend driver. This > likely went unnoticed because it only affects specific configurations > (scaling or certain pixel formats) where the frontend is used, on boards > with both one of these older SoCs and more than 1 GB of DRAM. > > In addition, the references to PHYS_OFFSET prevent compiling the driver > on architectures where PHYS_OFFSET is not defined. > > Fixes: b4bdc4fbf8d0 ("soc: sunxi: Deal with the MBUS DMA offsets in a central place") > Signed-off-by: Samuel Holland Good catch! Actually, people complained about non-working display on Cubietruck IIRC, which has 2 GB of RAM. Did you test this on HW? Reviewed-by: Jernej Skrabec Best regards, Jernej > --- > > drivers/gpu/drm/sun4i/sun4i_frontend.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/sun4i/sun4i_frontend.c b/drivers/gpu/drm/sun4i/ sun4i_frontend.c > index 56ae38389db0..462fae73eae9 100644 > --- a/drivers/gpu/drm/sun4i/sun4i_frontend.c > +++ b/drivers/gpu/drm/sun4i/sun4i_frontend.c > @@ -222,13 +222,11 @@ void sun4i_frontend_update_buffer(struct sun4i_frontend *frontend, > > /* Set the physical address of the buffer in memory */ > paddr = drm_fb_cma_get_gem_addr(fb, state, 0); > - paddr -= PHYS_OFFSET; > DRM_DEBUG_DRIVER("Setting buffer #0 address to %pad\n", &paddr); > regmap_write(frontend->regs, SUN4I_FRONTEND_BUF_ADDR0_REG, paddr); > > if (fb->format->num_planes > 1) { > paddr = drm_fb_cma_get_gem_addr(fb, state, swap ? 2 : 1); > - paddr -= PHYS_OFFSET; > DRM_DEBUG_DRIVER("Setting buffer #1 address to %pad\n", &paddr); > regmap_write(frontend->regs, SUN4I_FRONTEND_BUF_ADDR1_REG, > paddr); > @@ -236,7 +234,6 @@ void sun4i_frontend_update_buffer(struct sun4i_frontend *frontend, > > if (fb->format->num_planes > 2) { > paddr = drm_fb_cma_get_gem_addr(fb, state, swap ? 1 : 2); > - paddr -= PHYS_OFFSET; > DRM_DEBUG_DRIVER("Setting buffer #2 address to %pad\n", &paddr); > regmap_write(frontend->regs, SUN4I_FRONTEND_BUF_ADDR2_REG, > paddr); > -- > 2.35.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel