From mboxrd@z Thu Jan 1 00:00:00 1970 From: t.figa@samsung.com (Tomasz Figa) Date: Tue, 23 Apr 2013 16:44:10 +0200 Subject: [PATCH v5 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs In-Reply-To: <51769ACC.4070706@samsung.com> References: <1366060483-20342-1-git-send-email-tomasz.figa@gmail.com> <51769ACC.4070706@samsung.com> Message-ID: <3174365.tBvafCFyal@amdc1227> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 23 of April 2013 23:29:32 Kukjin Kim wrote: > On 04/18/13 02:46, Rob Herring wrote: > >>>> + vic0: interrupt-controller at 71200000 { > >>> > >>> These nodes should be off a "simple-bus" node. > >> > >> Hmm, is there any reason behind it? > >> > >> I thought simple bus was just a convenient helper to represent > >> hierarchical > >> bus structures if one has a need to do so. > > > > No. The DT should reflect the bus structure of the chip. How > > accurately it is done is up to you and the information available, but > > you have to have a bus of some sort. > > > > There's obvious examples that don't follow this, but I'd like to not have > > more. > Tomasz, can you address comments? Please discard this series for now. I've decided to post it for 3.11, including a driver for Common Clock Framework and several cleanup patches, which I have ready and waiting. Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Kernel and System Framework