From: "Heiko Stübner" <heiko@sntech.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Vasily Khoruzhick <anarsoul@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Peter Geis <pgwipeout@gmail.com>, Andy Yan <andyshrk@163.com>,
Chris Morgan <macromorgan@hotmail.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Brian Norris <briannorris@chromium.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Andrew Lunn <andrew@lunn.ch>,
Michael Riesch <michael.riesch@wolfvision.net>,
Maya Matuszczyk <maccraft123mc@gmail.com>,
Chukun Pan <amadeus@jmu.edu.cn>,
Sascha Hauer <s.hauer@pengutronix.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Tianling Shen <cnsztl@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R5S
Date: Wed, 08 Mar 2023 17:31:36 +0100 [thread overview]
Message-ID: <3188745.AJdgDx1Vlc@diego> (raw)
In-Reply-To: <CA+E=qVepknVmYjC8+uxp+TUF=uqvm3t4rLk8yjs+h5zYm6HiSw@mail.gmail.com>
Am Mittwoch, 8. März 2023, 17:09:20 CET schrieb Vasily Khoruzhick:
> On Wed, Mar 8, 2023 at 3:31 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > index 35f74eda30ae..0813ad22dc76 100644
> > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > @@ -201,6 +201,11 @@ properties:
> > > - friendlyarm,nanopi-r4s-enterprise
> > > - const: rockchip,rk3399
> > >
> > > + - description: FriendlyElec NanoPi R5S board
> > > +
> >
> > Does not look like ordered alphabetically. Are you sure this is correct
> > place for it?
>
> Hmm, strictly speaking, "FriendlyElec NanoPi R5S board" should go in
> between of "FriendlyElec NanoPi R2S" and "FriendlyElec NanoPi4 series
> boards" if we want it in alphabetical order, not after "FriendlyElec
> NanoPi4 series boards" like in this patch. But it doesn't look nice
> (because R5S will go before R4S).
>
> There is already similar ordering (alphabetical/chronological for
> model) for Radxa Rock Pi - "Radxa ROCK Pi S", "Radxa Rock2 Square",
> "Radxa ROCK3 Model A", "Radxa ROCK 5 Model A".
>
> However if you want me to sort it strictly alphabetically, I can send a v2.
TL;DR: I think the entry is "just right" where it currently is :-)
- FriendlyElec NanoPi R2S
-> would become "FriendlyElec NanoPi2 series boards", _if_ there
will ever be some others
- FriendlyElec NanoPi R4S is included in the
"FriendlyElec NanoPi4 series boards"
and similarly the "FriendlyElec NanoPi R5S board" would become
"FriendlyElec NanoPi5 boards"
once they release more variants.
[Though we could get rid of the "board" in the current entry]
And judging by the amound of devices Pine64 did on the rk3568-base,
I guess it's fairly likely that FriendlyArm will release more in the future
as well, so the current position seems fitting.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-08 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 6:32 [PATCH 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R5S Vasily Khoruzhick
2023-03-08 6:32 ` [PATCH 2/2] arm64: dts: rockchip: rk3568: Add FriednlyElec Nanopi R5S Vasily Khoruzhick
2023-03-08 11:31 ` [PATCH 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R5S Krzysztof Kozlowski
2023-03-08 16:09 ` Vasily Khoruzhick
2023-03-08 16:31 ` Heiko Stübner [this message]
2023-03-08 17:38 ` Krzysztof Kozlowski
2023-03-15 7:54 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3188745.AJdgDx1Vlc@diego \
--to=heiko@sntech.de \
--cc=amadeus@jmu.edu.cn \
--cc=anarsoul@gmail.com \
--cc=andrew@lunn.ch \
--cc=andyshrk@163.com \
--cc=briannorris@chromium.org \
--cc=cnsztl@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).