* [PATCH] gpio: rcar: fix gpio_rcar_of_table
@ 2013-06-19 15:50 Arnd Bergmann
2013-06-20 0:50 ` Simon Horman
2013-06-20 8:05 ` Laurent Pinchart
0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2013-06-19 15:50 UTC (permalink / raw)
To: linux-arm-kernel
The device table needs to be terminated with an empty element.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Simon Horman <horms+renesas@verge.net.au>
---
I've just added this patch on top of the arm-soc next/drivers branch
that introduced the build warning.
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 5a693dd..f332753 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -437,6 +437,7 @@ static const struct of_device_id gpio_rcar_of_table[] = {
{
.compatible = "renesas,gpio-rcar",
},
+ { },
};
MODULE_DEVICE_TABLE(of, gpio_rcar_of_table);
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] gpio: rcar: fix gpio_rcar_of_table
2013-06-19 15:50 [PATCH] gpio: rcar: fix gpio_rcar_of_table Arnd Bergmann
@ 2013-06-20 0:50 ` Simon Horman
2013-06-20 10:19 ` Arnd Bergmann
2013-06-20 8:05 ` Laurent Pinchart
1 sibling, 1 reply; 5+ messages in thread
From: Simon Horman @ 2013-06-20 0:50 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 19, 2013 at 05:50:43PM +0200, Arnd Bergmann wrote:
> The device table needs to be terminated with an empty element.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> ---
> I've just added this patch on top of the arm-soc next/drivers branch
> that introduced the build warning.
Thanks, have you pushed it there or do I need to add it and
send a pull-request?
>
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 5a693dd..f332753 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -437,6 +437,7 @@ static const struct of_device_id gpio_rcar_of_table[] = {
> {
> .compatible = "renesas,gpio-rcar",
> },
> + { },
> };
>
> MODULE_DEVICE_TABLE(of, gpio_rcar_of_table);
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] gpio: rcar: fix gpio_rcar_of_table
2013-06-20 0:50 ` Simon Horman
@ 2013-06-20 10:19 ` Arnd Bergmann
2013-06-20 12:00 ` Simon Horman
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2013-06-20 10:19 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 20 June 2013, Simon Horman wrote:
>
> On Wed, Jun 19, 2013 at 05:50:43PM +0200, Arnd Bergmann wrote:
> > The device table needs to be terminated with an empty element.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Cc: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > I've just added this patch on top of the arm-soc next/drivers branch
> > that introduced the build warning.
>
> Thanks, have you pushed it there or do I need to add it and
> send a pull-request?
I've applied this directly.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] gpio: rcar: fix gpio_rcar_of_table
2013-06-20 10:19 ` Arnd Bergmann
@ 2013-06-20 12:00 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-06-20 12:00 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 20, 2013 at 12:19:25PM +0200, Arnd Bergmann wrote:
> On Thursday 20 June 2013, Simon Horman wrote:
> >
> > On Wed, Jun 19, 2013 at 05:50:43PM +0200, Arnd Bergmann wrote:
> > > The device table needs to be terminated with an empty element.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > Cc: Simon Horman <horms+renesas@verge.net.au>
> > > ---
> > > I've just added this patch on top of the arm-soc next/drivers branch
> > > that introduced the build warning.
> >
> > Thanks, have you pushed it there or do I need to add it and
> > send a pull-request?
>
> I've applied this directly.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] gpio: rcar: fix gpio_rcar_of_table
2013-06-19 15:50 [PATCH] gpio: rcar: fix gpio_rcar_of_table Arnd Bergmann
2013-06-20 0:50 ` Simon Horman
@ 2013-06-20 8:05 ` Laurent Pinchart
1 sibling, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-06-20 8:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
On Wednesday 19 June 2013 17:50:43 Arnd Bergmann wrote:
> The device table needs to be terminated with an empty element.
Oops, thanks for the patch.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> I've just added this patch on top of the arm-soc next/drivers branch
> that introduced the build warning.
>
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 5a693dd..f332753 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -437,6 +437,7 @@ static const struct of_device_id gpio_rcar_of_table[] =
> { {
> .compatible = "renesas,gpio-rcar",
> },
> + { },
> };
>
> MODULE_DEVICE_TABLE(of, gpio_rcar_of_table);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-20 12:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-19 15:50 [PATCH] gpio: rcar: fix gpio_rcar_of_table Arnd Bergmann
2013-06-20 0:50 ` Simon Horman
2013-06-20 10:19 ` Arnd Bergmann
2013-06-20 12:00 ` Simon Horman
2013-06-20 8:05 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox