From: Alexandre TORGUE <alexandre.torgue@foss.st.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>
Cc: Marek Vasut <marex@denx.de>, <devicetree@vger.kernel.org>,
Conor Dooley <conor+dt@kernel.org>, <kernel@pengutronix.de>,
<kernel@dh-electronics.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: stm32mp15x: Consolidate usbh_[eo]hci phy properties
Date: Thu, 14 Dec 2023 17:14:30 +0100 [thread overview]
Message-ID: <31a82fc0-814e-456d-83e2-a4daf111a648@foss.st.com> (raw)
In-Reply-To: <20231206084853.q4dfbp5twpe235se@pengutronix.de>
Hi Uwe
On 12/6/23 09:48, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Dec 06, 2023 at 09:31:43AM +0100, Uwe Kleine-König wrote:
>> diff --git a/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
>> index 511113f2e399..704c0d0cfe5f 100644
>> --- a/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
>> +++ b/arch/arm/boot/dts/st/stm32mp15xx-dkx.dtsi
>> @@ -680,8 +680,6 @@ &usart3 {
>> };
>>
>> &usbh_ehci {
>> - phys = <&usbphyc_port0>;
>> - status = "okay";
>
> the status property must be kept. I will wait a bit for further review
> and then resend (unless this patch is picked up with this issue fixed
> up).
Applied with the fix. First I had a small doubt about the patch as we
can also choose usbphyc_port1 for USB host but as usbphyc_port0 remains
always connected to the USB host then your patch makes completely sens.
Regards
Alex
> Best regards
> Uwe
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-14 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 8:31 [PATCH] ARM: dts: stm32mp15x: Consolidate usbh_[eo]hci phy properties Uwe Kleine-König
2023-12-06 8:48 ` Uwe Kleine-König
2023-12-14 16:14 ` Alexandre TORGUE [this message]
2023-12-15 8:23 ` [Linux-stm32] " Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31a82fc0-814e-456d-83e2-a4daf111a648@foss.st.com \
--to=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@dh-electronics.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marex@denx.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).