From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6C2DC4725D for ; Fri, 19 Jan 2024 17:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c9TxgJ7XcxR1cDSVNOV97MlgyQ2+69v3/53ZwosTvYw=; b=S+F2SK2DzV3luP DuEolQfH2OLTbCOK2Xfm/IfN2HEY3abcKDYKf2ivLT9Iid5FLItsaSz3rwg4WiEfObF2PJI+DKKI/ 1BKpss/TpmVagee1AFNS4x+lB1PuanFJ4zYY3UWUFn8HWctxsEHcRtEQeYB0J7uy17vDaA+tDdqne wYI4w9wMPhZRnHkMSCnodSmHxrP4vizNc2joKjIRtAyzsLhOsVMrQoZoHBOUrb0Oe9WZVvzxw46ZN aTj4matA9DHCVyEOLUDG+EGKFUC2xSYPUX/7DZe/dfT87nwB3F/D23YqVcGYHVpMjoBlUkxwNRaRv d45l+QV6zGVm1x39to5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQsFY-006CSt-2T; Fri, 19 Jan 2024 17:01:48 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQsFV-006CSG-20; Fri, 19 Jan 2024 17:01:47 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6628760008; Fri, 19 Jan 2024 17:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1705683698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eVdcjZzigbSsBwmQGgrwuVfPvylwPhfnV7FRBwbX2os=; b=n5Ys6O1a3pgFCD8YPEUweyidUInNABWxqlfLFXid906sTYe60ORvrlbK71CBI/isWeSzOn bAJZB48SCZkaCy9IZUrW0gzUBsB+RqFunoD5ps9A3m1I2jeEiVpTmZLudBp9Pcb4asmMWY NHMtmXg7wIHSoS6+BWV8qu4wJNhKLPJ8B87VkQd5BjefZ2ZuMnXsAP+0y8c+fmbzp+yEG5 bw/R/xpdxdvtVzf7gdyey4cBWrQclUNI4U1nSLKOh2tjtre/PiK8Vsnw3l10nkVUp5hlDf GMNYIsamhO2Xv3ZeBmLJvyKpy9JyUf2jfZ7mDmgdt0eehFhUNHQs9hTxKH5rWg== Message-ID: <31c42f08-7d5e-4b91-87e9-bfc7e2cfdefe@bootlin.com> Date: Fri, 19 Jan 2024 18:01:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/14] gpio: pca953x: move suspend/resume to suspend_noirq/resume_noirq Content-Language: en-US To: Tony Lindgren Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Tom Joseph , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com References: <20240102-j7200-pcie-s2r-v1-0-84e55da52400@bootlin.com> <20240102-j7200-pcie-s2r-v1-1-84e55da52400@bootlin.com> <20240116074333.GO5185@atomide.com> From: Thomas Richard In-Reply-To: <20240116074333.GO5185@atomide.com> X-GND-Sasl: thomas.richard@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240119_090145_945366_E3B7A3F0 X-CRM114-Status: UNSURE ( 9.05 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Tony, On 1/16/24 08:43, Tony Lindgren wrote: > * Thomas Richard [240115 16:16]: >> Some IOs can be needed during suspend_noirq/resume_noirq. >> So move suspend/resume callbacks to noirq. > > So have you checked that the pca953x_save_context() and restore works > this way? There's i2c traffic and regulators may sleep.. I wonder if > you instead just need to leave gpio-pca953x enabled in some cases > instead? > Yes I tested it, and it works (with my setup). But this patch may have an impact for other people. How could I leave it enabled in some cases ? Regards, -- Thomas Richard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel