From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 759B4C10F11 for ; Mon, 22 Apr 2019 11:45:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36E6D20881 for ; Mon, 22 Apr 2019 11:45:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jlnQe743"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="T4yJLfC+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36E6D20881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VPi8gmcDPu1BLMiyJvB3Ml+Ee7siwmNytR4OkKG/yv0=; b=jlnQe743mlIClS RiXbOlqvQbDIOMiJZ+pyUqFpuNNHSAHExU+Dq6/a87P8xSip4dqfpD1O81tDGL09Tm4KNgxDyymD/ 67vx9icqwUHjvOW0RfjAVq/pO/+uvwa9MS9NX9tEsboOII4TOFKxJc3sCn8mWBidto0Gkc81JfP3V Yv4HlRBKZqZULcV/Juc48DBF6VJM/n1ANehGGk3NhhWXfdXHFucLi5FF6cbZAg3XMKdDTuTrntwSu wx5sgEIOJrRs2NoC8uAKTqJ/eWRVdHCyU1e2rAinN5PZVdhDC1iCfWdcV04fMXBgtYtE+4OZPUxFP C9iBCMTaCk6la1UCZRTQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIXNc-00029A-Bx; Mon, 22 Apr 2019 11:45:00 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIXNY-00028D-PO for linux-arm-kernel@lists.infradead.org; Mon, 22 Apr 2019 11:44:58 +0000 Received: by mail-wm1-x342.google.com with SMTP id v14so14204457wmf.2 for ; Mon, 22 Apr 2019 04:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3YIh3hHvBZ7BaXs+3YAwERcSnfSNsChZK/sbht0VfxE=; b=T4yJLfC+kupU+qX7A3pI0xLYFwwzOVUlLOy1JRy/Kz0QbEM3erk4k4Hnr5dY0ONEMb hCKzyMx8XcTNLO8jVVegbvRn16ZoH82lGgBOw7pkuWycPlY2Opc7NY0NvWeCsk156bfD J+0Qt3E4CPZLIF72HYuGI9xvf4/VCBYOK/aaUocEuVX6fucqMGEHdoKKEYHx8ePRoIlb MvYM9ED0p4vfCc7S7TvIU+fgSyyvEQj+T2il00NkwmEj0EDrHlD4wo65oWHBkc5fYO6l Frfl9llzsUhv/nbSyZuLJIaISgv5pZYBQ9KLVaRzZqyxHLtYKxRqCQYt2MQwJKCc7MBA +w2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3YIh3hHvBZ7BaXs+3YAwERcSnfSNsChZK/sbht0VfxE=; b=UI0YYjyvt9B2kPE03Uh1BxEyU7UYwJDlsCjfvhcyyuVGGQqsoL6Pm6iBb0W+rmegY5 e8ovVQocwHQgqAMsxn1Zz1XWIUR7kwdUzrHKRMnpY1hU/qqkk0gJBY+b5znFnKyd0CL7 6MzUu0oz9WF0gXXS1pvXW+75ovsBILg+0EX5FxQUXHU4vSfG5vDjNh1DFbdgFG+HUpwd 360eq1e0x+Zi8o10b2sDpAdNH2ev3GncsEg6WYg/Wh7EvBYvEn+StcNYrSHojZZyh4i+ xcyO+m6pseSejpoOjDJEKZJp/uBAfCgc4uXIAiwRdHH6D8KB4LPBKrfI5lG5q9rulWIL tbqA== X-Gm-Message-State: APjAAAWEYscdwU0Jns5pwFPf2leTP38SPU1S4bfK/cigGHjgTtRWk6dh Mzh+jLZV9iv7T4SgfGUULjqw5A== X-Google-Smtp-Source: APXvYqxyn2cRm1w2onk1AW+e9B4V01SSiNFGLHUlwiQTvPsQP2i4/ep+XIFIcV5pM9vTbWyQANsxxA== X-Received: by 2002:a1c:cf83:: with SMTP id f125mr11168607wmg.96.1555933493626; Mon, 22 Apr 2019 04:44:53 -0700 (PDT) Received: from [192.168.1.2] (200.red-83-34-200.dynamicip.rima-tde.net. [83.34.200.200]) by smtp.gmail.com with ESMTPSA id h8sm10913684wrx.45.2019.04.22.04.44.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Apr 2019 04:44:52 -0700 (PDT) Subject: Re: [PATCH v2 05/14] clk: qcom: apcs-msm8916: get parent clock names from DT To: Stephen Boyd , andy.gross@linaro.org, arnd@arndb.de, bjorn.andersson@linaro.org, david.brown@linaro.org, enric.balletbo@collabora.com, heiko@sntech.de, horms+renesas@verge.net.au, jagan@amarulasolutions.com, jassisinghbrar@gmail.com, mark.rutland@arm.com, mturquette@baylibre.com, olof@lixom.net, robh+dt@kernel.org, sibis@codeaurora.org, will.deacon@arm.com References: <1548700381-22376-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <1548700381-22376-6-git-send-email-jorge.ramirez-ortiz@linaro.org> <155085910216.77512.12604271825136479370@swboyd.mtv.corp.google.com> From: Jorge Ramirez Message-ID: <31e17283-c374-f16e-df95-09aaf1854435@linaro.org> Date: Mon, 22 Apr 2019 13:44:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <155085910216.77512.12604271825136479370@swboyd.mtv.corp.google.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190422_044456_855286_48EB62C5 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, khasim.mohammed@linaro.org, linux-kernel@vger.kernel.org, amit.kucheria@linaro.org, linux-clk@vger.kernel.org, vkoul@kernel.org, niklas.cassel@linaro.org, georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/22/19 19:11, Stephen Boyd wrote: > Quoting Jorge Ramirez-Ortiz (2019-01-28 10:32:52) >> @@ -61,6 +65,25 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev) >> if (!a53cc) >> return -ENOMEM; >> >> + /* check if the parent names are present in the device tree */ > > This looks odd. > >> + ret = devm_clk_bulk_get(parent, ARRAY_SIZE(pclks), pclks); >> + if (ret == -EPROBE_DEFER) >> + return ret; > > Why can't we use of_clk_parent_fill() if we know this is always a DT > platform? The parent clks may not be registered at the time of probe? yes, and AFAICS the important thing at this point is that the clock is registered hence the handling of defer. I could use of_clk_parent_fill and then - if needed - call devm_clk_bulk_get but I am not sure of the gains of doing it (wouldnt this just make the code more confusing?) > Maybe this series should wait for the parent registration stuff I'm > working on so that this can be made simpler. the need for the clock name is not intrinsic to this driver (the driver itself doesnt use these names) but it just feeds these to the framework. I was looking into your parent registration code and I am not sure how can I use it in this particular driver other than simply removing the names and hoping that things are handled properly at the lower levels.... could you clarify please? > >> + >> + if (!ret) { >> + gpll0_a53cc[0] = __clk_get_name(pclks[0].clk); >> + gpll0_a53cc[1] = __clk_get_name(pclks[1].clk); >> + a53cc->pclk = pclks[1].clk; >> + } else { >> + /* support old binding where only pll was explicitily defined */ >> + a53cc->pclk = devm_clk_get(parent, NULL); >> + if (IS_ERR(a53cc->pclk)) { >> + ret = PTR_ERR(a53cc->pclk); >> + dev_err(dev, "failed to get clk: %d\n", ret); >> + return ret; >> + } >> + } >> + >> init.name = "a53mux"; >> init.parent_names = gpll0_a53cc; >> init.num_parents = ARRAY_SIZE(gpll0_a53cc); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel