From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65DA5C433F5 for ; Wed, 30 Mar 2022 16:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0W7PHmaZTgZCZmxHhWFYZ1id72WNS9ReQ4y3SrZVBxc=; b=iMMB9Q92NNaMkp jB1Xe4P0AoCBjrY5SHmepQdKmmf6OmvfjgtgTtMp8ov8PaggsFy7/YUTCihhgVrsCNRbOPF8G5Wuw A78yOx033PCn7WzOsAMagyLbJT9MoqjtmYvglKJEFtZMW1wwO//HJ14OcSJR48ynNRLq72j7+5tKo atQ6vd11PtVNdrvoqCT/OYAozJBszLGsx2JRrXkaeSTFNhcxLeNs25igBSiCSsISDYBek/LKCN7rh /QMaACnXZmV9zgBo/jrq7JUrWaSpBPFr/YQLVvwC8gk7rTTzaountUrJxGbnw+AAE9/qpGyJKrrfo NtDY2TDz/y2WQfbBnafA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZbSs-00GsBL-Jp; Wed, 30 Mar 2022 16:46:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZbSj-00Gs7n-P0 for linux-arm-kernel@lists.infradead.org; Wed, 30 Mar 2022 16:46:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC5341576; Wed, 30 Mar 2022 09:46:22 -0700 (PDT) Received: from [10.57.8.120] (unknown [10.57.8.120]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 07EAF3F66F; Wed, 30 Mar 2022 09:46:20 -0700 (PDT) Message-ID: <31fe187d-3997-73b7-3dfe-ded740e70567@arm.com> Date: Wed, 30 Mar 2022 17:46:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 21/22] firmware: arm_scmi: Add SCMI v3.1 Perf power-cost in microwatts Content-Language: en-US To: Cristian Marussi Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220330150551.2573938-1-cristian.marussi@arm.com> <20220330150551.2573938-22-cristian.marussi@arm.com> From: Lukasz Luba In-Reply-To: <20220330150551.2573938-22-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220330_094625_976964_F81BCAA3 X-CRM114-Status: GOOD ( 15.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/30/22 16:05, Cristian Marussi wrote: > Add SCMIv3.1 internal support for parsing message attributes reporting > the capability of a performance domain to report power-cost in microwatts. > > Cc: Lukasz Luba > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/perf.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c > index e1aa0ed67971..65ffda5495d6 100644 > --- a/drivers/firmware/arm_scmi/perf.c > +++ b/drivers/firmware/arm_scmi/perf.c > @@ -45,6 +45,7 @@ struct scmi_msg_resp_perf_attributes { > __le16 num_domains; > __le16 flags; > #define POWER_SCALE_IN_MILLIWATT(x) ((x) & BIT(0)) > +#define POWER_SCALE_IN_MICROWATT(x) ((x) & BIT(1)) > __le32 stats_addr_low; > __le32 stats_addr_high; > __le32 stats_size; > @@ -170,6 +171,7 @@ struct scmi_perf_info { > u32 version; > int num_domains; > bool power_scale_mw; > + bool power_scale_uw; > u64 stats_addr; > u32 stats_size; > struct perf_dom_info *dom_info; > @@ -200,6 +202,8 @@ static int scmi_perf_attributes_get(const struct scmi_protocol_handle *ph, > > pi->num_domains = le16_to_cpu(attr->num_domains); > pi->power_scale_mw = POWER_SCALE_IN_MILLIWATT(flags); > + if (PROTOCOL_REV_MAJOR(pi->version) >= 0x3) > + pi->power_scale_uw = POWER_SCALE_IN_MICROWATT(flags); > pi->stats_addr = le32_to_cpu(attr->stats_addr_low) | > (u64)le32_to_cpu(attr->stats_addr_high) << 32; > pi->stats_size = le32_to_cpu(attr->stats_size); LGTM, Reviewed-by: Lukasz Luba I'll send a follow-up patch which is using this information when this patch gets into linux-next. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel