From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85A45C4706C for ; Tue, 9 Jan 2024 20:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ml0ZCrAU03ByoBba3/6rukq5eySkwmZjk2T/t9u00y8=; b=Jse7aDqrhzKw0z svOf12IqNpKO+I2i1WHcbnDezbkCR9kPkBauXJA9fc+kbpPGIyJRJrNs1BAmVCPypH03F+orB2DX4 XCfvOs9YZZ59BpbTmmAwZhU13G9ftjpviGpX5c7BrBNk4aJ70lv1ryCA/v5LhSVBgNgGB2szXrJwQ u8GeryK2rcgnSl5k6Ld6R9NcY7xFXDngmoDRHDxPBY9nazyjMm3NPzy6xjKAKmXAYJ8X2mwJTDlRc LxmAVSh0MvirO0Fh+vl15FKMeee+qP1oOYre+Sydq69K98/D7zpdoBq9jQPZamIMST83GzNaLpAHy 2rYb6lOywQEJFLc5o2qA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNIZo-009R5d-1O; Tue, 09 Jan 2024 20:19:56 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNIZl-009R55-1a for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2024 20:19:55 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40d60c49ee7so38647225e9.0 for ; Tue, 09 Jan 2024 12:19:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704831592; x=1705436392; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=DlYxPCHAYd6STqeLclpo+vdtfpOUSl4elB7ysJ3G/b8=; b=ISlFnbOc1qR0kmz/DAxIc5Y7e0MjHbDNehtJmFtqzGDN8F2VbbEa+rbkyLDoYpDhhL 48SJoWcAGN+meJJuRv0AVt8/MXySvZ8+FzZOBf48w1q0YTTOrxVdKvNzVSxHVG+mAprx KtrignzuasJfKcn8ENnuW71OaHQEE6nsoTMRZ07Xai/HX+4iV6tkBIXeCBWyCjosq6vv wqGWcvDFRQ89FiYJEWoubKRncBmiYNFUZeACBdkUS5z0pduVG/KAZwp4/nDIAGl2Qgzd 6hycuzu+5kU3E0chjEFJX9aGaxbR4mMw2lqGoBGza3pXFjhQQXuMkHPqjgLvaSHYfRdg iarw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704831592; x=1705436392; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DlYxPCHAYd6STqeLclpo+vdtfpOUSl4elB7ysJ3G/b8=; b=md6JF9HTFdahL/Hyc6VsN6vQMMLtNWlTT1yRCsdJxRBgIxRjE8DBVqqadRWYTtRM7n mOW4DNiHcmDepl4qyyCu8c6WZVCB6fd8tMpmEiDsH7N/jf/N91DsttzQjg4oN+7EcNaO ge/61sU7i3hjLEFdPTI1ukka4Lpz1kBUSM3IkD7V+aSeo9pGGol/K1ae1MdDNP3C+QJA 3rFCh7lBYg8Fox/U4rNXLSy/LnZ1Al3zyECkbSisLgA6tAP+yKu54NtVCA61RBBY6peD LTiC4fqNJrBRdH02Pf6HiJnHSZewkHnuIY9qgy+GCQeHoYT+BEDDbqAbR4cAAUlcSd7g vXhg== X-Gm-Message-State: AOJu0YxkbaVjHF+EMGAOZaNeMcrX+xOc+8ocR5ac6JhzzqsF52T6Gjta x8uYMuxxBkxxY0noUZSSozAVOWNG/z8= X-Google-Smtp-Source: AGHT+IG1OMh03D58GI/XQbXMBGYnExJPieRU875c4MCxuqXF5c3yyX/E2Wz0vuSvYaovhTFRA8ZM/Q== X-Received: by 2002:a05:600c:205a:b0:40e:46e1:e3e9 with SMTP id p26-20020a05600c205a00b0040e46e1e3e9mr1923451wmg.122.1704831591554; Tue, 09 Jan 2024 12:19:51 -0800 (PST) Received: from jernej-laptop.localnet (213-161-3-116.dynamic.telemach.net. [213.161.3.116]) by smtp.gmail.com with ESMTPSA id n33-20020a05600c3ba100b0040e398f8cafsm4740297wms.31.2024.01.09.12.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 12:19:51 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Lee Jones , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Andre Przywara , Jianzhang Mai Subject: Re: [PATCH] mfd: sun4i-gpadc: adaptation interrupt number Date: Tue, 09 Jan 2024 21:19:48 +0100 Message-ID: <3201556.5fSG56mABF@jernej-laptop> In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240109_121953_546004_B309BB79 X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 27. december 2023 ob 03:01:17 CET je Fuyao Kashizuku napisal(a): > The identifiers are used as IRQ resource numbers, where 0 is treated > specially. > > This fixes sun4i-gpadc-iio probe failed when request irq. > > The backstack: > WARNING: CPU: 3 PID: 1 at drivers/base/platform.c:451 > __platform_get_irq_byname+0xb8/0xc4 > 0 is an invalid IRQ number > Modules linked in: > CPU: 3 PID: 1 Comm: swapper/0 Not tainted 6.7.0-rc6 #9 > Hardware name: Allwinner sun8i Family > unwind_backtrace > show_stack > dump_stack_lvl > __warn > warn_slowpath_fmt > __platform_get_irq_byname > platform_get_irq_byname > sun4i_irq_init > sun4i_gpadc_probe > platform_probe > really_probe > __driver_probe_device > driver_probe_device > __driver_attach > bus_for_each_dev > bus_add_driver > driver_register > do_one_initcall > do_initcall_level > do_initcalls > kernel_init_freeable > kernel_init > > Log reports: > sun4i-gpadc-iio sun6i-a31-gpadc-iio.0: error -EINVAL: IRQ FIFO_DATA_PENDING > not found > sun4i-gpadc-iio: probe of sun6i-a31-gpadc-iio.0 failed with error -22 > > Signed-off-by: Fuyao Kashizuku Acked-by: Jernej Skrabec Best regards, Jernej > --- > Changes in v2: > - Fix the commit message. > - Add the backstack. > - Add the log reports. > - Use the correct full name and email address. > - Correct the subsystem to mfd. > - Link to v1: https://lore.kernel.org/lkml/YwdhTlk+9h+9Mrwm@scg/ > > include/linux/mfd/sun4i-gpadc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h > index ea0ccf33a459..021f820f9d52 100644 > --- a/include/linux/mfd/sun4i-gpadc.h > +++ b/include/linux/mfd/sun4i-gpadc.h > @@ -81,8 +81,8 @@ > #define SUN4I_GPADC_TEMP_DATA 0x20 > #define SUN4I_GPADC_DATA 0x24 > > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 > > /* 10s delay before suspending the IP */ > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel