From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: bcm2835: remove unused __packet
Date: Mon, 13 Jun 2016 17:55:12 +0200 [thread overview]
Message-ID: <3205257.80lYkVfUux@wuerfel> (raw)
In-Reply-To: <1465321773-21519-1-git-send-email-ben.dooks@codethink.co.uk>
On Tuesday, June 7, 2016 6:49:33 PM CEST Ben Dooks wrote:
> The driver defines a variable called __packet but then never
> uses it, and does not export it for others to use either. Fix
> the warning about undeclared variable by removing it.
>
> drivers/soc/bcm/raspberrypi-power.c:48:3: warning: symbol '__packet' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
The patch looks good, but it's probably worth mentioning here that
this was intended to be the '__packed' attribute instead of a local
variable. The attribute is useless here, as the variables both
still get the default stack alignment, even if rpi_firmware_property
only requires byte-aligned data.
Arnd
> diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
> index fe96a8b..f7ed118 100644
> --- a/drivers/soc/bcm/raspberrypi-power.c
> +++ b/drivers/soc/bcm/raspberrypi-power.c
> @@ -45,7 +45,7 @@ struct rpi_power_domains {
> struct rpi_power_domain_packet {
> u32 domain;
> u32 on;
> -} __packet;
> +};
>
prev parent reply other threads:[~2016-06-13 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 17:49 [PATCH] ARM: bcm2835: remove unused __packet Ben Dooks
2016-06-07 20:30 ` Eric Anholt
2016-06-10 22:11 ` Kevin Hilman
2016-06-13 15:55 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3205257.80lYkVfUux@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox