From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BBB1C433EF for ; Thu, 26 May 2022 12:13:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vJO8VtkNa8mGRowOXUmd0RS9qkedJmK0vNw7xjbxsrk=; b=4410PseBpCI7uU XBXZDYVqSjR60FfkGJcG4DvxS/gQHmuiDjdBskow4EVPAxhKtRix/jKsSq3C6K96RbZ217o/9/sox laVrC0aOYAXHIh6sDEnlxrCOll3LH541qs+Anh3C5uDCeXT6mKsYRd2fxawQjKTwCAULRe9NE2qM1 8cmOGcvhWn19Efwr7LJs4XBK4x13VRcjfGW0iu22tqlbPNTkVVRw8Blqzod8vqpj9vUc7GG2+jIIw QzQSLKJImCM1wHx+5wAieWScFF9PsXpxbF6ez25b6LYGK/8pDEwD1Tr55S10aFf8lY9AEBTgsILZu DDwIHz0npfJ6/G7eEQMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuCLD-00Em28-U9; Thu, 26 May 2022 12:11:48 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuCLA-00Em0h-Qe for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 12:11:46 +0000 Received: by mail-ed1-x52f.google.com with SMTP id fd25so1576479edb.3 for ; Thu, 26 May 2022 05:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=sXHp14NNalgqPaKL7fFgyP/4BdJ+vF73UOPZDrXfEbU=; b=FGwLjy7oS+OIxxTDnvLctd0ph6xYVfo9FHwpZa0nZL9tKTfGKLDaBLD2pgvAlHvsSO 6+YLNbhFsfrMUNXNQxqtzm3DgEK4LOOTzzATAJrKJsO8czXDovltiJKZddYVbl5z5sVu Cgr7SW5TSLSVGrIpy7bAoLTAn0aaQXJRTfJbJ6D0xGbzEhYxN0vAXpP0PduCOthjh7Qx 1Lp5YIborDM4hz1c22ERtTfDyt8uAJgCEfX7qBL5icCGLa4M7HZxCshuadE5teTSPbzv fuRYIQg7n/5kW8y1p8Vct+9Z2GLEaQDIIdJa1zZSDJyK9jhwtjFdxn369U1N2ewN68hc zZUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=sXHp14NNalgqPaKL7fFgyP/4BdJ+vF73UOPZDrXfEbU=; b=ZJI8kVQsOW+tdl2CpN5YMx/3RfXEzkXWYmAaXT4D643TVJPZRl0hGaYCUTmy0j/mjg XdPrHUP0R0sfD/ya10sVQ14riiKUFJLjmP/d+Dg0Uxmvv83vniV7H0efsdL7681EKlS9 y8spyZfrAYibj1edJevIKqNeJYtdZL2mF8S4KczMV64ZKPJ2Hay7KnoNaLJYg4KUPE5o 8FNdm/mIykiT9/lvb26rMfJ3oco21lkrOenmft+yEI6DtuETAZRAesvnpV/ZOpU9mf+H 1EQQAOgIDVkeP+7RO8xSb7os8qgOMFEQgSsl6FkH+GJd36BjlKAnNyPCj2iLLL0upWNz tdXw== X-Gm-Message-State: AOAM533xzPnJMQR8NBJzb2CnpndHzbmtGgi508y2o60T51eKqrrSOG3E Y2MmYRdogLLGVh5aY2V239s04w== X-Google-Smtp-Source: ABdhPJxKtLDaqitsHZgj8YIb7tPwvHNZlr+rERVc0m5szUCbZxJUM9dMruOloFZQvWNGezIeQY6/EA== X-Received: by 2002:aa7:c79a:0:b0:42a:762e:769c with SMTP id n26-20020aa7c79a000000b0042a762e769cmr39520806eds.155.1653567102762; Thu, 26 May 2022 05:11:42 -0700 (PDT) Received: from [192.168.0.177] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id cw13-20020a170906c78d00b006fee11af404sm458355ejb.147.2022.05.26.05.11.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 May 2022 05:11:42 -0700 (PDT) Message-ID: <32077a17-6a95-d583-9d7f-2276cf586b38@linaro.org> Date: Thu, 26 May 2022 14:11:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH -next] ARM: dts: aspeed: nuvia: rename vendor nuvia to qcom Content-Language: en-US To: Jae Hyun Yoo , Arnd Bergmann , Olof Johansson , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery Cc: Jamie Iles , Graeme Gregory , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org References: <20220523175640.60155-1-quic_jaehyoo@quicinc.com> <71613fa5-c468-e3ab-935a-7aa675e822fc@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <71613fa5-c468-e3ab-935a-7aa675e822fc@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_051144_914382_B89109F0 X-CRM114-Status: GOOD ( 24.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/05/2022 13:57, Jae Hyun Yoo wrote: > Hi Krzysztof, > > On 5/24/2022 2:53 AM, Krzysztof Kozlowski wrote: >> On 23/05/2022 19:56, Jae Hyun Yoo wrote: >>> Nuvia has been acquired by Qualcomm and the vendor name 'nuvia' will >>> not be used anymore so rename aspeed-bmc-nuvia-dc-scm.dts to >>> aspeed-bmc-qcom-dc-scm-v1.dts and change 'nuvia' to 'qcom' as its vendor >>> name in the file. >> >> And all users of this DTB now have to update their bootloaders, scripts, >> installation methods. We did not rename FSL or Marvell boards, so >> neither should be renamed this one. > > Yeah, I know that we don't rename dts but the previous version of this > change was picked recently in the middle of code review > https://lore.kernel.org/all/979a5c87-a7ea-a1f0-e42e-29043df6b348@quicinc.com/ > and the v3 was pulled recently so it's still in the -next queue so > I believe it has a chance to be renamed since no one is using the DTB > yet. Ah, so it is still in next (or was before this merge window). OK, thanks for explanation. > >>> >>> Signed-off-by: Jae Hyun Yoo >>> --- >>> arch/arm/boot/dts/Makefile | 2 +- >>> ...eed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} | 4 ++-- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >>> rename arch/arm/boot/dts/{aspeed-bmc-nuvia-dc-scm.dts => aspeed-bmc-qcom-dc-scm-v1.dts} (97%) >>> >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >>> index 03f5b3a15415..2a3c95387613 100644 >>> --- a/arch/arm/boot/dts/Makefile >>> +++ b/arch/arm/boot/dts/Makefile >>> @@ -1584,7 +1584,6 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >>> aspeed-bmc-lenovo-hr630.dtb \ >>> aspeed-bmc-lenovo-hr855xg2.dtb \ >>> aspeed-bmc-microsoft-olympus.dtb \ >>> - aspeed-bmc-nuvia-dc-scm.dtb \ >>> aspeed-bmc-opp-lanyang.dtb \ >>> aspeed-bmc-opp-mihawk.dtb \ >>> aspeed-bmc-opp-mowgli.dtb \ >>> @@ -1597,6 +1596,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >>> aspeed-bmc-opp-witherspoon.dtb \ >>> aspeed-bmc-opp-zaius.dtb \ >>> aspeed-bmc-portwell-neptune.dtb \ >>> + aspeed-bmc-qcom-dc-scm-v1.dtb \ >>> aspeed-bmc-quanta-q71l.dtb \ >>> aspeed-bmc-quanta-s6q.dtb \ >>> aspeed-bmc-supermicro-x11spi.dtb \ >>> diff --git a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts >>> similarity index 97% >>> rename from arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts >>> rename to arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts >>> index f4a97cfb0f23..259ef3f54c5c 100644 >>> --- a/arch/arm/boot/dts/aspeed-bmc-nuvia-dc-scm.dts >>> +++ b/arch/arm/boot/dts/aspeed-bmc-qcom-dc-scm-v1.dts >>> @@ -6,8 +6,8 @@ >>> #include "aspeed-g6.dtsi" >>> >>> / { >>> - model = "Nuvia DC-SCM BMC"; >>> - compatible = "nuvia,dc-scm-bmc", "aspeed,ast2600"; >>> + model = "Qualcomm DC-SCM V1 BMC"; >>> + compatible = "qcom,dc-scm-v1-bmc", "aspeed,ast2600"; >> >> >> You need also change bindings. > > I didn't see any case of changing bindings for adding a new Aspped BMC > dts. Hmmm... Where do you document these bindings? Or does it mean Aspeed does not document it at all, every time the checkpatch complains but no one thought about it why? :) Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel