From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D2E1C54E66 for ; Wed, 13 Mar 2024 18:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0J4t2Yu4nkjV5VsCIZdzVj4svEg1A1vasUwMvmiCobY=; b=lCBpUQ1Rnn4iyU ZdN01yDGBGqmP4LGBlcYsh45WVVPtyC6sB98mHeH42NXIeYBLiwEl4Edi7P+nhq3IzLFaNA+6mm7T vFqval9qkAVVdAWJdZeIAW+O8/HYipVkxSSaGFICYok8YWt7onz2jl5QaKStDkf11h6M8H77BAf7J baE0zsLeN/8bM/6RHrW9V1wCI1JRfriwuOTEjQK2fojl5NZJsvu+Hvu6d/PDweR9fStqSn5/ZIgZ/ sPLrd62esqJth7bRzVU/Sqx+b6J9HgDEZEJsCnOg6iYfp8aiNC+T97NdL9tRj4DYaQSjw+vqMSY1q T8Lm2wj67WIswDGRhZrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkTAl-0000000BHUd-3xWv; Wed, 13 Mar 2024 18:17:51 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkTAh-0000000BHRr-3d4s for linux-arm-kernel@lists.infradead.org; Wed, 13 Mar 2024 18:17:49 +0000 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-33e7ae72312so65255f8f.1 for ; Wed, 13 Mar 2024 11:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710353866; x=1710958666; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dxB79hpmOYEV/Wa5xEjs3BbB8JPGXY5M54cM2DcOGjk=; b=TeTGxX6q1fBiJdc3jE093n29vM1UgmJB5HKhOcpdwVKDUJo56bqvAhluRTX/aLUwve gB4XbyqQgFB8LsoBIcqS4rciNq8WuBaH9ndfTB+mcL4vhwsz07+Su8vUJoiibca0dIj+ gO5DLzRSbKvgSPo8b/d6OZtqDVURlye3srX2QQCBS357KUuV/w1cdZ/1KpEf2HUTv/x2 /cB2TdRSxTGAkELbIsOsZSUJaK+s4d/wiD2yQduvqMEa1LGpRe/Xq6UFb1oVNLQnWeGV OjwkjJ00J+7POS0MHY9T7aAcPtZ1JhjlmluymtfxUWU8dXGUB7OAkIaFSK+7FYpw7y36 OuDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710353866; x=1710958666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dxB79hpmOYEV/Wa5xEjs3BbB8JPGXY5M54cM2DcOGjk=; b=R4nlLgkGSogS8YBuB4kEbEUedHq2otQWhLdkt88h8N7e/Om+jzl9wFgc9Wrsle7h1I UyZGDj5eZK2idaar0pTwFxNzByh8H8dbfWWyApmzcHKgcGvgDwGVsh5bgNlF7K9RGDbB liS4U92tYC6kKufMVG84PcQIfMzP3qWGbkYGheHtitvbBqw0gMZ86diKODz/IDNZAA0M 3oaoI6UNytXb9jJqdNfC5b0fvJF5cT/K670ssboAJRpS2ciHQFNhYCQVgI5YmwgHWHds gjp0tOsx8RJSmEv3bwZ3YZnA1e6DCBUsq7BVBBRwoYL+ibpUocnOGYvSrhtgDD38UVmA OW/Q== X-Forwarded-Encrypted: i=1; AJvYcCXJJdWQJrJq9hBcUrkrEOj3eF0l7UqDUPCUF58tAg0o/UEB4EZBsSG9MK9+PtGp/5NmZUnDkZrdGkXQ96Wt3KTOByZllqdIRHLkY+p8aMwtPr0QLkc= X-Gm-Message-State: AOJu0YzQGOsDTtVIxBn1aojkqLX1GgJu2MujOt5rbGa2tIpIBpgot6Il GWUR9g1+8DDjgpNmHMuJTJWgdw+Ufvs8s50yNOSXE/WFN2DbFwhb X-Google-Smtp-Source: AGHT+IGKbeIwigUlBRsdMhJK7OomlBsIup1DbJY8unvtALG2eksaRqlMkijulA70G2ebsv8fF6clmw== X-Received: by 2002:a5d:644d:0:b0:33e:7896:a9d7 with SMTP id d13-20020a5d644d000000b0033e7896a9d7mr2108713wrw.67.1710353865784; Wed, 13 Mar 2024 11:17:45 -0700 (PDT) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id ch9-20020a5d5d09000000b0033eab3520a9sm4381264wrb.43.2024.03.13.11.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 11:17:45 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Michael Turquette , Stephen Boyd , Chen-Yu Tsai , Samuel Holland , Guido =?ISO-8859-1?Q?G=FCnther?= , Purism Kernel Team , Ondrej Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Oltmanns Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Frank Oltmanns , stable@vger.kernel.org Subject: Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate Date: Wed, 13 Mar 2024 19:17:43 +0100 Message-ID: <3210009.5fSG56mABF@jernej-laptop> In-Reply-To: <20240310-pinephone-pll-fixes-v4-1-46fc80c83637@oltmanns.dev> References: <20240310-pinephone-pll-fixes-v4-0-46fc80c83637@oltmanns.dev> <20240310-pinephone-pll-fixes-v4-1-46fc80c83637@oltmanns.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240313_111747_940645_83B8D06B X-CRM114-Status: GOOD ( 21.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 10. marec 2024 ob 14:21:11 CET je Frank Oltmanns napisal(a): > The Allwinner SoC's typically have an upper and lower limit for their > clocks' rates. Up until now, support for that has been implemented > separately for each clock type. > > Implement that functionality in the sunxi-ng's common part making use of > the CCF rate liming capabilities, so that it is available for all clock > types. > > Suggested-by: Maxime Ripard > Signed-off-by: Frank Oltmanns > Cc: stable@vger.kernel.org This looks pretty nice now. Reviewed-by: Jernej Skrabec Best regards, Jernej > --- > drivers/clk/sunxi-ng/ccu_common.c | 19 +++++++++++++++++++ > drivers/clk/sunxi-ng/ccu_common.h | 3 +++ > 2 files changed, 22 insertions(+) > > diff --git a/drivers/clk/sunxi-ng/ccu_common.c b/drivers/clk/sunxi-ng/ccu_common.c > index 8babce55302f..ac0091b4ce24 100644 > --- a/drivers/clk/sunxi-ng/ccu_common.c > +++ b/drivers/clk/sunxi-ng/ccu_common.c > @@ -44,6 +44,16 @@ bool ccu_is_better_rate(struct ccu_common *common, > unsigned long current_rate, > unsigned long best_rate) > { > + unsigned long min_rate, max_rate; > + > + clk_hw_get_rate_range(&common->hw, &min_rate, &max_rate); > + > + if (current_rate > max_rate) > + return false; > + > + if (current_rate < min_rate) > + return false; > + > if (common->features & CCU_FEATURE_CLOSEST_RATE) > return abs(current_rate - target_rate) < abs(best_rate - target_rate); > > @@ -122,6 +132,7 @@ static int sunxi_ccu_probe(struct sunxi_ccu *ccu, struct device *dev, > > for (i = 0; i < desc->hw_clks->num ; i++) { > struct clk_hw *hw = desc->hw_clks->hws[i]; > + struct ccu_common *common = hw_to_ccu_common(hw); > const char *name; > > if (!hw) > @@ -136,6 +147,14 @@ static int sunxi_ccu_probe(struct sunxi_ccu *ccu, struct device *dev, > pr_err("Couldn't register clock %d - %s\n", i, name); > goto err_clk_unreg; > } > + > + if (common->max_rate) > + clk_hw_set_rate_range(hw, common->min_rate, > + common->max_rate); > + else > + WARN(common->min_rate, > + "No max_rate, ignoring min_rate of clock %d - %s\n", > + i, name); > } > > ret = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, > diff --git a/drivers/clk/sunxi-ng/ccu_common.h b/drivers/clk/sunxi-ng/ccu_common.h > index 942a72c09437..329734f8cf42 100644 > --- a/drivers/clk/sunxi-ng/ccu_common.h > +++ b/drivers/clk/sunxi-ng/ccu_common.h > @@ -31,6 +31,9 @@ struct ccu_common { > u16 lock_reg; > u32 prediv; > > + unsigned long min_rate; > + unsigned long max_rate; > + > unsigned long features; > spinlock_t *lock; > struct clk_hw hw; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel