From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4085DCA1008 for ; Fri, 30 Aug 2024 15:58:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cTdnALrIHc8fcK5xveLkO6Caggfu1nyDtmahPYqM3cg=; b=kA0lCipGD8ChuLBo/U7Q8yiHzS h3AJO8XAN3+D6M2Hg7grRScMS4sFG1xcC+nD9YqBlfFMPQgalmSrcCE2e5/+t3rIi5BTnITosu1tu CswVkOcCavhzUga1NR8+DYwwPX8spG2lPxHRtVM/2zTzMMW28oEQUJDet8OjOcZRPMTkBrROx0iid 35D6ULUfg+ppka3nhcPfWBOWI22iGrZ3RMv+d4vJHX+afJee9SFQ3I536CdoFhLlN5lYNMK33vY0T fdVpsCTg0d8+DG+oC90xrB7XKNZGM9OX5EF28XP0O2vXCs7n4I1m0LKhKZjLVEoJpOSibFQocluPS c9P8eVaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk40q-00000006uyX-0IW6; Fri, 30 Aug 2024 15:58:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk3xg-00000006tpx-3nOP for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 15:54:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 63747153B; Fri, 30 Aug 2024 08:55:22 -0700 (PDT) Received: from [10.1.30.22] (e122027.cambridge.arm.com [10.1.30.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1BE573F762; Fri, 30 Aug 2024 08:54:52 -0700 (PDT) Message-ID: <32159e6c-ad6a-4beb-b854-fbef9bdc9862@arm.com> Date: Fri, 30 Aug 2024 16:54:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 11/19] arm64: rsi: Map unprotected MMIO as decrypted To: Suzuki K Poulose , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun References: <20240819131924.372366-1-steven.price@arm.com> <20240819131924.372366-12-steven.price@arm.com> <15213e51-e028-445e-a22f-f06fefd15fc8@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: <15213e51-e028-445e-a22f-f06fefd15fc8@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_085457_188365_19DFB469 X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/08/2024 15:11, Suzuki K Poulose wrote: > Hi Steven > > On 19/08/2024 14:19, Steven Price wrote: >> From: Suzuki K Poulose >> >> Instead of marking every MMIO as shared, check if the given region is >> "Protected" and apply the permissions accordingly. >> >> Signed-off-by: Suzuki K Poulose >> Signed-off-by: Steven Price >> --- >> New patch for v5 >> --- >>   arch/arm64/kernel/rsi.c | 15 +++++++++++++++ >>   arch/arm64/mm/mmu.c     |  2 +- >>   2 files changed, 16 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kernel/rsi.c b/arch/arm64/kernel/rsi.c >> index 381a5b9a5333..672dd6862298 100644 >> --- a/arch/arm64/kernel/rsi.c >> +++ b/arch/arm64/kernel/rsi.c >> @@ -6,6 +6,8 @@ >>   #include >>   #include >>   #include >> + >> +#include >>   #include >>     struct realm_config config; >> @@ -93,6 +95,16 @@ bool arm64_rsi_is_protected_mmio(phys_addr_t base, >> size_t size) >>   } >>   EXPORT_SYMBOL(arm64_rsi_is_protected_mmio); >>   +static int realm_ioremap_hook(phys_addr_t phys, size_t size, >> pgprot_t *prot) >> +{ >> +    if (arm64_rsi_is_protected_mmio(phys, size)) >> +        *prot = pgprot_encrypted(*prot); >> +    else >> +        *prot = pgprot_decrypted(*prot); >> + >> +    return 0; >> +} >> + >>   void __init arm64_rsi_init(void) >>   { >>       /* >> @@ -107,6 +119,9 @@ void __init arm64_rsi_init(void) >>           return; >>       prot_ns_shared = BIT(config.ipa_bits - 1); >>   +    if (arm64_ioremap_prot_hook_register(realm_ioremap_hook)) >> +        return; >> + >>       static_branch_enable(&rsi_present); >>   } >>   diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >> index 06b66c23c124..0c2fa35beca0 100644 >> --- a/arch/arm64/mm/mmu.c >> +++ b/arch/arm64/mm/mmu.c >> @@ -1207,7 +1207,7 @@ void set_fixmap_io(enum fixed_addresses idx, >> phys_addr_t phys) >>       else >>           prot = pgprot_encrypted(prot); >>   -    __set_fixmap(idx, phys, prot); >> +    __set_fixmap(idx, phys & PAGE_MASK, prot); > > This looks like it should be part of the previous patch ? Otherwise > looks good to me. Good spot - yes it should! Thanks, Steve