From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9EB9C3DA42 for ; Wed, 17 Jul 2024 06:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DQYbvfrGUIKd5VFa9R8opdDMQ2H/l+lWtCqC92UN9UA=; b=qo1kjavjVUiu+7P7yJ6i1vMNLf Z++CESZBqDx45Arv4Z6Gxg1pmE5sJsPQAVwrI/yMt2JLFXNhgJEjGM2hRA2LJPa8/3c9y0AQ0Ftia uz3ZY1tjpbxwY1GculToM7J3N6fHdLbaBtJafnw6ZkKSgp7Ps6TOyhkqsAtqnfSCs4CSwq4shaIrY 556f9Rd3Nz4/Y4TgTnHgbPyQAOzSMTkZC3rPrCw1qvvjDKg4H9jLM4GAaTYPRL0Gk578YUCzpS7aR UTCkHaAZWuMffjjKxqerEO4pE7NvSKgkXgDX6Ol9+yVAVfdUgzv+sKmDZJgZH00FvdP139Oh/FdeP BVhF5+pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTySJ-0000000CtMU-0P8i; Wed, 17 Jul 2024 06:48:03 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTyRy-0000000CtJI-26Ne for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2024 06:47:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 64D8DCE167D; Wed, 17 Jul 2024 06:47:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15EB7C32782; Wed, 17 Jul 2024 06:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721198859; bh=oc3RW93YsVeiKi+ATef+h3px9KSBRraPGzUP9ozkiMs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Jb/8lf0bhZDzWBnf7kNGHkS6+U5o0LREgg8Q1+WTuaO0Eo1kUdmyx7VOlE+Gcr7DH wJUcjFC1BFqu4rkfyHPT1XMmS0gqhob8SO54NjgC0hhMv6bkzXSb8HQj0mpvGusKyJ /dX27fZXHwO/KM+//Dp8qK0BH2QkW33tCPGEqT9iOLJNc7NwBFpyLpAzieard8NnOt nDSIYi8SBpQDuPiJPuV6OFI3shpq0lIro8mTrjhJQYjuihCv+g7LINJGF/GD3LxBlB LYvJOfp6XOtFDNPkp7a6ShOE6HHmBOhjd/iN7jFyOdW/2AsLc4/hCwzzSzOVlvMswM WNZvsfXRxY7FA== Message-ID: <3221423a-d5b3-47e3-8b98-623d9b26363d@kernel.org> Date: Wed, 17 Jul 2024 08:47:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V226/7] dt-bindings: PCI: host-generic-pci: Add snps,dw-pcie-ecam-msi binding To: Mayank Rana , will@kernel.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com, manivannan.sadhasivam@linaro.org, cassel@kernel.org, yoshihiro.shimoda.uh@renesas.com, s-vadapalli@ti.com, u.kleine-koenig@pengutronix.de, dlemoal@kernel.org, amishin@t-argos.ru, thierry.reding@gmail.com, jonathanh@nvidia.com, Frank.Li@nxp.com, ilpo.jarvinen@linux.intel.com, vidyas@nvidia.com, marek.vasut+renesas@gmail.com, krzk+dt@kernel.org, conor+dt@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Cc: quic_ramkri@quicinc.com, quic_nkela@quicinc.com, quic_shazhuss@quicinc.com, quic_msarkar@quicinc.com, quic_nitegupt@quicinc.com References: <1721067215-5832-1-git-send-email-quic_mrana@quicinc.com> <1721067215-5832-7-git-send-email-quic_mrana@quicinc.com> <5f029f16-2030-4e86-929b-0b2832958912@kernel.org> <083e1e6f-714d-4a3e-a864-59e06bba0559@quicinc.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <083e1e6f-714d-4a3e-a864-59e06bba0559@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240716_234742_931854_CE5C3E45 X-CRM114-Status: GOOD ( 19.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/07/2024 00:09, Mayank Rana wrote: > Hi Krzysztof > > On 7/16/2024 12:28 AM, Krzysztof Kozlowski wrote: >> On 15/07/2024 20:13, Mayank Rana wrote: >>> To support MSI functionality using Synopsys DesignWare PCIe controller >>> based MSI controller with ECAM driver, add "snps,dw-pcie-ecam-msi >>> compatible binding which uses provided SPIs to support MSI functionality. >> >> To support MSI, you add MSI support... That's a tautology. Describe >> hardware instead. > Ok. let me repharse it to provide more useful information. >>> >>> Signed-off-by: Mayank Rana >>> --- >>> .../devicetree/bindings/pci/host-generic-pci.yaml | 57 ++++++++++++++++++++++ >>> 1 file changed, 57 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml >>> index 9c714fa..9e860d5 100644 >>> --- a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml >>> +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml >>> @@ -81,6 +81,12 @@ properties: >>> - marvell,armada8k-pcie-ecam >>> - socionext,synquacer-pcie-ecam >>> - const: snps,dw-pcie-ecam >>> + - description: | >>> + Firmware is configuring Synopsys DesignWare PCIe controller in RC mode with >>> + ECAM compatible fashion. To use MSI controller of Synopsys DesignWare PCIe >>> + controller for MSI functionality, this compatible is used. >>> + items: >>> + - const: snps,dw-pcie-ecam-msi >> >> MSI is already present in the binding, isn't it? > It is mentioning as msi-parent usage which could be different MSI > controller (GIC or vendor specific one) not related to designware PCIe > controller based MSI controller. > >> Anyway, aren't you >> forgetting specific compatible? Please open your internal (quite >> comprehensive) guideline on bindings and DTS. > Here I am trying to define Designware based PCIe ECAM controller > supporting MSIcontroller based device. Hence I am not mentioning vendor > specific compatible usage > and keeping generic compatible binding for such device. I know what you try, yet it feels simply wrong. Read your guideline. Are you sure you work on Designware core itself, not on one used in Qualcomm? I would expect people from Designware to design Designware cores and people from Qualcomm only to design licensed cores. >> >>> - description: >>> CAM or ECAM compliant PCI host controllers without any quirks >>> enum: >>> @@ -116,6 +122,20 @@ properties: >>> A phandle to the node that controls power or/and system resource or interface to firmware >>> to enable ECAM compliant PCIe root complex. >>> >>> + interrupts: >>> + description: >>> + DWC PCIe Root Port/Complex specific MSI interrupt/IRQs. >>> + minItems: 1 >>> + maxItems: 8 >>> + >>> + interrupt-names: >>> + description: >>> + MSI interrupt names >>> + minItems: 1 >>> + maxItems: 8 >>> + items: >>> + pattern: '^msi[0-9]+$' >> >> Why the same devices have variable numbers? > Max supported MSI with designware PCIe controller is 8 Only, and it > depends if those all are > used or some of used on specific vendor based device. Hence I have kept > it here variable names. Although here it should be [0 - 7] instead of > [0 - 9]. Wait, you just said there is no specific vendor device. Sorry, bring some sanity to this. Best regards, Krzysztof