From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6055DC388F2 for ; Fri, 6 Nov 2020 09:59:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFBD220B80 for ; Fri, 6 Nov 2020 09:59:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AAlIaJ9+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nlvr1Tz1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFBD220B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9PmFXqGSIvG6mUFUXcx2sKvU8Jv+1SOiOIvQ0MXX5R4=; b=AAlIaJ9+dSUtv+WkBb3RT/mGS co9l1nD38mMkiwfhLeAuDoWfB1nt0dmkL1H8Oq6B5/jd4BuZSOe/01W8p2KAFucCFE/G3vzFic9d/ gzVxMdC7fftKhH6RLg1VrA8JWWCmvJC4OsidMvaa5j/MtD3R/rvN+qV/tOFf7YosjfTuVLHlf4dcr enDLdnpCB+Ui+yPyuY4HSDkJsHxsOaZF0PDxSeNImMLwoBMg+rhc6MxS8re+RdkyCNk0mdrBlZ2yV 0uO9WcnIPkZ4gkDTkGugSVgaxiS2FhplUrIxi19nBD0OAePg2fCu/gaHBc2gwadfq1RkF1I/Qa8Ya XY6vdcAjQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kayVV-00030B-P8; Fri, 06 Nov 2020 09:58:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kayUX-0002Xt-63 for linux-arm-kernel@lists.infradead.org; Fri, 06 Nov 2020 09:57:21 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E108B20B80; Fri, 6 Nov 2020 09:57:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604656627; bh=7k+t6D9+wpCTXBdefzDfDbiTH2zQDjta8PTrfd8tDa0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nlvr1Tz1wWGJ1mgrgtClOUmilBn7fgUtvjxfmP49knvor83tz0AID5fpC/e10x3Na 5fA2yUfgqMKrIMuoafHLqiXDsvLNB1rqknB1iEHYh3GssE78engknOQAV8JEHvx3WC 50i3UEJibPtZ3FNpe3PTpWvSM0sYHc0xSF0MQUrY= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kayUS-00892a-Mm; Fri, 06 Nov 2020 09:57:04 +0000 MIME-Version: 1.0 Date: Fri, 06 Nov 2020 09:57:04 +0000 From: Marc Zyngier To: Will Deacon Subject: Re: [PATCH 1/3] KVM: arm64: Allow setting of ID_AA64PFR0_EL1.CSV2 from userspace In-Reply-To: <20201105224442.GD8842@willie-the-truck> References: <20201103171445.271195-1-maz@kernel.org> <20201103171445.271195-2-maz@kernel.org> <20201105224442.GD8842@willie-the-truck> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <32241e9ee49133df4e9bcc6c8ebd7551@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: will@kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, liangpeng10@huawei.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_045709_663304_336E50AB X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, Suzuki K Poulose , Peng Liang , James Morse , Julien Thierry , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-11-05 22:44, Will Deacon wrote: >> + if (csv2 > vcpu->kvm->arch.pfr0_csv2) >> + return -EINVAL; >> + vcpu->kvm->arch.pfr0_csv2 = csv2; >> + >> + /* This is what we mean by invariant: you can't change it. */ >> + if (val != read_id_reg(vcpu, rd, false)) >> + return -EINVAL; > > I think it's quite confusing to return -EINVAL in the case that we have > actually updated arch.pfr0_csv2, as it's indistinguishable from the > case > when csv2 was invalid and the field wasn't updated. -EINVAL is the right error code here (you're setting an invalid value for the whole register). The bug is that we have now changed CSV2 for everyone. I'll have a look at fixing this, though it might involve some locking. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel