From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ARM: zynq: Move common.h to generic location
Date: Mon, 20 Oct 2014 15:36:06 +0200 [thread overview]
Message-ID: <3225036.9QQDRKvzZS@wuerfel> (raw)
In-Reply-To: <742a19eb987f3f99b42ba4b7e7ebc27bf19d7d72.1413811526.git.michal.simek@xilinx.com>
On Monday 20 October 2014 15:25:31 Michal Simek wrote:
> include/soc/zynq/ is the right location for this header
> to be able to share information from this header with other
> drivers which require it.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Changes in v2:
> - Update pm.c added in 3.17 too - Soren pointed on it
>
> arch/arm/mach-zynq/common.c | 2 +-
> arch/arm/mach-zynq/hotplug.c | 14 --------------
> arch/arm/mach-zynq/platsmp.c | 2 +-
> arch/arm/mach-zynq/pm.c | 2 +-
> arch/arm/mach-zynq/slcr.c | 2 +-
> {arch/arm/mach-zynq => include/soc/zynq}/common.h | 0
> 6 files changed, 4 insertions(+), 18 deletions(-)
> delete mode 100644 arch/arm/mach-zynq/hotplug.c
> rename {arch/arm/mach-zynq => include/soc/zynq}/common.h (100%)
>
NAK
Most (if not all) of that header should not be visible to drivers.
If you need to share some symbols, make a proper header file for those,
not one called 'common.h'.
Arnd
next prev parent reply other threads:[~2014-10-20 13:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 13:25 [PATCH v2 1/3] ARM: zynq: Move common.h to generic location Michal Simek
2014-10-20 13:25 ` [PATCH v2 2/3] ARM: zynq: Enable generic allocator Michal Simek
2014-10-20 13:34 ` Arnd Bergmann
2014-10-20 14:10 ` Michal Simek
2014-10-20 13:25 ` [PATCH v2 3/3] ARM: zynq: Extend SLCR driver to read OCM configuration Michal Simek
2014-10-20 13:36 ` Arnd Bergmann [this message]
2014-10-20 19:07 ` [PATCH v2 1/3] ARM: zynq: Move common.h to generic location Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3225036.9QQDRKvzZS@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).