From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CA62CA0EC3 for ; Tue, 12 Sep 2023 08:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=axgsnflkxbTI1SdTKZSM14jhl5qawgKO0BdRvSc46wE=; b=med0NfFKdf6Ml+ IDP0k+uXTSpwsItZLmg+zU5LrMoLjwWIcQIgEmgm+jvcHjFL9R/qugtvTWHM2i+0jkLRTvYUqfVhG G1YMmAch8gu3VvCzIeAvpGl5yALh0SzgOsUOwia8lRYArqx0PTp4nmoSLd57qco2hp72Z5KZUHzil PkJFOKdjYYsIgzMEcfT9+hNJ7muCTQHUsDnJec50ZlVlW/QL7/6WnAa2OpHKc4GW+PF8I9eMbuOtF fddl3n3yYbCCrgU+vdn93A9FvHJh7h3k4fdA8fXRpYIY8FS8xbpNTCGNoymQkd27KHD47PmPpz2jq ORjJA+hPJHq7gMvyYlEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qfyjD-002ZDp-2w; Tue, 12 Sep 2023 08:26:35 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qfyjB-002ZDF-0K for linux-arm-kernel@lists.infradead.org; Tue, 12 Sep 2023 08:26:34 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9a64619d8fbso677003266b.0 for ; Tue, 12 Sep 2023 01:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694507191; x=1695111991; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5o3LzkBLyHb7ofP84O3T9xGsTdDKL8/j5FWm25zteFw=; b=TU+JiTNoKTpguH+NYRH3XsKbMFQhuFY1e8yi7HKdLGCfeziEaLExhOqHFTB6sbeOeV HctNb0vFErv5yip0a2f1rzYb8K4a1n36pARmEacoOKMWpO9XQ7/XSe3OFLEhnHI33Y8A c7kQ9ZTe3+tJj4fOJ/2Etzzz9/5L10PdJDR3Dv4c/MV7titAxnPehdk+8uA2Q/6+5JHB azPSfzxQmkHFUKR5xo1R03gkIwxnyZUHV2ZxPOzq5Ns+Ob4ffH8FYbIaB46pP2u+Tr3x b9DR3YrRGaHL/MoIZGLzEc6G1WGIh4kXq+jeSM0IJeLae6ATTgtUzUhGANMidse9VtFp zyEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694507191; x=1695111991; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5o3LzkBLyHb7ofP84O3T9xGsTdDKL8/j5FWm25zteFw=; b=tqo3cco52uqSd8CEwInoyuDQllkWbu+9MXAoRR5o+YmA2Tawo9ldB9zKEzS00YBmhc HbKt2n5BOpXmfxpYvfNYO2X9wzDPOzHXzGdjeake20KNJCPB07QTziwlvhaBE5ZOQR9N J8BwGy1vInlyNgMXBIIXEA1YVv3RcW/8FsDiyDeAAOD2HJPEZ4rGUw3Og5VGFdVMycMR l6KQmx9vCvUUCq0flu1jOIMOm6iYhoAu3u5zoW0UbeerCc/CpO6VPUyrG0QpBRAJMBeF S841YivRowfrHIBVGZ1bCH0dyjfxUzX1vUb+0V1yBwJZOaJwYnOunNJgi8ocNC91cn8X lq1g== X-Gm-Message-State: AOJu0Yz2FXwLh1qNWN9aVzsAjM45rPK5v95tnUpkEiJleIJY1G5tebOH zxjauLdGFRBVuftkqW50tXZHkw== X-Google-Smtp-Source: AGHT+IHqm7STNNiZ6wKB/kmgoKnEIxaz707SIPonvtSj0mzlXB6e/6srpKoKgHR5Q0AbiyKegYvMuA== X-Received: by 2002:a17:906:300f:b0:9a1:b43b:73a0 with SMTP id 15-20020a170906300f00b009a1b43b73a0mr9631960ejz.20.1694507191390; Tue, 12 Sep 2023 01:26:31 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id m5-20020a1709066d0500b0099bd8c1f67esm6485920ejr.109.2023.09.12.01.26.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Sep 2023 01:26:30 -0700 (PDT) Message-ID: <32287c0a-e3c1-e474-3c90-913fe2c79879@linaro.org> Date: Tue, 12 Sep 2023 10:26:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP Content-Language: en-US To: Iuliana Prodan , "Iuliana Prodan (OSS)" , Mathieu Poirier , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Shawn Guo , Bjorn Andersson , Sascha Hauer , "S.J. Wang" , Fabio Estevam , devicetree@vger.kernel.org, Daniel Baluta , Mpuaudiosw Cc: linux-imx , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team , LnxRevLi References: <20230911224452.15739-1-iuliana.prodan@oss.nxp.com> <20230911224452.15739-3-iuliana.prodan@oss.nxp.com> <67de5706-d966-dd71-85c3-c95bc1b72733@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230912_012633_163270_AB525A4B X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/09/2023 10:13, Iuliana Prodan wrote: > On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote: >> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote: >>> From: Iuliana Prodan >>> >>> Add the reserve-memory nodes used by DSP when the rpmsg >>> feature is enabled. >>> These can be later used in a dsp node, like: >>> dsp: dsp@3b6e8000 { >>> compatible = "fsl,imx8mp-dsp"; >>> reg = <0x3b6e8000 0x88000>; >>> mbox-names = "tx0", "rx0", "rxdb0"; >>> mboxes = <&mu2 2 0>, <&mu2 2 1>, >>> <&mu2 3 0>, <&mu2 3 1>; >>> memory-region = <&dsp_vdev0buffer>, <&dsp_vdev0vring0>, >>> <&dsp_vdev0vring1>, <&dsp_reserved>; >>> status = "okay"; >> Drop this example from commit msg, useless and not really correct. > Ok, will drop it. But this is a correct example, is just incomplete. No, status=okay is redundant, thus it is not a correct example. >>> }; >>> >>> Signed-off-by: Iuliana Prodan >>> --- >>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> index cc406bb338fe..eedc1921af62 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi >>> @@ -210,6 +210,18 @@ >>> dsp_reserved: dsp@92400000 { >>> reg = <0 0x92400000 0 0x2000000>; >>> no-map; >> Please test the patches before sending. This does not build. > > I've tested on remoteproc tree, but it seems I missed a bracket when > sending upstream. Sorry abut this, will fix it in v2. No, this is not how testing works. You must test this patch. This means you tested something, then ported patch to entirely different tree, resolved conflicts in buggy way and send it without testing. Nope. > Should I test this on other tree(s)? You test the patch on the tree you send it. What is the point to test it on some old code, cherry-pick with bugs and then send? If you have cross-tree dependencies between subsystem, isn't linux-next for this? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel