From: Markus Elfring <Markus.Elfring@web.de>
To: Kamlesh Gurudasani <kamlesh@ti.com>,
devicetree@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Herbert Xu <herbert@gondor.apana.org.au>,
Tero Kristo <kristo@kernel.org>, Will Deacon <will@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Conor Dooley <conor+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH v3 4/6] crypto: ti - add driver for MCRC64 engine
Date: Tue, 11 Jun 2024 14:02:52 +0200 [thread overview]
Message-ID: <32303d99-c5ba-4fec-8981-9b9966dc3291@web.de> (raw)
In-Reply-To: <20240524-mcrc64-upstream-v3-4-24b94d8e8578@ti.com>
…
> +++ b/drivers/crypto/ti/mcrc64.c
…
> +static int mcrc64_probe(struct platform_device *pdev)
> +{
…
> + platform_set_drvdata(pdev, dev_data);
> +
> + spin_lock(&mcrc64_dev_list.lock);
> + list_add(&dev_data->list, &mcrc64_dev_list.dev_list);
> + spin_unlock(&mcrc64_dev_list.lock);
> +
> + mutex_lock(&refcnt_lock);
> + if (!refcnt) {
> + ret = crypto_register_shashes(algs, ARRAY_SIZE(algs));
…
> + }
> + refcnt++;
> + mutex_unlock(&refcnt_lock);
…
Would you become interested to apply lock guards?
https://elixir.bootlin.com/linux/v6.10-rc2/source/include/linux/cleanup.h#L124
Regards,
Markus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-06-11 12:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 12:24 [PATCH v3 0/6] Add support for MCRC64 engine to calculate 64-bit CRC in Full-CPU mode kamlesh
2024-05-30 12:24 ` [PATCH v3 1/6] lib: add ISO 3309 model crc64 kamlesh
2024-06-11 3:14 ` Eric Biggers
2024-05-30 12:24 ` [PATCH v3 2/6] crypto: crc64 - add crc64-iso3309 framework kamlesh
2024-05-30 12:24 ` [PATCH v3 3/6] dt-bindings: crypto: Add Texas Instruments MCRC64 kamlesh
2024-05-31 9:02 ` Krzysztof Kozlowski
2024-05-30 12:24 ` [PATCH v3 4/6] crypto: ti - add driver for MCRC64 engine kamlesh
2024-06-11 12:02 ` Markus Elfring [this message]
2024-05-30 12:24 ` [PATCH v3 5/6 DONOTMERGE] arm64: dts: ti: k3-am62: Add dt node, cbass_main ranges for MCRC64 kamlesh
2024-05-30 12:24 ` [PATCH v3 6/6 DONOTMERGE] arm64: defconfig: enable TI MCRC64 module kamlesh
2024-06-10 14:33 ` [PATCH v3 0/6] Add support for MCRC64 engine to calculate 64-bit CRC in Full-CPU mode Kamlesh Gurudasani
2024-06-11 2:31 ` Herbert Xu
2024-06-11 3:13 ` Eric Biggers
2024-06-11 3:17 ` Herbert Xu
2024-09-06 11:14 ` Kamlesh Gurudasani
2024-09-13 10:35 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32303d99-c5ba-4fec-8981-9b9966dc3291@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=alexandre.torgue@foss.st.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kamlesh@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox