From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6212C5479D for ; Mon, 9 Jan 2023 20:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TvbriCgkeCdOj9ytQRLKpup9bmI01fWjfJLNffBRYKc=; b=oxZ48F8i4t52HT 1VKxDi5YZj2ZD0rLplXt6Y6CiE0VdswU4jtnTYn/iNPGqI+u3urux+GP2qCXuJrWWhKQNpLmCTNKs l6SANVOunukRdZFVty9N69ipWO7vd2bpZaTCH6BaPZNOLaC5V8auChTVVu2jUgXPjAFKULckrPHKa yJ80QdAN2JGKLV5YOmsTRdAJjn982dDusQD9EDlrGnCXIYQ6INFVintuAs6xeZk9rE/Bqm5eYYoy0 YjJ/hNRt5zn5ojwjjG4m8GQxyOuGbEtOWtdWORUY7NbK7FYQyB6kzJeZSvYtQbnyGVPvgV2EZSFea vaHFfCnfPKrMGAYP8GXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEyj6-003sxY-JF; Mon, 09 Jan 2023 20:26:36 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEyj3-003svj-Hm for linux-arm-kernel@lists.infradead.org; Mon, 09 Jan 2023 20:26:35 +0000 Received: by mail-lf1-x134.google.com with SMTP id b3so14881924lfv.2 for ; Mon, 09 Jan 2023 12:26:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vG2rLkKQzLwsW4cA+jY3MG5O3NUS9GFU+CxE1+/7o2Q=; b=xWZp9nUNTWKwD74R8LaFCrCez8o4RmpZDe2jPbbuvl4uC1rDQUqJJRW+yDyUK97YZf UlDRwPOIfLuj5nj6I9YHWJcI7S1x67PFhQ7LOj7Zghh+Jw7wtCMPuGM9D1yeuvFfmgMM U+vms6vmDnLysmNTOmDHJ0x2mMtBGiPblOXkfVdFVt1/0sGBFlS1KD1dcZMlj8fCb7DB ZLFDR9xw359oFd5rQ9m50XQl8J1K0F4Hgy0O0Go8G6WqeL4EslIBZTjldCdqMptV10VH Kg5kdCUCTz0Mp989/XxQgN9Xeh7FO68uU2yZKLYHTN19utWqLUCQLRJjNQQqtHG2QX3U CoTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vG2rLkKQzLwsW4cA+jY3MG5O3NUS9GFU+CxE1+/7o2Q=; b=HUOnuf9XO+XDTypeWA+Ba+RUaGiJ07vjWWK9xXw8NV5P/eMbYVZzjY9qUdDxOLWhwq KiiiZcEM1d17OsgfQ2b3nAwrIxycnJCAMcJlTHJeodpAtulL9Fv2NTjThZp+f8DIw3YV HpNaG7ccBFfrlu/r+1lFclwr2N+cjy+dzbNUvRDBX0lSR74xWUW2dE2V70FzTfv4sjc4 AGaovjIaVuOMjUIRbivV/b1Mf+8Nym0UEG3sfBEDqvN54MlzeDgYYDHd8DvzUJ72jBRr EEsm80nChCNBoRs4HTERXaUYbT2DrBPrU0ND2vD2UQysBd+nueIZnfZyqDNXDq+QLIXA 2rWA== X-Gm-Message-State: AFqh2kpAiwETUm0RkJj/aBhZApG74UpQei6VJl2tViVW96nZV/iA5kZ7 pqcVihWf57V8fwBgB1sleQE44A== X-Google-Smtp-Source: AMrXdXud+zuLlxBWWyOW8OFiUXQuyNeAZskXTT6VzcQR7Vsc/7FYAkAwHzAXPDGI0iNZBUPabeVROQ== X-Received: by 2002:a05:6512:39ce:b0:4b4:e559:8b10 with SMTP id k14-20020a05651239ce00b004b4e5598b10mr20842770lfu.24.1673295990084; Mon, 09 Jan 2023 12:26:30 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id a9-20020ac25e69000000b004cafb150134sm1208799lfr.67.2023.01.09.12.26.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Jan 2023 12:26:29 -0800 (PST) Message-ID: <323ec70e-4613-c0e9-0b39-ad2a0a76673d@linaro.org> Date: Mon, 9 Jan 2023 22:26:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically Content-Language: en-GB To: Laurentiu Palcu Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Clark , Sean Paul , Abhinav Kumar , Tomi Valkeinen , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20221102180705.459294-1-dmitry.baryshkov@linaro.org> <20230109162140.yelgy2da7aqa6sqv@fsr-ub1664-121.ea.freescale.net> From: Dmitry Baryshkov In-Reply-To: <20230109162140.yelgy2da7aqa6sqv@fsr-ub1664-121.ea.freescale.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230109_122633_625531_3ED04C2D X-CRM114-Status: GOOD ( 25.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 09/01/2023 18:21, Laurentiu Palcu wrote: > Hi Dmitry, > > It looks like there are some issues with this patchset... :/ I just > fetched the drm-tip and, with these patches included, the "Hot plug > detection already enabled" warning is back for i.MX DCSS. Could you please provide a backtrace? > > After a short investigation, it seems that we end up calling > drm_bridge_hpd_enable() from both drm_kms_helper_poll_init() and > drm_fbdev_generic_setup(), hence the warning. > > There are drivers using the drm_bridge_connector API that also call > drm_kms_helper_poll_init() followed by drm_fbdev_generic_setup(). So, > they might experience the same behavior, unless I'm missing something... > :/ > > Also, even if drm_fbdev_generic_setup() is not called in the driver > initialization, the warning will still appear the first time the > GETCONNECTOR ioctl is called, because that'll call > drm_helper_probe_single_connector_modes() helper which will eventually > call drm_bridge_hpd_enable(). > > Any idea? > > Cheers, > Laurentiu > > On Wed, Nov 02, 2022 at 09:06:58PM +0300, Dmitry Baryshkov wrote: >> From all the drivers using drm_bridge_connector only iMX/dcss and OMAP >> DRM driver do a proper work of calling >> drm_bridge_connector_en/disable_hpd() in right places. Rather than >> teaching each and every driver how to properly handle >> drm_bridge_connector's HPD, make that automatic. >> >> Add two additional drm_connector helper funcs: enable_hpd() and >> disable_hpd(). Make drm_kms_helper_poll_* functions call them (as this >> is the time where the drm_bridge_connector's functions are called by the >> drivers too). >> >> Changes since v2: >> - Fixed a typo in the commit message of the second patch. >> >> Changes since v1: >> - Rebased on top of v6.1-rc1 >> - Removed the drm_bridge_connector_enable_hpd() from >> drm_bridge_connector_init() >> - Removed extra underscore prefix from >> drm_bridge_connector_en/disable_hpd() helpers >> >> Dmitry Baryshkov (7): >> drm/poll-helper: merge drm_kms_helper_poll_disable() and _fini() >> drm/probe-helper: enable and disable HPD on connectors >> drm/bridge_connector: rely on drm_kms_helper_poll_* for HPD enablement >> drm/imx/dcss: stop using drm_bridge_connector_en/disable_hpd() >> drm/msm/hdmi: stop using drm_bridge_connector_en/disable_hpd() >> drm/omap: stop using drm_bridge_connector_en/disable_hpd() >> drm/bridge_connector: drop drm_bridge_connector_en/disable_hpd() >> >> drivers/gpu/drm/drm_bridge_connector.c | 27 +++------------- >> drivers/gpu/drm/drm_probe_helper.c | 40 ++++++++++++++++++----- >> drivers/gpu/drm/imx/dcss/dcss-dev.c | 4 --- >> drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 -- >> drivers/gpu/drm/msm/hdmi/hdmi.c | 2 -- >> drivers/gpu/drm/omapdrm/omap_drv.c | 41 ------------------------ >> include/drm/drm_bridge_connector.h | 2 -- >> include/drm/drm_modeset_helper_vtables.h | 22 +++++++++++++ >> 8 files changed, 59 insertions(+), 81 deletions(-) >> >> -- >> 2.35.1 >> -- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel