From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EA3CC433EF for ; Wed, 23 Mar 2022 09:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a7tukxBU+wvC8BRX8tKPK/jnMWcrSjBveFxV3riy8oI=; b=2V0WlSQhV5lo0N UTcEPMSpAa8MtkO4BEbTnia+p785wCcuSKMf3TmaD2rTIikCH0IABBn008KPfMdjoZcW1Qw9E2jT4 HT7Jw3rI3jgBHsXpz+jaFrV0ezL4lFXMySiDZKH9/BzjU987MY7DBEdFLS+9Rp5n13AfuAnJHDblk caCvDtbx5nvMel6MwoSYYFqrjXzc5UAQ51Ij/OZgYq4KS36iB7cV/IjvMEf2bQKw5Q2GH7II81j8X qu/RthpKiONxx+/nH0axs/tBUm5TWqcfZqmgtiW+7Yz3FPiqm+z1n+INwPHi5GfJmAAxbcJH5ZYmH WoseUV9rMPdhbaucJQHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWx4F-00DCyb-M5; Wed, 23 Mar 2022 09:14:11 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWx4B-00DCxd-Ax for linux-arm-kernel@lists.infradead.org; Wed, 23 Mar 2022 09:14:09 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWx45-0006oh-6l; Wed, 23 Mar 2022 10:14:01 +0100 Message-ID: <324276ea42a34f0862ca1d5f5c0aa4a68fa22657.camel@pengutronix.de> Subject: Re: [PATCH v2 3/4] arm64: dts: imx8mp: Add MEDIAMIX power domains From: Lucas Stach To: Laurent Pinchart , Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , Fabio Estevam , Paul Elder Date: Wed, 23 Mar 2022 10:14:00 +0100 In-Reply-To: References: <20220322190324.12589-1-laurent.pinchart@ideasonboard.com> <20220322190324.12589-4-laurent.pinchart@ideasonboard.com> <7b026a48-33c7-47f7-c916-7c15397f8b89@denx.de> User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_021407_403313_3668DEF4 X-CRM114-Status: GOOD ( 20.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, dem 23.03.2022 um 00:02 +0200 schrieb Laurent Pinchart: > Hi Marek, > > On Tue, Mar 22, 2022 at 10:31:59PM +0100, Marek Vasut wrote: > > On 3/22/22 20:03, Laurent Pinchart wrote: > > > Add the power domains related to the MEDIAMIX to the GPC. > > > > > > Signed-off-by: Laurent Pinchart > > > --- > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 26 +++++++++++++++++++++++ > > > 1 file changed, 26 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > index b40a5646f205..b440f22e03e5 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > @@ -488,6 +488,11 @@ pgc { > > > #address-cells = <1>; > > > #size-cells = <0>; > > > > > > + pgc_mipi_phy1: power-domain@0 { > > > + #power-domain-cells = <0>; > > > + reg = ; > > > > Shouldn't there be this here ? > > > > power-domains = <&pgc_mediamix>; > > I recall Lucas telling me it wasn't needed, and was instead handled > internally in the gpcv2 driver, due to sequencing requirements, but I > don't recall the details. It's not handled by the gpcv2 driver, but the blk-ctrl driver. The blk- ctrl driver handles the sequencing requirements when powering up/down the "bus" domain, in that case the mediamix domain. In fact there must not be any direct connection between the domains in the GPC DT description as that would cause the requirements for clock and reset propagation to be violated. Regards, Lucas > > > > + }; > > > + > > > pgc_pcie_phy: power-domain@1 { > > > #power-domain-cells = <0>; > > > reg = ; > > > @@ -530,6 +535,21 @@ pgc_gpu3d: power-domain@9 { > > > power-domains = <&pgc_gpumix>; > > > }; > > > > > > + pgc_mediamix: power-domain@10 { > > > + #power-domain-cells = <0>; > > > + reg = ; > > > + clocks = <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_APB_ROOT>; > > > + assigned-clocks = <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>, > > > + <&clk IMX8MP_CLK_MEDIA_APB_ROOT>; > > > + assigned-clock-rates = <500000000>, <200000000>; > > > + }; > > > + > > > + pgc_mipi_phy2: power-domain@16 { > > > + #power-domain-cells = <0>; > > > + reg = ; > > > > Here too ? > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel