From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4724C54E41 for ; Mon, 4 Mar 2024 09:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LxPq9k39jnArrUjQP7KtOvLouhaPsGEDre19/2rz0G8=; b=qwJOYzGA0rwQrv n9jX5qlrYLJJtiCYqp/wshkFZDGnEmuneXPZoXgNMcrQJ52sWoBvBzAsZ1sA49Z2m6O1LbXNUY7op Kuf5LWRmgf5W0OYTV7K6S1/okZ4tqkRXkB3NOEuV02fAo3r5ob+x+VkH7IKbeesblxstsaEbrcqow ftxOaDx+Yv0FbXk1m8S+3xySzYImWJrB9ITu3p979nPtih7kzR76wJbZ/YFi5FjD3mQKHb37u3p05 aXT0HkZIZm96HmQkOgu+Jt4L30spHWegLsZ3TjbV2dxY9JQnye4khhmy28xe8Yo0Oiqiz3sD7D1G9 pTSpa8cxmiqSjdcq5Qsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh4ZL-00000008MwG-2kgD; Mon, 04 Mar 2024 09:25:11 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh4Z2-00000008Mkk-3zyY; Mon, 04 Mar 2024 09:25:02 +0000 Received: from i53875a9e.versanet.de ([83.135.90.158] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rh4Yt-0007X4-Rj; Mon, 04 Mar 2024 10:24:43 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection Date: Mon, 04 Mar 2024 10:24:43 +0100 Message-ID: <3246455.0WQXIW03uk@diego> In-Reply-To: <0f7d2882-aa4b-424e-a999-45f2e18fc7f0@debian.org> References: <20240304084612.711678-2-ukleinek@debian.org> <3082796.ktpJ11cQ8Q@diego> <0f7d2882-aa4b-424e-a999-45f2e18fc7f0@debian.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_012458_565536_EDF273B4 X-CRM114-Status: GOOD ( 21.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Uwe, Am Montag, 4. M=E4rz 2024, 10:15:57 CET schrieb Uwe Kleine-K=F6nig: > On 04.03.24 10:07, Heiko St=FCbner wrote: > > Am Montag, 4. M=E4rz 2024, 09:46:11 CET schrieb Uwe Kleine-K=F6nig: > >> While it requires to have the right phy driver loaded (i.e. motorcomm) > >> to make the phy asserting the right delays, this is generally the > >> preferred way to define the MAC <-> PHY connection. > >> > >> Signed-off-by: Uwe Kleine-K=F6nig > >> --- > >> Hello, > >> > >> Andrew already pointed out when I posted the patch introducing the gma= c0 node > >> that rgmii-id would be the preferred way to setup things. Back then th= is didn't > >> happen because this change broke reception of network packets. However= this > >> only happend because I didn't have the right phy driver loaded. > > = > > trying to understand how the (not) loaded module fits into this :-) > > The mdio-bus is supposed to probe the phy and load the appropriate modu= le. > > = > > From your description it sounds like the correct phy module needs to be > > actually loaded? Or was that meant to be a "requires to have the right = phy > > driver compiled" instead? > = > The latter. i.e. with MOTORCOMM_PHY=3Dn it's broken, but works fine with = > MOTORCOMM_PHY=3Dy or =3Dm. ah great, then it's really fine. If it's ok with you I'll change the "loade= d" to "available" then (for compiled in or as module) Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel