From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [RFC] ARM: keystone: possibly fix big-endian kernels
Date: Tue, 23 Feb 2016 16:01:06 +0100 [thread overview]
Message-ID: <3249746.5p1eRtyJ9a@wuerfel> (raw)
In-Reply-To: <20160223145318.GK19428@n2100.arm.linux.org.uk>
On Tuesday 23 February 2016 14:53:18 Russell King - ARM Linux wrote:
> On Tue, Feb 23, 2016 at 03:43:21PM +0100, Arnd Bergmann wrote:
> > While discussing a regressing in the netcp driver, I wondered
> > whether Keystone can work with a big-endian kernel, and noticed
> > that we don't switch endianess when we enter the kernel on the
> > secondary CPU, or when we call into smc.
>
> NAK. Sorry Arnd, you're worringly wrong on this.
>
> secondary_startup will do the setend if necessary, there's no need
> to do this kind of junk in each and every platform. It's been this
> way since:
>
> commit 97bcb0fea590d3d704f985bec08f342d28992634
> Author: Ben Dooks <ben.dooks@codethink.co.uk>
> Date: Fri Feb 1 09:40:42 2013 +0000
>
> So, I hope you've not been telling platform folk to do this. Please
> audit the arm-soc code to make sure, thanks.
>
I see my mistake now: I looked at the secondary_startup() function
by looking up the location in ctags, and that pointed me to
arch/arm/kernel/head-nommu.S.
I was surprised when I didn't see the setend() in there, but
didn't realize that I was looking in the wrong place, but it
made some sense when I found the setend in a couple of other
platforms that all need a wrapper anyway.
Sorry about the noise.
Arnd
prev parent reply other threads:[~2016-02-23 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:43 [PATCH] [RFC] ARM: keystone: possibly fix big-endian kernels Arnd Bergmann
2016-02-23 14:53 ` Russell King - ARM Linux
2016-02-23 15:01 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3249746.5p1eRtyJ9a@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox