From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value
Date: Thu, 17 Mar 2011 11:22:00 +0530 [thread overview]
Message-ID: <324bffcaf53be55bd6f392af3f86fa10@mail.gmail.com> (raw)
In-Reply-To: <1300295763-497-1-git-send-email-aaro.koskinen@nokia.com>
> -----Original Message-----
> From: linux-arm-kernel-bounces at lists.infradead.org [mailto:linux-
> arm-kernel-bounces at lists.infradead.org] On Behalf Of Aaro Koskinen
> Sent: Wednesday, March 16, 2011 10:46 PM
> To: linux-omap at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; tony at atomide.com
> Cc: Aaro Koskinen
> Subject: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init()
> return value
>
> Fix the return value for the successful case.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> ---
> arch/arm/mach-omap2/devices.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-
> omap2/devices.c
> index 0d2d6a9..d478f53 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -65,7 +65,7 @@ static int __init omap3_l3_init(void)
>
> WARN(IS_ERR(od), "could not build omap_device for %s\n",
> oh_name);
>
> - return PTR_ERR(od);
> + return IS_ERR(od) ? PTR_ERR(od) : 0;
> }
> postcore_initcall(omap3_l3_init);
>
Looks good.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2011-03-17 5:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 17:16 [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value Aaro Koskinen
2011-03-16 17:16 ` [PATCH 2/2] arm: mach-omap2: omap_l3_smx: fix irq handler setup Aaro Koskinen
2011-03-17 5:54 ` Santosh Shilimkar
2011-03-17 5:52 ` Santosh Shilimkar [this message]
2011-03-17 8:19 ` [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value Cousson, Benoit
2011-03-17 10:06 ` Santosh Shilimkar
2011-03-18 23:43 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=324bffcaf53be55bd6f392af3f86fa10@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).