From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AF78D1AD43 for ; Wed, 16 Oct 2024 11:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UQnSqYqpBfUV+6/cvpHKfQx6TgwRy+1JDtpQMvdUWAY=; b=W0jqqVJ7ymTO74XqSMJaRnCXt0 lm1UoYHBLN/76O2zres8QhQXwoqxA3KROxSYWyHpw9+yv6Rlq8snTRph5eLazFeN3GuPsrW4R/c3x M00mnwCT0kKkBdTBxCg1nsIAl6lereydIquEu350IZHKTqMN8FguRDc38J+Ni8g3oF8FkUiwVBNwg xFQyV6Rkxyz0pdR/op18/4O7uZ+eR+FOrCHImZc2Z7YbOfhk1FNLSnRa/61IvuR17mIC13+tScu2c ez3hc7cnrivfbAlfJa0D/KQqDc5PmEUQvbZ/M6qymSuLxF2puaLMcVXVYRt2I9FDdTCuuo2esRG6K LB242gVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t11qQ-0000000BY1b-2Ysm; Wed, 16 Oct 2024 11:05:34 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t11oz-0000000BXqP-0nzq; Wed, 16 Oct 2024 11:04:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1729076645; x=1760612645; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UQnSqYqpBfUV+6/cvpHKfQx6TgwRy+1JDtpQMvdUWAY=; b=OKr/x3rXzEuq57VqjOUgrGUiY7W7RHtUG+Ypj0HcWXvxB4mKjN00g2lV Ogp0xfE0QSG1xZG7QU/vDcnNbIPBKWWmBttiyCO4opCsfjKpdXdmU5+T3 EmZB/ALMinaDBJn9zCso6ySiqRTD14IgPMgG0qOR+umi1ZseqzPJ4JnqK 49KILYkHExpXysmKs5WFD8RcnXdq2/1bshulErEahLG6f7Rszwe73jIq8 giOMEGbuZBzG93/Smi/XI7XvcskY4OHEuQpr76MpAzQjfMd7h2q0w/BFU QbPYtg7ZrV024O3RHTqXMtpM3clZ8ixAhM11kfltuxWJuTDt7Yqt1NS17 Q==; X-CSE-ConnectionGUID: 4/UoR85oRzeG0PblB3UK6Q== X-CSE-MsgGUID: YU0fFkq7QwqVGtD9L/F5uw== X-IronPort-AV: E=Sophos;i="6.11,207,1725314400"; d="scan'208";a="39492910" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 16 Oct 2024 13:04:00 +0200 X-CheckPoint: {670F9DA0-E-21611FC3-DAD22B0C} X-MAIL-CPID: 7354DE9C6207C2B376A359CA9647EA1D_4 X-Control-Analysis: str=0001.0A682F1E.670F9DA0.00D7,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3D9C116853D; Wed, 16 Oct 2024 13:03:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1729076635; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=UQnSqYqpBfUV+6/cvpHKfQx6TgwRy+1JDtpQMvdUWAY=; b=XI2MQPm+Mb/NIn/vSlonjdjH9uLgzitytNffKH4fG82nU/9taJXmCN4sJ/t2FzcSPgaNP4 XRgidS1bmOo2sLA+p8MAGqjA6j9wAOU+rM1ufpkxT5Fi3kpMZBlICZToZPblxy5kISnejT ltUEKOB2f+q3JYvaP1ebe561GvmJyVrygQOXO9swUbWkzQ34dGqAXse3nJRhBefmPya+Re oV3q2cbZPzVXOST2dHeS/hT7WgCLUsLAyhVsnV4hjbpAykUth8RHN/FBPVz+e4/02ga163 qA6ialNJio94VChL6mUXQGKZ+GFHW72i8KIq3tt8M47szxmlG/XhFeFCk41BhQ== From: Alexander Stein To: Xu Yang Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, gregkh@linuxfoundation.org, peter.chen@kernel.org, herve.codina@bootlin.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, jun.li@nxp.com Subject: Re: [PATCH v8 2/3] arm64: dts: imx95: add usb3 related nodes Date: Wed, 16 Oct 2024 13:03:53 +0200 Message-ID: <3252989.5fSG56mABF@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20241016104140.rjmszgplmql4hwrs@hippo> References: <20241015111018.2388913-1-xu.yang_2@nxp.com> <22464382.EfDdHjke4D@steina-w> <20241016104140.rjmszgplmql4hwrs@hippo> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241016_040405_753748_10B90591 X-CRM114-Status: GOOD ( 21.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Mittwoch, 16. Oktober 2024, 12:41:40 CEST schrieb Xu Yang: > On Wed, Oct 16, 2024 at 10:53:50AM +0200, Alexander Stein wrote: > > Hi, > >=20 > > another thing I just noticed. > >=20 > > Am Dienstag, 15. Oktober 2024, 13:10:17 CEST schrieb Xu Yang: > > > Add usb3 phy and controller nodes for imx95. > > >=20 > > > Signed-off-by: Xu Yang > > >=20 > > > --- > > > Changes in v2: > > > - no changes > > > Changes in v3: > > > - no changes > > > Changes in v4: > > > - reorder nodes > > > Changes in v5: > > > - no changes > > > Changes in v6: > > > - rebase to latest > > > Changes in v7: > > > - no changes > > > Changes in v8: > > > - no changes > > > --- > > > arch/arm64/boot/dts/freescale/imx95.dtsi | 43 ++++++++++++++++++++++= ++ > > > 1 file changed, 43 insertions(+) > > >=20 > > > diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/bo= ot/dts/freescale/imx95.dtsi > > > index 03661e76550f..e3faa8462759 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx95.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi > > > @@ -1473,6 +1473,49 @@ smmu: iommu@490d0000 { > > > }; > > > }; > > > =20 > > > + usb3: usb@4c010010 { > > > + compatible =3D "fsl,imx95-dwc3", "fsl,imx8mp-dwc3"; > > > + reg =3D <0x0 0x4c010010 0x0 0x04>, > > > + <0x0 0x4c1f0000 0x0 0x20>; > > > + clocks =3D <&scmi_clk IMX95_CLK_HSIO>, > > > + <&scmi_clk IMX95_CLK_32K>; > > > + clock-names =3D "hsio", "suspend"; > > > + interrupts =3D ; > > > + #address-cells =3D <2>; > > > + #size-cells =3D <2>; > > > + ranges; > > > + power-domains =3D <&scmi_devpd IMX95_PD_HSIO_TOP>; > > > + dma-ranges =3D <0x0 0x0 0x0 0x0 0x10 0x0>; > > > + status =3D "disabled"; > > > + > > > + usb3_dwc3: usb@4c100000 { > > > + compatible =3D "snps,dwc3"; > > > + reg =3D <0x0 0x4c100000 0x0 0x10000>; > > > + clocks =3D <&scmi_clk IMX95_CLK_HSIO>, > > > + <&scmi_clk IMX95_CLK_24M>, > > > + <&scmi_clk IMX95_CLK_32K>; > > > + clock-names =3D "bus_early", "ref", "suspend"; > > > + interrupts =3D ; > > > + phys =3D <&usb3_phy>, <&usb3_phy>; > > > + phy-names =3D "usb2-phy", "usb3-phy"; > > > + snps,gfladj-refclk-lpm-sel-quirk; > > > + snps,parkmode-disable-ss-quirk; > > > + iommus =3D <&smmu 0xe>; > > > + }; > > > + }; > > > + > > > + usb3_phy: phy@4c1f0040 { > > > + compatible =3D "fsl,imx95-usb-phy", "fsl,imx8mp-usb-phy"; > > > + reg =3D <0x0 0x4c1f0040 0x0 0x40>, > > > + <0x0 0x4c1fc000 0x0 0x100>; > > > + clocks =3D <&scmi_clk IMX95_CLK_HSIO>; > > > + clock-names =3D "phy"; > > > + #phy-cells =3D <0>; > > > + power-domains =3D <&scmi_devpd IMX95_PD_HSIO_TOP>; > > > + orientation-switch; > > > + status =3D "disabled"; > >=20 > > I got these dtbs check warnings: > >=20 > > arch/arm64/boot/dts/freescale/imx95-tqma9596sa-mb-smarc-2.dtb: > > phy@4c1f0040: 'oneOf' conditional failed, one must be fixed: > > 'port' is a required property > > 'ports' is a required property > > from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-u= sb-phy.yaml# > > arch/arm64/boot/dts/freescale/imx95-tqma9596sa-mb-smarc-2.dtb:=20 > > phy@4c1f0040: Unevaluated properties are not allowed ('orientation-swi= tch' was unexpected) > > from schema $id: http://devicetree.org/schemas/phy/fsl,imx8mq-u= sb-phy.yaml# >=20 > Are you checking on usb tree? You need below two dt-binding patch. >=20 > - dt-bindings: usb: dwc3-imx8mp: add compatible string for imx95 > - dt-bindings: phy: imx8mq-usb: add compatible "fsl,imx95-usb-phy" Yes, these patches are already in linux-next. I'm on next-20241016. > >=20 > >=20 > > How am I supposed to specify a port when the usb3 is used in host mode,= thus > > no USB Type-C connector and no 'port' OF-graph accordingly? >=20 > Host-only mode with Type-A connector? No Typec-C connector? > Sorry, I do not get your meaning. Yes, no Type-C connector. Actually not even a Type-A as there is an on-board USB hub attached to this host. Best regards, Alexander =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/